[CDB] Upload Extensions 3.1.2

[John P]

Thanks Mike,


Add it to github or as a attachment here and I will put it in git.

[MattF]

You should not be using the event listener to load your language files. It appears your language file is only needed on the ACP page... so why load your language files for every single page of the forum - that just wastes resources.

You should instead just use $this->user->add_lang_ext('BoardTools/upload', 'upload'); at the top of your ACP module class, and get rid of the event listener file completely.

As for the language vars used in your module's info_upload.php file, just put those couple of vars in a language file named info_acp_upload.php and they will be autoloaded by the ACP.

[michel_61]

Here is the Zip.

de.zip

reg. Mike

[LavIgor]

Hello,
nice MOD, its function good.
I have it translate in German. Where can i upload this file?
Sorry for my bad english
reg. Mike

You can fork our GitHub repository, add you file to language/[LANGUAGE_NAME] folder and create a PR.
Any translations are appreciated.

P.S. This is not a MOD. This is a phpBB 3.1 extension.

[LavIgor]

Here is the Zip.

de.zip

reg. Mike

Ok, thank you.

You should instead just use $this->user->add_lang_ext('BoardTools/upload', 'upload'); at the top of your ACP module class, and get rid of the event listener file completely.

As for the language vars used in your module's info_upload.php file, just put those couple of vars in a language file named info_acp_upload.php and they will be autoloaded by the ACP.

Ok, edited.

GitHub repository is updated.

[michel_61]

Sorry,
it is very difficult for me to understand what is written here. My English is not good enough. Therefore I know not what I have to do like GitHub.

Translate with google-translate.

reg. Mike

[John P]

It's not necessary Mike, we added your language pack already.

Thanks for it.

[leschek]

Nice extension.
I would like to ask if would be possible to upload language files additionally? I mean lets say that I upload extension with your extension to server and than some translator translate this extension, so I would like to upload it too into the already installed extension. I guess there would have to be some rules about packing the language files to make it work... Anyway it's just an idea.

EDIT: I deleted question about updating of extensions (it is mentioned in description of you extension in ACP)

[John P]

If you unpack the new extension's zip again it will put the language file(s) in the folder where it belongs or create the folder first. So put the language folder in the extensions zip and unpack again.

[leschek]

Thank you. I thought it could be possible without repacking the extension.

[Jessica]

Great extension!

[John P]

Thanks

[Holger]

Maybe a stupid question, but: many authors provide github-links to theire work. Would it be possible to include a possibility to directly transfer extensions from github?

[Mess]

I'm guessing that's already possible? I guess it depends on how the developers setup their repos?

[david63]

I guess it depends on how the developers setup their repos?

As the packaging instructions have not been defined yet (or at least not published) then currently a developer can do as they want. Once the packaging instructions are published then there should be some degree of consistency.