[CDB] Thanks for posts

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
spello
Registered User
Posts: 126
Joined: Sat May 28, 2011 11:12 am

Re: [DEV] Thanks for posts

Post by spello »

Should work after replacing &amp%3B with &
User avatar
martin123456
I've Been Banned!
Posts: 726
Joined: Sat Mar 05, 2011 7:44 pm

Re: [DEV] Thanks for posts

Post by martin123456 »

spello wrote:Should work after replacing &amp%3B with &
You do know thats wrong right ?

You dont use this & you should use this & http://www.w3schools.com/html/html_entities.asp

Code: Select all

<!-- IF S_CODE_UNTIDY and S_MESS_ON_INDEX Good If_Not_TIDY_Then_SUBMIT -->
nachtelb
Registered User
Posts: 158
Joined: Sun Feb 19, 2006 2:00 pm
Location: Germany
Name: Bernhard

Re: [DEV] Thanks for posts

Post by nachtelb »

"topic does not exist" is a bug in phpBB 3.1.1 and happens in various situations, its already in the tracker
poplarman
Registered User
Posts: 51
Joined: Mon Aug 25, 2008 3:30 pm

Re: [DEV] Thanks for posts

Post by poplarman »

Hello,

phpbb v3.1

When I click on "Remove your thanks:" I receive "The requested topic does not exist." on clicking "Are you sure you want to remove your thanks?"

http://www.1420h.org.uk/ForumDEV/viewto ... from_id=49
then
Image

Is this the problem?
rxu
Extensions Development Team
Posts: 4018
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation

Re: [DEV] Thanks for posts

Post by rxu »

poplarman

Several posts right above yours answer your question ;)
User avatar
martin123456
I've Been Banned!
Posts: 726
Joined: Sat Mar 05, 2011 7:44 pm

Re: [DEV] Thanks for posts

Post by martin123456 »

What file is &amp%3B in as kwrite is not finding it at all.

Code: Select all

<!-- IF S_CODE_UNTIDY and S_MESS_ON_INDEX Good If_Not_TIDY_Then_SUBMIT -->
spello
Registered User
Posts: 126
Joined: Sat May 28, 2011 11:12 am

Re: [DEV] Thanks for posts

Post by spello »

martin123456 wrote:You do know thats wrong right ?
Me? :P &amp%3B will never work in browser's URL path. Should be: &
poplarman
Registered User
Posts: 51
Joined: Mon Aug 25, 2008 3:30 pm

Re: [DEV] Thanks for posts

Post by poplarman »

In HTML '&' should be encoded as &
User avatar
martin123456
I've Been Banned!
Posts: 726
Joined: Sat Mar 05, 2011 7:44 pm

Re: [DEV] Thanks for posts

Post by martin123456 »

spello wrote:
martin123456 wrote:You do know thats wrong right ?
Me? :P &amp%3B will never work in browser's URL path. Should be: &
Yes this& should be this& as i stated a few posts back.

Code: Select all

<!-- IF S_CODE_UNTIDY and S_MESS_ON_INDEX Good If_Not_TIDY_Then_SUBMIT -->
rxu
Extensions Development Team
Posts: 4018
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation

Re: [DEV] Thanks for posts

Post by rxu »

sopi wrote:If the rating system is disabled, the link will remain in the quick-links-menu (but link to a "was disabled" page).
I would much rather get rid of the link all together.

Secondly, there is a list-all-thanks-page (which is also linked in the quick-links-menu).
Since my users tend to be very competitive, I would love to disable this function too (as well as vanish the link -- or at least vanish the link).

Is there an easy way to do that?
cheers
sopi :)
Hmm. Rechecked the extension code and it looks like this is already implemented.
You can control displaying of toplist/thankslist pages by applying 'u_viewtoplist' ('Can view list of all thanks') and 'u_viewthanks' ('Can view toplist') permissions respectively.
poplarman
Registered User
Posts: 51
Joined: Mon Aug 25, 2008 3:30 pm

Re: [DEV] Thanks for posts

Post by poplarman »

poplarman wrote:Hello,
phpbb v3.1
When I click on "Remove your thanks:" I receive "The requested topic does not exist." on clicking "Are you sure you want to remove your thanks?"
http://www.1420h.org.uk/ForumDEV/viewto ... from_id=49
then
Image
Is this the problem?
Can you please say if this has been resolved yet?
rxu
Extensions Development Team
Posts: 4018
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation

Re: [DEV] Thanks for posts

Post by rxu »

poplarman wrote:Can you please say if this has been resolved yet?
Yes, for now this phpBB core bug has been resolved by this patch: https://github.com/phpbb/phpbb/pull/3107/files. This will be probably refactored later but currently this is the solution.

EDIT: and now this patch has been replaced with the new one https://github.com/phpbb/phpbb/pull/3140/files so #3107 is no longer valid.
poplarman
Registered User
Posts: 51
Joined: Mon Aug 25, 2008 3:30 pm

Re: [DEV] Thanks for posts

Post by poplarman »

rxu wrote:EDIT: and now this patch has been replaced with the new one https://github.com/phpbb/phpbb/pull/3140/files so #3107 is no longer valid.
Thank you. That's a lot of edits. Is there somewhere I can download these changed 16 files? Also, I'm lost, I don't seem to have a folder 'tests/' anywhere.
rxu
Extensions Development Team
Posts: 4018
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation

Re: [DEV] Thanks for posts

Post by rxu »

poplarman wrote:I don't seem to have a folder 'tests/' anywhere.
This is a service code so you don't need that at all :)
Yuo need to replace only first 7 files and purge the cache for this to work. But this can be related to the board failures so I wouldn't reccomend to do that unless you're comfortable with errors debugging.
poplarman
Registered User
Posts: 51
Joined: Mon Aug 25, 2008 3:30 pm

Re: [DEV] Thanks for posts

Post by poplarman »

rxu wrote:
poplarman wrote:I don't seem to have a folder 'tests/' anywhere.
This is a service code so you don't need that at all :)
Yuo need to replace only first 7 files and purge the cache for this to work. But this can be related to the board failures so I wouldn't reccomend to do that unless you're comfortable with errors debugging.
Thanks again for your prompt reply - top noggin :)

Return to “Extensions in Development”