[CDB] RH Topic Tags

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Kailey
Community Team Leader
Community Team Leader
Posts: 3803
Joined: Mon Sep 01, 2014 1:00 am
Location: sudo rm -rf /
Name: Kailey Snay

Re: [DEV] Topic Tags

Post by Kailey »

Out of curiosity, why are you running the strtolower function on tags? Also, some of your SQL queries - you should probably (int) your variables where you expect them (for example, $topic_id).
Kailey Snay - Community Team Leader
Knowledge Base | Documentation | Community rules
If you have any questions about the rules/customs of this website, feel free to send me a PM.

My little corner of the world | Administrator @ phpBB Modders
combuster
Registered User
Posts: 352
Joined: Sun Oct 26, 2008 11:58 pm

Re: [DEV] Topic Tags

Post by combuster »

@leschek:
1) Thank you
2) Thanks, I will completely seperate those sentences.
(EDIT: https://github.com/RobertHeim/phpbb-ext ... 251f33d6e4 )
kmtruscott wrote:Out of curiosity, why are you running the strtolower function on tags?
Well, there is no other reason for it than during prototyping a tag for me was lower case^^ - it's just easier and a little more performant if we do not store "tutorial", "Tutorial" and "tuTorial" - BUT: A regex defining which tags are valid and which are not will be added anyway - and I plan to make it configurable in ACP (https://github.com/RobertHeim/phpbb-ext ... /issues/11 ). However, during search it is not planned to implement case-sensitive features and I will search case-insensitive. (So you will find "tutorial" when searching for "tuTorial". If you need more case-sensitive features, feel free to implement them and offer a pull request on github. I might merge them.
Also, some of your SQL queries - you should probably (int) your variables where you expect them (for example, $topic_id).
can you comment these lines on github? would be great! =)
User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 11116
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo

Re: [DEV] Topic Tags

Post by Raul [ThE KuKa] »

Spanish translation added "PR". ;)
All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies | Styles Queue Stats :warning:


If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate.
:flag_es: phpBB Spain - Online Since 2003 :heart:


User avatar
Kailey
Community Team Leader
Community Team Leader
Posts: 3803
Joined: Mon Sep 01, 2014 1:00 am
Location: sudo rm -rf /
Name: Kailey Snay

Re: [DEV] Topic Tags

Post by Kailey »

combuster wrote:Well, there is no other reason for it than during prototyping a tag for me was lower case^^ - it's just easier and a little more performant if we do not store "tutorial", "Tutorial" and "tuTorial" - BUT: A regex defining which tags are valid and which are not will be added anyway - and I plan to make it configurable in ACP (https://github.com/RobertHeim/phpbb-ext ... /issues/11 ). However, during search it is not planned to implement case-sensitive features and I will search case-insensitive. (So you will find "tutorial" when searching for "tuTorial". If you need more case-sensitive features, feel free to implement them and offer a pull request on github. I might merge them.
To prevent duplicate tags, you could pull the tags and strtolower those when searching. This will allow you to keep the case when tags are added. If I get time, I'll see if I can create a pull request, but I've got a busy 2 weeks coming up.
combuster wrote:can you comment these lines on github? would be great! =)
I did a quick run-through and it looks like only 2 lines, but you might want to double-check. I created an issue for it here.
Kailey Snay - Community Team Leader
Knowledge Base | Documentation | Community rules
If you have any questions about the rules/customs of this website, feel free to send me a PM.

My little corner of the world | Administrator @ phpBB Modders
combuster
Registered User
Posts: 352
Joined: Sun Oct 26, 2008 11:58 pm

Re: [DEV] Topic Tags

Post by combuster »

Regarding search and case sensitivity: Actually, I implemented now, that you can configure a regex in ACP. There you can allow for case-sensitive or insensitive behaviour like you want. By default its case-sensitive for storing the tags, now. The search is by default insensitive (so you find "tutorial" as well as "tuTorial", but I adjusted the route so you can even search case-sensitive by using /tag/{tags}/{mode}/true.
It will be in next release (or you can download master branch)

@kmtruscott: thanks for the issue, I have double-checked the hole code, updated it and closed the issue. :)
combuster
Registered User
Posts: 352
Joined: Sun Oct 26, 2008 11:58 pm

Re: [DEV] Topic Tags

Post by combuster »

Alright,

I added a lot of stuff and bug-fixes! Features see https://github.com/RobertHeim/phpbb-ext ... d#features download see first post! =)

Actually this pre-release implements all planned features and we could go to RC soon =)
SB_1
Registered User
Posts: 21
Joined: Tue Aug 23, 2011 7:31 pm

Re: [DEV] Topic Tags

Post by SB_1 »

I have a suggestion for this extension. I think it would be great if the tags could be displayed next to or just below a topic title in viewforum.php. This way users could easily search for similar topics on certain subjects whilst browsing forums. :)
combuster
Registered User
Posts: 352
Joined: Sun Oct 26, 2008 11:58 pm

Re: [DEV] Topic Tags

Post by combuster »

SB_1 wrote:I have a suggestion for this extension. I think it would be great if the tags could be displayed next to or just below a topic title in viewforum.php. This way users could easily search for similar topics on certain subjects whilst browsing forums. :)
Hi, thx! I implemented it and added an ACP option to disable it. It will be in next release =)
combuster
Registered User
Posts: 352
Joined: Sun Oct 26, 2008 11:58 pm

Re: [DEV] Topic Tags

Post by combuster »

I updated screenshots and draft the next release, for download links please refer to the first post.
SB_1
Registered User
Posts: 21
Joined: Tue Aug 23, 2011 7:31 pm

Re: [DEV] Topic Tags

Post by SB_1 »

combuster wrote:
SB_1 wrote:I have a suggestion for this extension. I think it would be great if the tags could be displayed next to or just below a topic title in viewforum.php. This way users could easily search for similar topics on certain subjects whilst browsing forums. :)
Hi, thx! I implemented it and added an ACP option to disable it. It will be in next release =)
Great. I've looked at the screenshots. Maybe it would be better to display the tags like they are in the tag cloud, like little labels, to make them stand out more from other plain text content on the viewforum page?

I made a very quick mockup. Something like this:
Image
combuster
Registered User
Posts: 352
Joined: Sun Oct 26, 2008 11:58 pm

Re: [DEV] Topic Tags

Post by combuster »

Hi,

I updated first post to pre-release 0.0.7-DEV which comes with styled tags in viewtopic and viewforum.

@SB_1: thx for suggestion ;)
leschek
Registered User
Posts: 853
Joined: Tue Jul 18, 2006 12:49 pm

Re: [DEV] Topic Tags

Post by leschek »

I tried to update and got this error:

Code: Select all

Fatal error: Cannot redeclare class robertheim\topictags\migrations\release_0_0_7 in /xxx/yyy/zzz/forum1_phpBB31/ext/robertheim/topictags/migrations/releases_0_0_7.php on line 0
It seems that file ext\robertheim\topictags\migrations\releases_0_0_7.php should be release_0_0_7.php (without "s").
combuster
Registered User
Posts: 352
Joined: Sun Oct 26, 2008 11:58 pm

Re: [DEV] Topic Tags

Post by combuster »

@leschek: thx for reporting! I fixed the release.
leschek
Registered User
Posts: 853
Joined: Tue Jul 18, 2006 12:49 pm

Re: [DEV] Topic Tags

Post by leschek »

No worries.
I have a few ideas. Maybe you will find some of them interesting:

1. Button in settings to allow tagging in all forums at once (something like in "Post settings" for the quick reply).

2. Tag cloud in section where the "Who is online", "Birthdays" and "Statistics" are. I can imagine setting in ACP to allow it. There also could be option to show there 20 (or so) most used tags (instead to show all tags).

3. I would like to have some option, which allow admin to control what tags are used. I'm bit afraid that users would mess up things. For example they could use tags: battery, batery, batteries instead of word "Battery". BTW will the tag "battery" (with small letter) find topic tagged as "Battery" (with capital letter)?

4. Permission who can add tags to topics.

5. I believe that some users who will use this extension use in phpBB 3.0.x Topic SEO description and keywords mod. It would be awesome if the tags from that MOD could be imported into your extension.

EDIT: Cold you help me with regular expression, please? I would like to use in tags non English alphabet letters, dots and spaces. For example I'm not able to use the following tags in the topic (without quotes): "phpBB 3.1,čeština" (čeština=Czech language).
FomenkoAndrey
Registered User
Posts: 369
Joined: Thu Aug 19, 2010 10:44 am

Re: [DEV] Topic Tags

Post by FomenkoAndrey »

leschek wrote:2. Tag cloud in section where the "Who is online", "Birthdays" and "Statistics" are
+
leschek wrote:There also could be option to show there 20 (or so) most used tags (instead to show all tags).
+
leschek wrote:3. I would like to have some option, which allow admin to control what tags are used.
+
leschek wrote:4. Permission who can add tags to topics.
+

Return to “Extensions in Development”