[CDB] RH Topic Tags

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
combuster
Registered User
Posts: 351
Joined: Sun Oct 26, 2008 11:58 pm

Re: [RC] RH Topic Tags

Post by combuster »

floxx wrote: I've seen a problem during using this extension. After I wrote the tags, when I send the message, the tags doesn't appears... I must edit the message to write again the tags.
When editing, is the tag already there or do you need to enter it again?
combuster
Registered User
Posts: 351
Joined: Sun Oct 26, 2008 11:58 pm

Re: [RC] RH Topic Tags

Post by combuster »

@floxx and @feliciamay , I can reproduce the bug and will have a look at it, you can get status upates here: https://github.com/RobertHeim/phpbb-ext ... /issues/59
floxx
Registered User
Posts: 38
Joined: Thu Nov 03, 2011 9:51 pm

Re: [RC] RH Topic Tags

Post by floxx »

combuster wrote:
floxx wrote: I've seen a problem during using this extension. After I wrote the tags, when I send the message, the tags doesn't appears... I must edit the message to write again the tags.
When editing, is the tag already there or do you need to enter it again?
Sorry i'm late.
When i'm editing, i have to enter the tag again, and after it's working. But, if i edit again, i have to enter again the tags.

Thanks for the issue status link on github ;)

Good luck to fix it
combuster
Registered User
Posts: 351
Joined: Sun Oct 26, 2008 11:58 pm

Re: [RC] RH Topic Tags

Post by combuster »

I already fixed it, you can use current master version if you want.
TriKe27
Registered User
Posts: 18
Joined: Wed Feb 25, 2015 6:30 pm

Re: [RC] RH Topic Tags

Post by TriKe27 »

Hello,

how do you think this ext affect search engines? Positively? Or maybe, in worst case, negatively because of keyword-spam?


Thanks in advance

Martin
User avatar
piatachki
Registered User
Posts: 24
Joined: Fri Jul 03, 2015 2:57 pm
Location: Moscow
Name: Vasily Batishchev
Contact:

Re: [RC] RH Topic Tags

Post by piatachki »

Author, thank you for cool extension! Exellent!

What you think about change at Russian language pack string

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[\- a-z0-9]{3,30}$/i',
to

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[A-я0-9]{3,30}$/i',
to allow Russian tags by default?
combuster
Registered User
Posts: 351
Joined: Sun Oct 26, 2008 11:58 pm

Re: [RC] RH Topic Tags

Post by combuster »

piatachki wrote:What you think about change at Russian language pack string

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[\- a-z0-9]{3,30}$/i',
to

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[A-я0-9]{3,30}$/i',
to allow Russian tags by default?
Seems good, we also need to adjust

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_EXP_FOR_USERS_DEFAULT'	=> '-, 0-9, a-z, A-Z, пробелы (будут конвертированы -), мин: 3, макс: 30',
As I am not able to speak russian, someone needs to adjust it. Best would be a pull-request on github for such improvements!
User avatar
piatachki
Registered User
Posts: 24
Joined: Fri Jul 03, 2015 2:57 pm
Location: Moscow
Name: Vasily Batishchev
Contact:

Re: [RC] RH Topic Tags

Post by piatachki »

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_EXP_FOR_USERS_DEFAULT'   => 'Допускаются буквы, цифры, дефисы и пробелы (будут конвертированы в дефисы). Мин.: 3 символов, макс.: 30 символов',
User avatar
piatachki
Registered User
Posts: 24
Joined: Fri Jul 03, 2015 2:57 pm
Location: Moscow
Name: Vasily Batishchev
Contact:

Re: [RC] RH Topic Tags

Post by piatachki »

Hm, there is some problem

When user create new topic, he is filling tags. After it if user attach file to post then tags disappear, when page save.

1. Fill the subject
2. Fill tags
3. Fill post body
4. Attach file
5. Save page
6. Tags disappear

Does anybody have similar?
combuster
Registered User
Posts: 351
Joined: Sun Oct 26, 2008 11:58 pm

Re: [RC] RH Topic Tags

Post by combuster »

piatachki wrote:

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[A-я0-9]{3,30}$/i',
Have you actually tested this regex?
piatachki wrote: When user create new topic, he is filling tags. After it if user attach file to post then tags disappear, when page save.
Which version of RH Topic Tags are you using?
User avatar
piatachki
Registered User
Posts: 24
Joined: Fri Jul 03, 2015 2:57 pm
Location: Moscow
Name: Vasily Batishchev
Contact:

Re: [RC] RH Topic Tags

Post by piatachki »

combuster wrote:Have you actually tested this regex?
This string works on my forum correctly, but i allow only literal and numeric symbols without "-", spaces etc.

If you wait till tomorrow, i'll test more common regexp with "-" and spaces:

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_DEFAULT'            => '/^[\- A-я0-9]{3,30}$/i',
combuster wrote:Which version of RH Topic Tags are you using?
0.0.14-RC1
User avatar
piatachki
Registered User
Posts: 24
Joined: Fri Jul 03, 2015 2:57 pm
Location: Moscow
Name: Vasily Batishchev
Contact:

Re: [RC] RH Topic Tags

Post by piatachki »

Ok. Common regexp tested

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_DEFAULT'            => '/^[\- A-я0-9]{3,30}$/i',
Image
combuster
Registered User
Posts: 351
Joined: Sun Oct 26, 2008 11:58 pm

Re: [RC] RH Topic Tags

Post by combuster »

piatachki wrote:
0.0.14-RC1
you should update to 1.0.1 which should fix your bug regarding editing first post.
FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am

Re: [RC] RH Topic Tags

Post by FomenkoAndrey »

v.1.0.1
why this extension creates +40 queries on page viewforum (was 33-34, became 74)?
combuster
Registered User
Posts: 351
Joined: Sun Oct 26, 2008 11:58 pm

Re: [RC] RH Topic Tags

Post by combuster »

FomenkoAndrey wrote:v.1.0.1
why this extension creates +40 queries on page viewforum (was 33-34, became 74)?
I will optimize db usage in some of the next releases.
Locked

Return to “Extensions in Development”