[CDB] RH Topic Tags

[combuster]

I've seen a problem during using this extension. After I wrote the tags, when I send the message, the tags doesn't appears... I must edit the message to write again the tags.

When editing, is the tag already there or do you need to enter it again?

[combuster]

@floxx and @feliciamay , I can reproduce the bug and will have a look at it, you can get status upates here: https://github.com/RobertHeim/phpbb-ext ... /issues/59

[floxx]

I've seen a problem during using this extension. After I wrote the tags, when I send the message, the tags doesn't appears... I must edit the message to write again the tags.

When editing, is the tag already there or do you need to enter it again?

Sorry i'm late.
When i'm editing, i have to enter the tag again, and after it's working. But, if i edit again, i have to enter again the tags.

Thanks for the issue status link on github

Good luck to fix it

[combuster]

I already fixed it, you can use current master version if you want.

[TriKe27]

Hello,

how do you think this ext affect search engines? Positively? Or maybe, in worst case, negatively because of keyword-spam?


Thanks in advance

Martin

[piatachki]

Author, thank you for cool extension! Exellent!

What you think about change at Russian language pack string

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[\- a-z0-9]{3,30}$/i',

to

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[A-я0-9]{3,30}$/i',

to allow Russian tags by default?

[combuster]

What you think about change at Russian language pack string

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[\- a-z0-9]{3,30}$/i',

to

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[A-я0-9]{3,30}$/i',

to allow Russian tags by default?

Seems good, we also need to adjust

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_EXP_FOR_USERS_DEFAULT'	=> '-, 0-9, a-z, A-Z, пробелы (будут конвертированы -), мин: 3, макс: 30',

As I am not able to speak russian, someone needs to adjust it. Best would be a pull-request on github for such improvements!

[piatachki]

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_EXP_FOR_USERS_DEFAULT'   => 'Допускаются буквы, цифры, дефисы и пробелы (будут конвертированы в дефисы). Мин.: 3 символов, макс.: 30 символов',

[piatachki]

Hm, there is some problem

When user create new topic, he is filling tags. After it if user attach file to post then tags disappear, when page save.

1. Fill the subject
2. Fill tags
3. Fill post body
4. Attach file
5. Save page
6. Tags disappear

Does anybody have similar?

[combuster]

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[A-я0-9]{3,30}$/i',

Have you actually tested this regex?

When user create new topic, he is filling tags. After it if user attach file to post then tags disappear, when page save.

Which version of RH Topic Tags are you using?

[piatachki]

Have you actually tested this regex?

This string works on my forum correctly, but i allow only literal and numeric symbols without "-", spaces etc.

If you wait till tomorrow, i'll test more common regexp with "-" and spaces:

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_DEFAULT'            => '/^[\- A-я0-9]{3,30}$/i',

Which version of RH Topic Tags are you using?

0.0.14-RC1

[piatachki]

Ok. Common regexp tested

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_DEFAULT'            => '/^[\- A-я0-9]{3,30}$/i',

[combuster]

0.0.14-RC1

you should update to 1.0.1 which should fix your bug regarding editing first post.

[FomenkoAndrey]

v.1.0.1
why this extension creates +40 queries on page viewforum (was 33-34, became 74)?

[combuster]

v.1.0.1
why this extension creates +40 queries on page viewforum (was 33-34, became 74)?

I will optimize db usage in some of the next releases.