[DEV] Holiday Flare

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Holger
Registered User
Posts: 1892
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [DEV] Holiday Flare

Post by Holger »

Ok, but the code above works too

So it should be this?

Code: Select all

services:
    phpbbmodders.holidayflare.listener:
        class: phpbbmodders\holidayflare\event\listener
        arguments:
            - '@config'
            - '@template'
        tags:
            - { name: event.listener }
User avatar
RomaamoR
Registered User
Posts: 289
Joined: Tue Feb 24, 2015 4:45 pm
Location: Ukraine
Name: Roman

Re: [DEV] Holiday Flare with 3.3.2

Post by RomaamoR »

RMcGirr83 wrote: Tue Dec 15, 2020 3:09 pm
Incorrect, you want single quotes not double quotes.
Excuse me. Yes. I was wrong. :?
Holger wrote: Tue Dec 15, 2020 3:12 pm Ok, but the code above works too

So it should be this?
Yes.
User avatar
david63
Registered User
Posts: 20646
Joined: Thu Dec 19, 2002 8:08 am

Re: [DEV] Holiday Flare

Post by david63 »

Just for clarification as far as Symfony is concerned it makes no difference as to whether you use double or single quotes
David
Remember: You only know what you know and - you don't know what you don't know!

I now no longer support any of my extensions but they will start to become available here
User avatar
RMcGirr83
Former Team Member
Posts: 22068
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [DEV] Holiday Flare

Post by RMcGirr83 »

Yeah I should have expounded a bit. To stay within phpBB coding guidelines it should be single quotes. Mea culpa.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then you can support me by buying a beer 🍺
donross
Registered User
Posts: 10
Joined: Mon Oct 01, 2018 9:32 am

Re: [DEV] Holiday Flare

Post by donross »

Thanxs for the hint, I will try......
donross
Registered User
Posts: 10
Joined: Mon Oct 01, 2018 9:32 am

Re: [DEV] Holiday Flare

Post by donross »

Works like a charm...thanks a lot!
Bildschirmfoto 2020-12-15 um 17.53.25.jpg
You do not have the required permissions to view the files attached to this post.
User avatar
Galixte de EzCom
Registered User
Posts: 1106
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.

Re: [DEV] Holiday Flare

Post by Galixte de EzCom »

donross wrote: Tue Dec 15, 2020 5:02 pm Works like a charm...thanks a lot!

Bildschirmfoto 2020-12-15 um 17.53.25.jpg
This extension was made for prosilver bases styles. You need to adapt for your style.

I have compiled RMcGirr83's v2.0.1 version with phpBB 3.3.x fix here: https://github.com/Galixte/holiday_flar ... lay-images.

There is another extension dedicated to Christmas holidays here: https://www.phpbb-fr.com/customise/db/e ... antaclaus/
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.2.x & 3.3.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 1106
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.

Re: [DEV] Holiday Flare

Post by Galixte de EzCom »

By the way, this topic should be locked because it’s released in CDB, no?
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.2.x & 3.3.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
RomaamoR
Registered User
Posts: 289
Joined: Tue Feb 24, 2015 4:45 pm
Location: Ukraine
Name: Roman

Re: [DEV] Holiday Flare

Post by RomaamoR »

There is also such a gorgeous extension.

Snow, garland and picture are selected in the admin panel separately, you can combine
The user can turn off snow, a garland or a picture in the personal section, also separately. Author Tatiana5.
Image
Image

https://github.com/Tatiana5/newyeardecor
donross
Registered User
Posts: 10
Joined: Mon Oct 01, 2018 9:32 am

Re: [DEV] Holiday Flare

Post by donross »

Looks very nice, but doen't work for me.

- I made a download from Github
- expand the ZIP (The name is 'newyeardecor-master')
- Upload via FTP

But there is no new Extension to activate in the extension section. ???.

As decribed, tried to name the folder 'Tatiana5' (The subfolder is given as 'newyeardecor-master'). Doesn`t work.

And then:
- named the top-folder 'tatiana5' and the subfolder 'newyeardecor'.

Now it works.
User avatar
ssl
Registered User
Posts: 1988
Joined: Sat Feb 08, 2020 2:15 pm
Location: Le Lude, Pays de la Loire - France
Name: Fred Rimbert

Re: [DEV] Holiday Flare

Post by ssl »

Hi
The best way is to look at the composer.json file, first line: https://github.com/Tatiana5/newyeardeco ... poser.json

Code: Select all

"name": "tatiana5/newyeardecor",
Sorry for my English ... I do my best! :anger_right:

:point_right_tone3: phpBB: 3.3.13 | PHP: 8.3.9
:point_right_tone4: [Kill spam on phpBB] - [Some French translation of extensions]
"Mistress, Mistress someone is bothering me in pm"
donross
Registered User
Posts: 10
Joined: Mon Oct 01, 2018 9:32 am

Re: [DEV] Holiday Flare

Post by donross »

ssl wrote: Wed Dec 16, 2020 8:29 pm The best way is to look at the composer.json file...
That's what i did at last, but the very best way ist to pack extensions with the right structure ;)
User avatar
ssl
Registered User
Posts: 1988
Joined: Sat Feb 08, 2020 2:15 pm
Location: Le Lude, Pays de la Loire - France
Name: Fred Rimbert

Re: [DEV] Holiday Flare

Post by ssl »

It's Github way!
Sorry for my English ... I do my best! :anger_right:

:point_right_tone3: phpBB: 3.3.13 | PHP: 8.3.9
:point_right_tone4: [Kill spam on phpBB] - [Some French translation of extensions]
"Mistress, Mistress someone is bothering me in pm"
User avatar
warmweer
Jr. Extension Validator
Posts: 11784
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: [DEV] Holiday Flare

Post by warmweer »

donross wrote: Wed Dec 16, 2020 8:32 pm
ssl wrote: Wed Dec 16, 2020 8:29 pm The best way is to look at the composer.json file...
That's what i did at last, but the very best way ist to pack extensions with the right structure ;)
A Github packed extension is usually not packed with the same structure as a CDB downloadable extension (which does have the author/extension structure). It's the responsibility of the person who downloads it to unpack and copy the extension structure (always in composer.json).
Spelling is freeware, which means you can use it for free.
On the other hand, it is not open source, which means you cannot change it or publish it in a modified form.


Time flies like an arrow, but fruit flies like a banana.
User avatar
RomaamoR
Registered User
Posts: 289
Joined: Tue Feb 24, 2015 4:45 pm
Location: Ukraine
Name: Roman

Re: [DEV] Holiday Flare

Post by RomaamoR »

warmweer wrote: Wed Dec 16, 2020 8:41 pm
donross wrote: Wed Dec 16, 2020 8:32 pm
ssl wrote: Wed Dec 16, 2020 8:29 pm The best way is to look at the composer.json file...
That's what i did at last, but the very best way ist to pack extensions with the right structure ;)
A Github packed extension is usually not packed with the same structure as a CDB downloadable extension (which does have the author/extension structure). It's the responsibility of the person who downloads it to unpack and copy the extension structure (always in composer.json).

You are not right. You can't think so.

Return to “Extensions in Development”