Just tried a conversion after your latest commit (so from master).
Two problems:
ONE
During the migration I'm getting about 100 errors about a post being to short:
Code: Select all
functions_vb3.php [ 873 ]:
Post ID: Message parser error:
Your message contains too few characters.
I added some log statements and the post do have content, but after parsing, the content disappears.
The conversion does continue, but it looks like it is skipping these posts that are triggering the error.
Example row that is triggering the error:
Code: Select all
INSERT INTO `dbk_post` (`postid`, `threadid`, `parentid`, `username`, `userid`, `title`, `dateline`, `pagetext`, `allowsmilie`, `showsignature`, `ipaddress`, `iconid`, `visible`, `attach`, `infraction`, `reportthreadid`) VALUES
(62466, 252, 62465, 'mosje', 32, '', 1251790238, 'wat een nachtelijke avonturen hier weer! Gelukkig heeft Lucky het goed doorstaan. Marielou en jij zullen wel geradbraakt zijn - maar ach, dat komt ook wel weer goed hè.', 1, 1, '62.195.24.163', 0, 1, 0, 0, 0);
I don't get this error with your version from yesterday.
If I use your new version, but force functions_vb3.php to use ISO-8859-1, the errors/warnings dissappear.
TWO
Finally the conversion crashes with an error:
Code: Select all
SQL ERROR [ mysqli ]
Incorrect string value: '\xE9's, s...' for column 'pf_interesses' at row 3 [1366]
SQL
BACKTRACE
FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()
FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 855
CALL: trigger_error()
FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 194
CALL: phpbb\db\driver\driver->sql_error()
FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 650
CALL: phpbb\db\driver\mysqli->sql_query()
FILE: [ROOT]/install/convertors/functions_vb3.php
LINE: 2470
CALL: phpbb\db\driver\driver->sql_multi_insert()
FILE: [ROOT]/install/install_convert.php(1688) : eval()'d code
LINE: 2
CALL: vb_convert_profile_custom_fields()
FILE: [ROOT]/install/install_convert.php
LINE: 1688
CALL: eval()
FILE: [ROOT]/install/install_convert.php
LINE: 823
CALL: install_convert->jump()
FILE: [ROOT]/install/install_convert.php
LINE: 214
CALL: install_convert->convert_data()
FILE: [ROOT]/install/index.php
LINE: 409
CALL: install_convert->main()
FILE: [ROOT]/install/index.php
LINE: 289
CALL: module->load()
Looks like some invalid characters somewhere, might be caused by the code changes around retrieving the vbulltein encoding? I tried to find which db table and row is causing the problem, but I can't find anything related to column 'pf_interesses'.
charset in vbulletin is utf-8:
Code: Select all
INSERT INTO `dbk_language` (`languageid`, `title`, `userselect`, `options`, `languagecode`, `charset`, `imagesoverride`, `dateoverride`, `timeoverride`, `registereddateoverride`, `calformat1override`, `calformat2override`, `logdateoverride`, `locale`, `decimalsep`, `thousandsep`, `phrasegroup_global`, `phrasegroup_cpglobal`, `phrasegroup_cppermission`, `phrasegroup_forum`, `phrasegroup_calendar`, `phrasegroup_attachment_image`, `phrasegroup_style`, `phrasegroup_logging`, `phrasegroup_cphome`, `phrasegroup_promotion`, `phrasegroup_user`, `phrasegroup_help_faq`, `phrasegroup_sql`, `phrasegroup_subscription`, `phrasegroup_language`, `phrasegroup_bbcode`, `phrasegroup_stats`, `phrasegroup_diagnostic`, `phrasegroup_maintenance`, `phrasegroup_profilefield`, `phrasegroup_thread`, `phrasegroup_timezone`, `phrasegroup_banning`, `phrasegroup_reputation`, `phrasegroup_wol`, `phrasegroup_threadmanage`, `phrasegroup_pm`, `phrasegroup_cpuser`, `phrasegroup_accessmask`, `phrasegroup_cron`, `phrasegroup_moderator`, `phrasegroup_cpoption`, `phrasegroup_cprank`, `phrasegroup_cpusergroup`, `phrasegroup_holiday`, `phrasegroup_posting`, `phrasegroup_poll`, `phrasegroup_fronthelp`, `phrasegroup_register`, `phrasegroup_search`, `phrasegroup_showthread`, `phrasegroup_postbit`, `phrasegroup_forumdisplay`, `phrasegroup_messaging`, `phrasegroup_inlinemod`, `phrasegroup_plugins`, `phrasegroup_cprofilefield`, `phrasegroup_reputationlevel`, `phrasegroup_infraction`, `phrasegroup_infractionlevel`, `phrasegroup_notice`, `phrasegroup_prefix`, `phrasegroup_prefixadmin`, `phrasegroup_album`, `phrasegroup_socialgroups`) VALUES
(4, 'Nederlands', 1, 1, 'en', 'utf-8', '', '', '', '', '', '', '', '', ',', '.', ........
With charset forced to ISO-8859-1, this error also dissappears.
