[CDB] Post Numbers

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
null2
Registered User
Posts: 520
Joined: Wed Jan 20, 2010 11:03 am

Re: [BETA] Post Numbers

Post by null2 »

Last edited by null2 on Sat Jan 02, 2016 9:14 pm, edited 1 time in total.
Sorry for my bad english. I'm from USA.
User avatar
null2
Registered User
Posts: 520
Joined: Wed Jan 20, 2010 11:03 am

Re: [BETA] Post Numbers

Post by null2 »

Due a weird reason, I cant translate common.php using special characters (á, ç, ê, etc). If I do that, translated message is not showed in posts.
Sorry for my bad english. I'm from USA.
User avatar
kasimi
Former Team Member
Posts: 4900
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany

Re: [BETA] Post Numbers

Post by kasimi »

You need to convert them to UTF-8, for example with Notepad++ and then it looks fine.

Thanks for updating the translations!
User avatar
null2
Registered User
Posts: 520
Joined: Wed Jan 20, 2010 11:03 am

Re: [BETA] Post Numbers

Post by null2 »

kasimi wrote:You need to convert them to UTF-8, for example with Notepad++ and then it looks fine.

Thanks for updating the translations!
I used notepad++ to make these translations. In info_acp_postnumbers.php I may use special characters without problems. Problem is only in common.php.
Sorry for my bad english. I'm from USA.
User avatar
kasimi
Former Team Member
Posts: 4900
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany

Re: [BETA] Post Numbers

Post by kasimi »

Open the common.php, go to Encoding in the menu and Convert to UTF-8. I did those steps and the special characters display fine. See the commit: https://github.com/kasimi/phpbb-ext-pos ... 095a4add92
User avatar
null2
Registered User
Posts: 520
Joined: Wed Jan 20, 2010 11:03 am

Re: [BETA] Post Numbers

Post by null2 »

Solved, thanks!

New translations files for 1.0.4 version:

pt-br: https://www.sendspace.com/file/4uw2pe

es: https://www.sendspace.com/file/wkvs0d
Sorry for my bad english. I'm from USA.
User avatar
alhitary
Registered User
Posts: 868
Joined: Wed Jan 17, 2007 7:51 am
Location: ROY
Name: Bassel Taha

Re: [BETA] Post Numbers

Post by alhitary »

Unsupported browsers display a promt containing the post link instead
what does promt means ?
what does it look like ?
User avatar
kasimi
Former Team Member
Posts: 4900
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany

Re: [BETA] Post Numbers

Post by kasimi »

This is a prompt:

Image
User avatar
alhitary
Registered User
Posts: 868
Joined: Wed Jan 17, 2007 7:51 am
Location: ROY
Name: Bassel Taha

Re: [BETA] Post Numbers

Post by alhitary »

Thanks alot
I updated the Arabic Files : https://github.com/kasimi/phpbb-ext-postnumbers/pull/7
User avatar
gtsoukn
Registered User
Posts: 44
Joined: Sat Jul 07, 2012 8:36 pm
Location: Greece
Name: George

Re: [BETA] Post Numbers

Post by gtsoukn »

Thanks for the extension!!!

Here is the Greek translation for v.1.0.4
igorbond
Registered User
Posts: 138
Joined: Sun Mar 24, 2013 5:54 pm

Re: [BETA] Post Numbers

Post by igorbond »

Translated into Russian (Cyrillic) https://yadi.sk/d/nThQWfq7oFF32
Image
User avatar
Miri4ever
Registered User
Posts: 608
Joined: Sat Mar 07, 2015 11:18 am

Re: [BETA] Post Numbers

Post by Miri4ever »

Having some problems with this extension since 3.1.7. It shows me everything twice a time. If I disable everything is looking fine. Don't know why I now see the Links this way:

Ungelesener Beitrag [b]#6922 ##6922[/b] » Vor 5 Monaten
Homepage: Terra Oceanica

Extension Developments:
PHPBB Games Solitaire, MChat Poker, MChat Black Jack, MChat Cards, MChat Trivia
PHPBB Special Effects, Mousepointers, X-Mas Themes and Designs for PBWoW Style.
Supported work: (**New Updated** UCP Sidebar), Tables, Hide, PBWow3 Style
User avatar
kasimi
Former Team Member
Posts: 4900
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany

Re: [BETA] Post Numbers

Post by kasimi »

The only possible explanation for this is that the event core.viewtopic_modify_post_row is triggered twice for each post which is not supposed to happen. Did you install any other extension around the time you were upgrading to 3.1.7?

I could add a check so that post numbers are only added when the event is triggered for the first time, but that's just fixing the symptoms as most likely something else is not working as intended.

Does this also happen in the MCP topic review or in the topic review when replying?
User avatar
Miri4ever
Registered User
Posts: 608
Joined: Sat Mar 07, 2015 11:18 am

Re: [BETA] Post Numbers

Post by Miri4ever »

No MCP and Review Windows are fine with display. Just inside Viewtopic. I also found out this one here:

-> First Link /viewtopic.php?p=6882#p6882
-> Second Link /viewtopic.php?f=46&t=1491#p6882
Homepage: Terra Oceanica

Extension Developments:
PHPBB Games Solitaire, MChat Poker, MChat Black Jack, MChat Cards, MChat Trivia
PHPBB Special Effects, Mousepointers, X-Mas Themes and Designs for PBWoW Style.
Supported work: (**New Updated** UCP Sidebar), Tables, Hide, PBWow3 Style
User avatar
kasimi
Former Team Member
Posts: 4900
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany

Re: [RC] Post Numbers

Post by kasimi »

Aha, mystery solved. You're using the PBWoW3 style which includes this piece of code:

Code: Select all

<a href="#p{postrow.POST_ID}">#{postrow.POST_NUMBER}</a>
It so happens that phpBB already generates a number for each post and makes it available to the template files. In prosilver this number isn't used. However, in PBWoW3, it is. My extension simply adds its numbers in addition to the already existing numbers from your style, that's why you see them twice.

My extension calculates this number in a more sophisticated way, for example you can skip unapproved and soft-deleted posts. In contrast to phpBB's numbering, reverting the order of the posts is also supported. And don't forget the copy-on-click feature. :)

Anyway, there are two ways for you to fix this:
  1. If you are happy with phpBB's internal post numbering system you can uninstall my extension.
  2. If you want to keep using my extension you need to remove above mentioned code from the style's viewtopic_body.html
I almost forgot, thanks igorbond for the translation. I have updated the download for 1.0.4 and submitted it for validation.

Return to “Extensions in Development”