[ABD] Browser & OS in Viewtopic

[Miri4ever]

My Opera Browser is displayed as Chrome ?? Is this correct ?

[dmzx]

My Opera Browser is displayed as Chrome ?? Is this correct ?

Send you a PM

[Miri4ever]

Somehow missed the update for windows 10

I looked inside your code and mine and both having Opera Developer inside the lines for listed browsers, but still getting Chrome Browser displayed.

[null2]

If moderator change a message, extension will update to browser and OS moderator infornation. Shouldnt keep original poster information?

[cYbercOsmOnauT]

This extension does not write anything into the POSTS_TABLE but just parses the user_agent field of a postrow. phpBB does not differ between a moderator change or an edit of the user himself. When the message gets edited the user_agent is updated along with the rest of the post data.

@dmzx, this kind of stuff

Code: Select all

if (substr($version, 0, 3) == 6.0) 

is not really well. You should not mix types in an if and always write it so that it would also work with ===. You are comparing a string with a float number.

[null2]

This extension has a "feature" which I dont like: If a moderator edits a post, it will save moderator browser and OS informations, instead to keep original information.

So, I changed file ext/dmzx/browsericon/event/listener.php to update that only in a new post or in a reply. In the file bottom, I changed that:

Code: Select all

public function submit_post_modify_sql_data($event)
{
	$post = $this->request->get_super_global(\phpbb\request\request::SERVER);
	$sql_data = $event['sql_data'];
	if (($event['post_mode'] == 'post') || ($event['post_mode'] == 'reply')) {
		$sql_data[POSTS_TABLE]['sql']['user_agent'] = $post['HTTP_USER_AGENT'];
	}
	$event['sql_data'] = $sql_data;
}

It solved my problem but the best option should be comparing original poster with editing poster. But I dont have skill to do that...

[sakkiotto]

for tapatalk users???

[Difadon]

Hello,

I added support for Android, iPhone and Windows Phone (iPhone + Windows Phone -> I can´t testing).

Perhaps someone can handle distribution for the version.

1. Open file */includes/user_agent.php

2. Find:

Code: Select all

$systems = array('Amiga', 'BeOS', 'FreeBSD', 'HP-UX', 'Linux', 'NetBSD', 'OS/2', 'SunOS', 'Symbian', 'Unix', 'Windows', 'Sun', 'Macintosh', 'Mac');

Replace with:

Code: Select all

$systems = array('Amiga', 'BeOS', 'FreeBSD', 'HP-UX', 'Linux', 'NetBSD', 'OS/2', 'SunOS', 'Symbian', 'Unix', 'Windows', 'Sun', 'Macintosh', 'Mac', 'Android', 'iPhone', 'Windows Phone');

3. Find:

Code: Select all

if (substr($version, 0, 3) == 10.0)
				$system = 'Windows 10';
		}
	}

Add after:

Code: Select all

	elseif ($system == 'Android')
	{
		$system = 'Android';
	}
	elseif ($system == 'iPhone')
	{
		$system = 'iPhone';
	}
	elseif ($system == 'Windows Phone')
	{
		$system = 'Windows_Phone';
	}

Upload this pack to */images/user_agent/os/
https://webshare.cz/file/1Me3Bd6kp5/icons-zip

[sysz]

Edit: Never mind.

[Mcclures]

Any way we can add on those OS with the ? mark? I want to add chromebook and arch linux.

[MaFeSa]

Thanks for this extension

[Leinad4Mind]

Hello,

I added support for Android, iPhone and Windows Phone (iPhone + Windows Phone -> I can´t testing).

Perhaps someone can handle distribution for the version.

1. Open file */includes/user_agent.php

2. Find:

Code: Select all

$systems = array('Amiga', 'BeOS', 'FreeBSD', 'HP-UX', 'Linux', 'NetBSD', 'OS/2', 'SunOS', 'Symbian', 'Unix', 'Windows', 'Sun', 'Macintosh', 'Mac');

Replace with:

Code: Select all

$systems = array('Amiga', 'BeOS', 'FreeBSD', 'HP-UX', 'Linux', 'NetBSD', 'OS/2', 'SunOS', 'Symbian', 'Unix', 'Windows', 'Sun', 'Macintosh', 'Mac', 'Android', 'iPhone', 'Windows Phone');

3. Find:

Code: Select all

if (substr($version, 0, 3) == 10.0)
				$system = 'Windows 10';
		}
	}

Add after:

Code: Select all

	elseif ($system == 'Android')
	{
		$system = 'Android';
	}
	elseif ($system == 'iPhone')
	{
		$system = 'iPhone';
	}
	elseif ($system == 'Windows Phone')
	{
		$system = 'Windows_Phone';
	}

Upload this pack to */images/user_agent/os/
https://webshare.cz/file/1Me3Bd6kp5/icons-zip

One year later... LOL
I've submit on Github today.
Cheers

[Paul]

This topic has been marked as [ABD] - Abandoned as the extension author has not been active recently. If the extension author wishes to continue development, please PM anyone on the Extensions Team to request this topic be unlocked.

Notice!
We do not recommend that a user of the phpBB software install this extension, or any other extension that is marked as “abandoned” or “in development”, on a live forum. Doing so may cause your forum to not perform in the manner it should.

Thank you,
The phpBB Extensions Team