[Info] phpBB 3.2 Upgrade Notes for Extensions

[Kailey]

$phpbb_container->get('language');

This doesn't seem to work - unless I'm doing it wrong. I have an ACP module file with the following:

Code: Select all

global $phpbb_container;
$phpbb_container->get('language');
$language->lang('HOME');

I'm still getting the member function error:

[Sun Aug 07 10:53:23 2016] [error] [client 192.168.1.146] PHP Fatal error: Call to a member function lang() on null in /var/www/html/phpBB3/ext/kinerity/homepage/acp/homepage_module.php on line 34, referer: http://www.project-w.org/phpBB3/adm/ind ... eca81&i=12

*EDIT* Nevermind, forgot to actually define $language

[aleha]

If I was to use the language object for translation in an exact same file as the exception files for boardrules, my guess is that the next steps are enough, right?

• For base.php
  • Change add_lang to use the language object instead of the user object.
  • Replace every user object with a language object. That should work for all calls of call_user_func_array.
• For the rest of the files, just replace the user with the language object.

[3Di]

There is already a 3.2-dev branch for board rules, it's up to the author to do some changes there.
https://github.com/phpbb-extensions/boa ... elop-3.2.x

Translators should provide just the language files.

[aleha]

Uhh, I don't know how I missed that. Thank you!

[MarkDHamill]

I am changing $this->user->lang to $this->language>lang in my extension. In my ACP interface though the language strings aren't getting translated, although those on the sidebar and the title and legend are.

mass_subscribe.png

Here is a snippet of my code. There have been no changes below the $submit line except global replaces of $this->user->lang to $this->language>lang:

Code: Select all

class main_module
{

	private $auth;
	private $config;
	private $db;
	private $helper;
	private $language;
	private $pagination;
	private $phpbb_extension_manager;
	private $phpbb_log;
	private $phpbb_path_helper;
	private $phpbb_root_path;
	private $phpEx;
	private $request;
	private $table_prefix;
	private $template;
	private $user;

	function __construct()
	{
		global $phpbb_container;

		// Get global variables via containers to minimize security issues
		$this->phpbb_root_path = $phpbb_container->getParameter('core.root_path');
		$this->phpEx= $phpbb_container->getParameter('core.php_ext');
		$this->table_prefix = $phpbb_container->getParameter('core.table_prefix');

		// Encapsulate certain phpBB objects inside this class to minimize security issues
		$this->auth = $phpbb_container->get('auth');
		$this->config = $phpbb_container->get('config');
		$this->db = $phpbb_container->get('dbal.conn');
		$this->helper = $phpbb_container->get('phpbbservices.digests.common');
		$this->language = $phpbb_container->get('language');
		$this->pagination = $phpbb_container->get('pagination');
		$this->phpbb_extension_manager = $phpbb_container->get('ext.manager');
		$this->phpbb_log = $phpbb_container->get('log');
		$this->phpbb_path_helper = $phpbb_container->get('path_helper');
		$this->request = $phpbb_container->get('request');
		$this->template = $phpbb_container->get('template');
		$this->user = $phpbb_container->get('user');
	}

	function main($id, $mode)
	{

		$this->language->add_lang(array('acp/info_acp_common', 'acp/common'), 'phpbbservices/digests');

		$submit = (isset($_POST['submit'])) ? true : false;

		$form_key = 'phpbbservices/digests';
		add_form_key($form_key);

Any idea what may be causing this problem? You can see the full pre 3.2 source here:

https://github.com/MarkDHamill/digests/ ... module.php

The problem has to be in lines of code like this one, which were basically copied and pasted from an ACP example:

Code: Select all

						'phpbbservices_digests_enable_log'					=> array('lang' => 'DIGESTS_ENABLE_LOG',						'validate' => 'bool',	'type' => 'radio:yes_no', 'explain' => true),

I've experimented changing lang to language and adding a L_ prefix but this suppresses the language constants from even showing up.

[3Di]

try this
$this->language->add_lang('acp/common', 'phpbbservices/digests');
not tested though.

Note, the language object is meant to be used for extensions coded only for phpBB 3.2 or more, not compatible with the 3.1.x series.

Language files starting with info_* or permissions_* are usually automatically loaded, in 3.1.x at least.

[MarkDHamill]

try this
$this->language->add_lang('acp/common', 'phpbbservices/digests');
not tested though.

Note, the language object is meant to be used for extensions coded only for phpBB 3.2 or more, not compatible with the 3.1.x series.

Language files starting with info_* or permissions_* are usually automatically loaded, in 3.1.x at least.

I tried one line at a time for each language file instead of using an array in the first parameter but it made no difference.

See the edit in my last post at the bottom.

[MarkDHamill]

BTW, I upgraded to 3.2 before attempting to make any changes to my extension.

[MarkDHamill]

Okay, figured it out. Previously in this topic there was a discussion about language variables with arrays. So I had to change a line of code from:

Code: Select all

				'TITLE'			=> (isset($this->language->lang[$vars['lang']])) ? $this->language->lang($vars['lang']) : $vars['lang'],

to:

Code: Select all

				'TITLE'			=> (null !== $this->language->lang($vars['lang'])) ? $this->language->lang($vars['lang']) : $vars['lang'],

[RMcGirr83]

Looks like one was missed? Namely dealing with db tools. If a 3.1 extension states the service in the yml file '@dbal.tools' and constructs it in the class as \phpbb\db\tools $db_tools then an error

__construct() must be an instance of phpbb\db\tools, instance of phpbb\db\tools\tools given

[MattF]

Looks like one was missed? Namely dealing with db tools. If a 3.1 extension states the service in the yml file '@dbal.tools' and constructs it in the class as \phpbb\db\tools $db_tools then an error

__construct() must be an instance of phpbb\db\tools, instance of phpbb\db\tools\tools given

Try phpbb\db\tools\tools_interface

[RMcGirr83]

Right, so that would be a BC break from 3.1 to 3.2.

[Paul]

Right, so that would be a BC break from 3.1 to 3.2.

As far I know it will be fixed in 3.2.1.

[martec]

sorry, wrong thread.

[3Di]

Not sure I am missing something, I read the whole topic, but..

how should I translate that line:

foreach ($user->lang['hlposts_tokens'] as $token => $explain)

using the 3.2.'s language object?

edit: forgot to mention the lang it is an array which lies into the language file..

Code: Select all

'hlposts_tokens'	=> array(
	'TOKEN1'		=> 'token1 it is a blah..',
	'TOKEN2'		=> 'token2 it is also blah..',
),