[CDB] Digests 3.2.11

[axe70]

on ucp when user try to change subscriptions settings on my install, when submit on ucp > Digests > Forum Selections, it not subscribe to any forum (if on acp No one by default is option active) or to all forums (if on acp it is set to ALL by default),
this because $elt_fields = $this->request->variable('elt', array('')); result ever empty, substantially the form pass all vars but this is not grabbed somewhere, and as on my test if i'm not wrong can't be, because the var to search for isn't just elt, which the code search for, but maybe this should be switched somewhere in some other code point which i've not see?

ps ops i'm on 3.2.9, but maybe 3.2.10 it's the same

[MarkDHamill]

The way digests work, if a user selects all forums it doesn't store any information in the phpbb_digests_subscribed_forums table. Any existing forum subscriptions are removed. Why? This allows for new forums to be added or forums to be deleted and they will dynamically be included or excluded from the digest.

[axe70]

ok! thank you, yes i assume this is it, but the problem here is another:
the passed var on main_module.php
$elt_fields = $this->request->variable('elt', array(''));
that should contain vars coming from form fired on ucp_digests.html:

when form submitted by user, almost here in my example, the above var result in any case empty.
This the reason of the above code to resolve.
Sorry for the subsequent question then, how and where this should be filled with proper vars?
$this->request->variable('elt', array(''));

p.s i mean on Digest code: where it should been fulfilled as your code is?
the code on prev. post with workaround to this, has been updated to remove the last
$elt_fields = $this->request->variable('elt', array('')); that of course was not needed ... just an on fly wrong copy/paste sorry

p.s 2: beside this, both you and i are 2002 year registered users! WoW time run!

[MarkDHamill]

Yeah, very long time forum member here too!

Code: Select all

$elt_fields = $this->request->variable('elt', array(''));

What the second parameter does is populate $elt_fields with an empty array if there are no fields in the POST request that match the pattern. The function is documented here:

https://github.com/phpbb/phpbb-core/blo ... #L190-L213

If some forums were checked there will be an array of elements in $elt_fields with the name of each element containing a pattern that identifies the forum_id. Otherwise there will be an empty array for the variable, which will tell the program there are no subscribed forums. If there were subscribed forums, they will then be removed. If there are subscribed forums, it will first remove any previously subscribed ones then add the new ones.

[axe70]

Then something goes wrong on my example because
$elt_fields = $this->request->variable('elt', array(''));
ever is empty here.
The form pass as vars something like elt_4_16, how you grab all those vars with just request->variable('elt' ?
Since i replaced all files yesterday with all default to check, and the result was the same, i've think to resolve in this way.
I will try another install as possible, in the while cheers and thank you!

[MarkDHamill]

You are right. Some functionality has changed. Since I haven't touched this code most likely the phpBB code has changed. This was noted in a review I got today as well. I'll be in touch.

[axe70]

Ok! The code on previous post with temporary solution has been changed right now again: this is the right version that fix the issue.
Since vars are passed named differently, should exist something that unify and pass these vars all in one like the above code, that i assume it was before but now not more due to some code changes. Thank you for the great and unique around digests mod!

[MarkDHamill]

It will take some time to make the changes. This code goes back to phpBB 3.0. I have to change the web forms, some Javascript, jQuery and PHP. I suspect some change was made to the $request object. Are you using phpBB 3.2.4? I believe I regression tested this on 3.2.3 before submitting. It's quite surprising this no longer works.

[MarkDHamill]

Okay, here are the code changes against version 3.2.10 to fix the issue with individual forum subscriptions:

https://github.com/MarkDHamill/digests/ ... 38caa1e81e

Changes need to be replicated to the Edit Subscribers interface, which is more complex.

[colinshead]

Hi Mark

The issue above does not currently affect my installation I believe, as I have two sub forums always selected in ACP.

However, a more general question. I assume you are presently in feature lockdown etc. whilst the core team validates the extension. When this is achieved would it be your intention to update the version to 3.2.11 incorporating any code changes which have come to light since you made 3.2.10 available?

All the best

Colin

[MarkDHamill]

Colin, I just got a review yesterday. It was not approved. So if you have additional feature suggestions, let me know and I'll consider them. Yes, any bug fixes are rolled into the next release.

[colinshead]

Hi Mark

Only thought so far is about the UCP Forum Selection facility.

After making a selection, if the user returns to the menu tab, it is reset to the default (whatever set in the ACP). This might be a bit confusing as generally in this type of UI the previous selection would be re-instated if the user returns to the menu tab.

The actual facility for setting the defaults in the ACP are I think perfectly fine.

I think also that the installation instructions could be even more rigorous in more or less insisting that a System Cron using the curl string is needed, and the the server hot-link protection may need adjustment to permit HTML e-mails to be delivered. Although I have been using phpBB for 4/5 years, and installed many extensions, I have to say that the Digests extension has been the most challenging in my experience to install, but also probably the most useful extension for the user.

All the best

Colin

[MarkDHamill]

Not sure what you mean. With the bug fixes, if a user chooses particular forums and submits the form, the next time they go back to that screen those forum selections should be retained.

Digests (as a mod) required the setup of an external cron job. It no longer requires this, which is simpler in a way because it uses phpBB's built in cron. Notifications follow the same policy as digests: they will wait for board traffic to go out if necessary. I agree it makes sense to set up a system cron but I pretty much have to allow it to use the phpBB cron to get it approved.

[kamaleon]

Maybe you could add a box or something to write a message above the digest email...

That would be useful.

[MarkDHamill]

There are warnings in the ACP interface if you read the text, like Digests general settings, that encourage setting up a system cron. As for putting it in the digest itself, these go to subscribers. The technical details are the responsibility of the administrator.