[CDB] Digests 3.2.11

[axe70]

Hello! Sorry for the timing, i'm just over again now, hope to rub some minute after to check around this.
I'm on phpBB 3.2.3, but i assume not change the scenario.
As on my test Mark, still the patch not work.
Assuming that i'm still on 3.2.9, i've by the way applied patches just replacing files (assuming on 3.2.10 nothing change on db about this) but the result is:
$checked_forums = $this->request->variable('forums', array('')); still empty and also $all_forums = $this->request->variable('all_forums', $this->user->data['user_digest_filter_type']); return empty value.
So these vars aren't passed where need to be and the code not fire at same point noted before.
I've see on fly changes done into ext/phpbbservices/digests/styles/all/template/js/digests.js file:
since all js scripts fire onclick, i've not understand why when onmouseover when in ucp -> Digests -> Forums selection, where option Include posts for these forums:, the console return Empty string passed to getElementById()
it seem something you've forget somewhere on code, that so lead after to not grab and assign correctly vars to be passed?
May it is some test code i've leave around, i'll check as soon.

[MarkDHamill]

I would just install the master on GitHub. It will include my changes. It's version 3.2.10 with these changes.

https://github.com/MarkDHamill/digests/tree/master

[colinshead]

Hi Mark

Sorry had not twigged that the 'bug fixes' addressed the issue I had identified.

Re the admins responsibility to set up a System Cron, I agree but using the curl string is probably stretching the capability of most admins a bit far. It would obviously be much better if phpBB core functionality included the equivalent of the system cron to wake up phpBB at regular intervals; but no chance of that happening I guess.

The other issue you alerted me to was the problem of the server not necessarily delivering images on HTML emails. In my case I had to adjust the hot link protection on the server which seems to have solved the problem.

All the best

Colin

[MarkDHamill]

At least digests will work out of the box so to speak based on board traffic.

I think there was discussion about including a system cron somehow in a future version of phpBB. I don't know if it is planned. That would make things a lot easier.

There are lots of issues with emailing from servers in general, and these can affect other emails from phpBB: mass emails, email notifications, etc. There's not too much the phpBB group can do about it. They have added some list-unsubscribe headers to emails in phpBB 3.2.4. That may help. The basic problem is that emailing is the responsibility of an email server attached to the forum, and its policies will be used. It may block certain outgoing email because it looks spammy, afraid their mail server will go on a blacklist. And the recipient email server may send emails that look to follow a template into a spam folder.

[colinshead]

Thanks Mark

I agree, e-mail servers are a black art in my book !

You may have a minor issue. I have installed your updated 3.2.10 from github, it works as intended, except that the Reset button on the form seems to do nothing, it does not restore the selection to default, which is what I was expecting.

All the best

Colin

[MarkDHamill]

The reset buttons in the UCP work fine for me. There is no programming attached to these buttons, so the browser will do what it should do for a button of type reset: restore it to the condition on page load. Of course if you submit the form, the changes are committed so if you go in again and hit reset, resetting will reflect the changes from the previous submit.

[colinshead]

Hi Mark

Understood, that is exactly the functionality I observe.

All the best

Colin

[axe70]

Beside the javascript reported Mark, i noted that after i switched on admin the option All forums to be selected by default:, all is now working fine. Also after re-switching the option to No. Do not know if it make a sense to you, but here now it seem resolved and working fine with your fixes!

[kamaleon]

I meant to allow admins to write a message to be sent with the digest. Above or below the digest.

[MarkDHamill]

I meant to allow admins to write a message to be sent with the digest. Above or below the digest.

One way to do this is to write a global announcement. These will automatically be included in digests, but of course people on the forum will see it too.

[kamaleon]

Oh really? Did not know that.

You mean with the annoucement extension?

And where are they added? Top? Bottom of digest?

[axe70]

Beside the javascript reported Mark, i noted that after i switched on admin the option All forums to be selected by default:, all is now working fine. Also after re-switching the option to No. Do not know if it make a sense to you, but here now it seem resolved and working fine with your fixes!

to be more precise, if this option
All forums to be selected by default:
is set to YES then all work fine with latest fixes, while not work fine if this option is set to NO on acp
and an user go after to select all forums, and not only some. In this case the result will be no-forums selected at all. Cheers!

[MarkDHamill]

Oh really? Did not know that.

You mean with the annoucement extension?

And where are they added? Top? Bottom of digest?

No, all you need to do is post a global announcement. An administrator can do it in any forum when creating a topic, just click on the radio button "global". A global announcement will appear in any forum. I think the extension puts it on the index.

In the digest global announcements appear before any posts but after any private messages.

[Eichohrkater]

Bounce, cause of being missed.

Thanks for this very nice work.

But for me when trying „Manually run the mailer“ and setting switch „Clear the store“ to Yes, it runs in following Error:

Code: Select all

Fatal error: Uncaught RuntimeException: Directory name must not be empty. in /var/www/vhosts/xxx/httpdocs/forum/ext/phpbbservices/digests/acp/main_module.php:1565 Stack trace: #0 /var/www/vhosts/xxx/httpdocs/forum/ext/phpbbservices/digests/acp/main_module.php(1565): DirectoryIterator->__construct('') #1 /var/www/vhosts/xxx/httpdocs/forum/includes/functions_module.php(676): phpbbservices\digests\acp\main_module->main('\\phpbbservices\\...', 'digests_test') #2 /var/www/vhosts/xxx/httpdocs/forum/adm/index.php(82): p_master->load_active() #3 {main} thrown in /var/www/vhosts/xxx/httpdocs/forum/ext/phpbbservices/digests/acp/main_module.php on line 1565

There is also a small mistake in the German Translation.
In Line 51 there are /' what results in Error. Right would be \'
Sadly, I did not found contact data’s of the translator to inform him myself.


And is there any possibility to disable the digest for specific usergroops or users?
I would prefer to not allow it to fresh registered users.

Thanks

[MarkDHamill]

I made the fix to edit subscribers for individual forum subscriptions, to replicate what I did in the UCP. Changes are here:

https://github.com/MarkDHamill/digests/ ... edd209821d

To install the latest simply download the master on GitHub.