Can't get version check to work on my 1st ext!

Discussion forum for Extension Writers regarding Extension Development.
kaspir
Registered User
Posts: 203
Joined: Sun Jul 27, 2008 5:05 am
Name: Greg
Contact:

Can't get version check to work on my 1st ext!

Post by kaspir » Thu Feb 09, 2017 11:41 am

Self-hosted check.json: https://thetopfew.com/development/phpbb ... check.json

My "extra" in composer.json:

Code: Select all

	"extra": {
		"display-name": "My Bookmarks Quick Link",
		"soft-require": {
			"phpbb/phpbb": ">=3.1.0,<3.3"
		},
		"version-check": {
			"host": "thetopfew.com",
			"directory": "/development/phpbb/ext",
			"filename": "/mybookmarks/version_check.json"
		}
Now, here's the catch. When I rename my htaccess file(to turn off), this self-hosted version checker works with ACP! However, I simply can not find the culprit in my htaccess file, even by disabling one rule at a time, which I've done!

Is there something about https I should know about? I'm still learning but this has been a brick wall, seriously have been thru the htaccess with fine tooth comb!
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P

User avatar
david63
Registered User
Posts: 15910
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: Can't get version check to work on my 1st ext!

Post by david63 » Thu Feb 09, 2017 11:46 am

Not sure if it is the problem but try putting www. before host in your composer.json file.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

kaspir
Registered User
Posts: 203
Joined: Sun Jul 27, 2008 5:05 am
Name: Greg
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kaspir » Thu Feb 09, 2017 11:47 am

david63 wrote:
Thu Feb 09, 2017 11:46 am
Not sure if it is the problem but try putting www. before host in your composer.json file.
THX for the feedback, I tried that already sir. :(
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P

User avatar
kinerity
Community Team Member
Community Team Member
Posts: 2188
Joined: Mon Sep 01, 2014 1:00 am
Location: sudo rm -rf /
Name: Kailey Truscott
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kinerity » Thu Feb 09, 2017 11:53 am

The only thing I can see that is different from the official extensions version_check is your filename.

Code: Select all

    "extra": {
        "display-name": "My Bookmarks Quick Link",
        "soft-require": {
            "phpbb/phpbb": ">=3.1.0,<3.3"
        },
        "version-check": {
            "host": "thetopfew.com",
            "directory": "/development/phpbb/ext/mybookmarks",
            "filename": "version_check.json"
        }
    }
Kailey Truscott - Community Team

kaspir
Registered User
Posts: 203
Joined: Sun Jul 27, 2008 5:05 am
Name: Greg
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kaspir » Thu Feb 09, 2017 12:45 pm

I had it that way originally (followed the instructions to a T), and after speaking to another ext dev, he recommended what I have now and it does work without my htaccess file.

Thx, keep the thoughts coming, PLEASE!
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P

Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 25062
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Can't get version check to work on my 1st ext!

Post by Paul » Thu Feb 09, 2017 12:46 pm

Add a

Code: Select all

"ssl": true
to your file if you use SSL.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

kaspir
Registered User
Posts: 203
Joined: Sun Jul 27, 2008 5:05 am
Name: Greg
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kaspir » Thu Feb 09, 2017 12:52 pm

Paul wrote:
Thu Feb 09, 2017 12:46 pm
Add a

Code: Select all

"ssl": true
to your file if you use SSL.
THX! That's new to me! Just did so, now what? https://thetopfew.com/development/phpbb ... check.json
:(

If anyone of you wish to see my htaccess, I would prefer to PM it, not share it publicly. (reason I'm holding out)


EDIT: Download link for the dev package as of now: https://thetopfew.com/development/phpbb ... .0-dev.zip
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P

Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 25062
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Can't get version check to work on my 1st ext!

Post by Paul » Thu Feb 09, 2017 1:28 pm

Can you try

Code: Select all

"ssl": 1
instead?
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

kaspir
Registered User
Posts: 203
Joined: Sun Jul 27, 2008 5:05 am
Name: Greg
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kaspir » Thu Feb 09, 2017 1:45 pm

Paul wrote:
Thu Feb 09, 2017 1:28 pm
Can you try

Code: Select all

"ssl": 1
instead?
I will try anything you tell me sir! Doing it now, you should see the changes by the time you read this.

EDIT: Okay now we got a change in progress... with my original htaccess active and your new change in version_checker.json. Now in ACP it shows green and verified, BUT if I click re-check version in ACP, it goes to failed again.

Edit2: Okay now the culprit I speak of really does seem to be in the htaccess, combing thru it again, re-adding one rule at a time. Seems that ssl line was a helper!
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P

kaspir
Registered User
Posts: 203
Joined: Sun Jul 27, 2008 5:05 am
Name: Greg
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kaspir » Thu Feb 09, 2017 3:47 pm

Okay, I've done this before but it wasn't as clear as it now with your edit Paul.

The force https rule seems to be the culprit now, I'm sure of it this time. Works when I take it out, doesn't at alI put it back in!

Code: Select all

# Forces HTTPS when http is requested.
	RewriteCond %{HTTPS} off
	RewriteCond %{REQUEST_URI} !^/[0-9]+\..+\.cpaneldcv$
	RewriteCond %{REQUEST_URI} !^/[A-F0-9]{32}\.txt(?:\ Comodo\ DCV)?$
	RewriteRule (.*) https://%{HTTP_HOST}%{REQUEST_URI} [R,L]
So how do I alter this to work on both ends?
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P

Senky
Extension Customisations
Extension Customisations
Posts: 2010
Joined: Thu Apr 30, 2009 8:49 pm
Name: Jakub
Contact:

Re: Can't get version check to work on my 1st ext!

Post by Senky » Thu Feb 09, 2017 4:22 pm

I think Paul meant this:

Code: Select all

    "extra": {
        "display-name": "My Bookmarks Quick Link",
        "soft-require": {
            "phpbb/phpbb": ">=3.1.0,<3.3"
        },
        "version-check": {
            "host": "thetopfew.com",
            "directory": "/development/phpbb/ext/mybookmarks",
            "filename": "version_check.json",
            "ssl": true
        }
    }

kaspir
Registered User
Posts: 203
Joined: Sun Jul 27, 2008 5:05 am
Name: Greg
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kaspir » Thu Feb 09, 2017 4:25 pm

HA! Nevermind.. that's not it.. I have no idea! Lost puppy..
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P

kaspir
Registered User
Posts: 203
Joined: Sun Jul 27, 2008 5:05 am
Name: Greg
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kaspir » Thu Feb 09, 2017 4:26 pm

Senky wrote:
Thu Feb 09, 2017 4:22 pm
I think Paul meant this:

Code: Select all

    "extra": {
        "display-name": "My Bookmarks Quick Link",
        "soft-require": {
            "phpbb/phpbb": ">=3.1.0,<3.3"
        },
        "version-check": {
            "host": "thetopfew.com",
            "directory": "/development/phpbb/ext/mybookmarks",
            "filename": "version_check.json",
            "ssl": true
        }
    }
Specification would help indeed. As it looked like it could go anywhere I guess..

Also, forget the rewrite htaccess... HA! that's not it.. I have no idea! Lost puppy..
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P

kaspir
Registered User
Posts: 203
Joined: Sun Jul 27, 2008 5:05 am
Name: Greg
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kaspir » Thu Feb 09, 2017 4:56 pm

Paul wrote:
Thu Feb 09, 2017 12:46 pm
Add a

Code: Select all

"ssl": true
to your file if you use SSL.
Add this to which file, I've tried both.. would be great to be clear on this, thx!
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P

User avatar
kinerity
Community Team Member
Community Team Member
Posts: 2188
Joined: Mon Sep 01, 2014 1:00 am
Location: sudo rm -rf /
Name: Kailey Truscott
Contact:

Re: Can't get version check to work on my 1st ext!

Post by kinerity » Thu Feb 09, 2017 6:08 pm

kaspir wrote:
Thu Feb 09, 2017 3:47 pm

Code: Select all

# Forces HTTPS when http is requested.
	RewriteCond %{HTTPS} off
	RewriteCond %{REQUEST_URI} !^/[0-9]+\..+\.cpaneldcv$
	RewriteCond %{REQUEST_URI} !^/[A-F0-9]{32}\.txt(?:\ Comodo\ DCV)?$
	RewriteRule (.*) https://%{HTTP_HOST}%{REQUEST_URI} [R,L]
Where did this come from? Image
Kailey Truscott - Community Team

Post Reply

Return to “Extension Writers Discussion”