[CDB] Random Banner Scroll

[Galandas]

Extension Name: Random Banner Scroll
Author: Galandas

Extension Description: This extension allows you to insert Random Banner that flow into a really nice effect. Fully configurable from ACP.

Extension Version:

Requirements: Phpbb 3.3.12, 3.2.11 --- php 7.1.3 || 8.2.9

Features:

• ACP: Enable/Disable
• ACP: you can add new banner
• ACP: You can change the banner
• ACP: you can delete the banner
• ACP: URL Title in tooltip
• banner at random at every page load
• Title or description banner in tooltip
• Administrator Base Permissions
• Integrated Collapsible Forum Categories
• Languages: - -

Screenshots: Click here

Demo: Click here


Extension Download: Click here

[RMcGirr83]

From your acp file

Code: Select all

$submit = (isset($_POST['submit']))

pretty sure will fail validation. Some reason you aren't using the $request class? Happens more than this time in this file.

Code: Select all

$name = utf8_normalize_nfc(request_var('name', ''));

should be

Code: Select all

$name = request_var('name', '', true);

Code: Select all

and isset($edit) and $edit_id != 0 

can simple be

Code: Select all

and !empty($edit_id)

Code: Select all

$action = (isset($_GET['action']) or isset($_POST['action']))

you need to get away from using globals and I am surprised phpBB itself didn't tell you so.

listener file

Code: Select all

        $this->template->assign_block_vars('banner_scroll', array(
        'B_IMG'			=> $row_banner['banner_image'],
        'B_URL'			=> $row_banner['banner_url'],
        ));

not following coding guidelines concerning tabbing.

migrations

Code: Select all

					"banner_url"		=> "http://phpbb3world.altervista.org/community/viewtopic.php?f=68&t=2299#p3582",
					"banner_image"		=> generate_board_url() . '/ext/galandas/bannerscroll/styles/all/theme/images/banner/advanced_login.png',

Why are you hotlinking to your forum?

This extension seems to be a linking extension to your forum.

[Galandas]

Thanks for the tips, I'm not that familiar with phpBB 3.2 definitely adjust everything.
yet not submitted for validation, there are still many things to adjust, as you well to be noticed and reported.

Links are just examples of the pre-set, users can delete quietly and customize, this extension has been created for this.

[Galandas]

Updated version 1.0.1
enhancements to the code, and made compatible with the extension Advanced Active Topics to prevent them from going in conflict, because they use the same js script.

[zardos]

Nice work, i love it, thankyou.

[Galandas]

thankyou
Updated version 1.0.2, more enhancements to the code.

[null2]

Translation to Portuguese-Brazil: https://www.sendspace.com/file/pk0q4h

============

Suggestion: Change default value to "banner_scroll_enable" to 0, to avoid activate this extension after install it and before to define banners. Just change that in galandas\bannerscroll\migrations\release_1_0_0.php, line #51:

array('config.add', array('banner_scroll_enable', 0)),

[Galandas]

Thanks for the translation, I add it in the next version.
Good tips, thanks.

[Galandas]

Updated version 1.0.3, Added Administrator Permissions, And Brazilian Portuguese Language Thanks to null2.

[Galandas]

Updated version 1.0.4, Added Collapsible Forum Categories.

[Fribster]

Awesome Extension and by far the best advertising extension imo..
Ran this random banner 0n 3.0, pretty sure it worked correctly then, running again no on 3.2, but the banner images do not resize for mobile view ?
Even using your standard banners they do not resize correctly on mobile.
The container itself resizes perfectly but not the banner images.
Can you assist with code edits please ?
my board https://f-ribsandsibs.com/forum/

[ac_roma]

useful mod and good work

thank you

[Galandas]

Reupload 2024
Waiting to be validated by the .com team

[danieltj]

What does the extension do? I’ve looked at the screenshots and gone to the demo board and can’t see anything relating to this extension that shows what it does. Does it add an image somewhere to the home page of the forum?

[Galandas]

What does the extension do? I’ve looked at the screenshots and gone to the demo board and can’t see anything relating to this extension that shows what it does. Does it add an image somewhere to the home page of the forum?

I apologize for the inconvenience, I'm updating both my board and the extension, as soon as I'm done I'll put the demo on my forum, for now I'll try to explain myself better.

in practice you can insert more than one banner, by banner I mean an image a logo etc.. etc... each banner logo you insert these are scrolled one after the other in a js effect, all this in the forum index or in the whole forum, in perfect harmony with the phpBB3 style