[Tutorial] Convert to Twig Syntax

[AlfredoRamos]

Code: Select all

var collapseImageIdAlt = '{LA_DIGESTS_COLLAPSE}';
var collapseImageIdTitle = '{LA_DIGESTS_COLLAPSE}';

Try:

Code: Select all

var collapseImageIdAlt = '{{ lang("DIGESTS_COLLAPSE") | escape("js") }}';
var collapseImageIdTitle = '{{ lang("DIGESTS_COLLAPSE") | escape("js") }}';

[MarkDHamill]

Thank you. This works. I suggest changing the first post, removing the addslashes option.

[mrgoldy]

I am not sure if there is an addslashes filter for Twig at the momoment, you can add one yourself.
Perhaps have a look at the Twig escape docs.

And for the language key, you need to add ' for language inputs,
eg: {L_DIGEST_COLLAPSE} becomes {{ lang('DIGEST_COLLAPSE') }}
and {SOME_VARIABLE} becomes {{ SOME_VARIABLE }}

[MarkDHamill]

Since my extension uses the ACP, I am trying to convert a common snippet of template code:

Code: Select all

<!-- BEGIN options -->
	<!-- IF options.S_LEGEND -->
		<!-- IF not options.S_FIRST_ROW -->
			</fieldset>
		<!-- ENDIF -->
		<fieldset>
			<legend>{options.LEGEND}</legend>
	<!-- ELSE -->

		<dl>
			<dt><label for="{options.KEY}">{options.TITLE}{L_COLON}</label><!-- IF options.S_EXPLAIN --><br /><span>{options.TITLE_EXPLAIN}</span><!-- ENDIF --></dt>
			<dd>{options.CONTENT}</dd>
		</dl>

	<!-- ENDIF -->
<!-- END options -->

This looks like it should work:

Code: Select all

{% for option in options %}
	{% if option.S_LEGEND %}
		{% if not loop.first %}
	</fieldset>
		{% endif %}
	<fieldset>
		<legend>{{ option.LEGEND }}</legend>
	{% else %}

	<dl>
		<dt><label for="{{ option.KEY }}">{{ option.TITLE }}{{ lang('COLON') }}</label>{% if option.S_EXPLAIN %}<br><span>{{ option.TITLE_EXPLAIN }}</span>{% endif %}</dt>
		<dd>{{ option.CONTENT }}</dd>
	</dl>

	{% endif %}
{% endfor %}

but this leaves out a </fieldset> before the </form> tag, so it is not valid. Something I am missing?

[david63]

</fieldset> is an HTML tag not a Twig tag so whatever problem you have now you will have had in the past.

[MarkDHamill]

thank you. Next question. How do I convert something like this?

Code: Select all

	<!-- INCLUDE {auth_tpl.TEMPLATE_FILE} -->

[kasimi]

See first post, Includes section, first example. Also have a look at the Twig Converter extension.

[MarkDHamill]

kasimi, you created an awesome extension that saves developers tons of time! I don't particularly want to learn more about the TWIG syntax until I have to dig into it.

I have some language files with the old syntax still embedded in it. Any chance you will update the extension to process these as well?

[kasimi]

I have some language files with the old syntax still embedded in it.

There's template syntax embedded in language files? Do you have an example?

[MarkDHamill]

The messenger class uses template tags that go in the /language/en/email folder, so extensions that do emailing like mine must create them in our extensions. In 3.0 it was not as sophisticated as the full templating system. You could not use loops, for example. Perhaps this is no longer the case.

It wasn't a big deal to convert my language files so I did it manually, but you might want to add it to the files to convert.

Here's part of my digest tree as an example:

https://github.com/MarkDHamill/digests/ ... e/en/email

Your extension certainly saved me hours of tedious work, so thanks again!

[Naguissa]

Hello,


I received this message trying to validate an extension:

{% include 'partials/star_rating.html' %}

Line 27: you should use the @vendor_extname/ prefix here.

I've tried:

Code: Select all

{% include '@vendor_extname/partials/star_rating.html' %}
{% include @vendor_extname'/partials/star_rating.html' %}

Giving me both a blank page (syntax error).


I've asked reporter but didn't receive any feedback.

So, anyone knows how to use it in twig templates? I know hot to use in old templates, but not on twig....



Thanks!

[david63]

Can you not use just {% include 'star_rating.html' %}

[Naguissa]

Can you not use just {% include 'star_rating.html' %}

It works (well, adding the "partials" folder), but seems to be against validation rules.

[3Di]

The problem is your "partial" folder is outside of the "event" one, you should indicate the right route for it.

As per the @vendor_extname/ prefix, who is the vendor and what's the extension name

That should be
{% include '@gfksx_ThanksForPosts/partials/star_rating.html' %}

On a side note, the extension's name can not be CamelCase'd if I am not wrong.

[Naguissa]

The problem is your "partial" folder is outside of the "event" one, you should indicate the right route for it.

As per the @vendor_extname/ prefix, who is the vendor and what's the extension name

That should be
{% include '@gfksx_ThanksForPosts/partials/star_rating.html' %}

Oh, my!!!

In old "html-comments-like" version it was a variable!

On a side note, the extension's name can not be CamelCase'd if I am not wrong.

Interesting... I've not received any report about this, if so it will be a serious trouble....




Thanks!!!