[ABD] Rin Editor for phpBB (WYSIWYG Editor) (Powerd by CKEditor)

[martec]

0.4.7-beta Released

Enhancement

- Add support to Simple mentions 2.0 by request of Octopus (viewtopic.php?p=15950146#p15950146)
※This version doesnt support more Simple mentions 1.0.5

[Miri4ever]

I just tested this feature and I must say, I never used it before. I finally figured out how to get this to work but also noticed this white background color. I made some changes and some changes made and some of the background color did not change. Likewise, I finally noticed the color setup is also applied inside your editor, overwriting my style changes inside the MENTION Extension.

The background for this is not connected with the current style of RinEditor has user has chosen, and just as the anybody mistakes thinking about an only white color to MUST use. Maybe this mention.css style should be connected to the theme folder styles of RinEditor, so an adaption for dark background could be made if this is possible.

[Octopus]

0.4.7-beta Released

Enhancement

- Add support to Simple mentions 2.0 by request of Octopus (viewtopic.php?p=15950146#p15950146)
※This version doesnt support more Simple mentions 1.0.5

Hello martec, thank you very much!

While the extension is just being touched on: wouldn't it also make sense to update the resources of CKeditor and tribute once again? Especially with the CKeditor there were a few security problems (but can't say if they are relevant in this implementation)...

Best regards,
Octopus

[Thank you]

Hello, I have English and Hebrew usernames on my board, and with the latest release simple mention only works with the English usernames, but it's not detecting the Hebrew ones...

[martec]

Hello, I have English and Hebrew usernames on my board, and with the latest release simple mention only works with the English usernames, but it's not detecting the Hebrew ones...

hello,
Could you please test Simple mentions 2.0 with my extension disabled (Rin Editor)?

[Thank you]

Hello, I have English and Hebrew usernames on my board, and with the latest release simple mention only works with the English usernames, but it's not detecting the Hebrew ones...

hello,
Could you please test Simple mentions 2.0 with my extension disabled (Rin Editor)?

Without your extention it works great

[Thank you]

Hello, I have English and Hebrew usernames on my board, and with the latest release simple mention only works with the English usernames, but it's not detecting the Hebrew ones...

hello,
Could you please test Simple mentions 2.0 with my extension disabled (Rin Editor)?

I think you need to replace in rin/editor/styles/all/template/js/automention.js

from this

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:encodeURIComponent(a)},function(a){b(a)})}

to this

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:a},function(a){b(a)})}

makes sense?

[KFMDM Solutions]

the problem is that the search query gets encoded
and it doesn't understand Hebrew characters

is there any reason for encoding the search query?

the original simple mention doesn't encode it

[martec]

hello,
Could you please test Simple mentions 2.0 with my extension disabled (Rin Editor)?

I think you need to replace in rin/editor/styles/all/template/js/automention.js

from this

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:encodeURIComponent(a)},function(a){b(a)})}

to this

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:a},function(a){b(a)})}

makes sense?

The function below is inserted in the past version as well. It could be the cause but it's strange to say that it was in this last version only if the function below was always there.
encodeURIComponent

[KFMDM Solutions]

i don't think it worked in the previous versions

and i tested it with the change and it works perfectly

[Thank you]

I think you need to replace in rin/editor/styles/all/template/js/automention.js

from this

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:encodeURIComponent(a)},function(a){b(a)})}

to this

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:a},function(a){b(a)})}

makes sense?

The function below is inserted in the past version as well. It could be the cause but it's strange to say that it was in this last version only if the function below was always there.
encodeURIComponent

Its the first time im installing Rin Editor (great extension BTW) and i encountered that issue, and after changing the code, the issue is gone

maybe you should change it for future updates.
Thank you

[KFMDM Solutions]

i found another issue

remove_mention_in_quote is not implemented
https://github.com/paul999/mention/blob ... r.php#L368

[martec]

i found another issue

remove_mention_in_quote is not implemented
https://github.com/paul999/mention/blob ... r.php#L368

Strange regardless of my extension's existence, it shouldn't affect the inner workings of a function.

[rowiz]

Hello, I've found this updating simple mentions, which was not working.
Now with latest beta everything works, but I can't find the icons in the downloaded zip; I've restored from an old backup.
I've found references on readme but I cannot get the correct icons, can someone help me?

[KFMDM Solutions]

i found another issue

remove_mention_in_quote is not implemented
https://github.com/paul999/mention/blob ... r.php#L368

Strange regardless of my extension's existence, it shouldn't affect the inner workings of a function.

sorry you're right

the issue is only in quick reply
but if quick reply is enabled the quote goes direct to quick reply

so this function doesn't get executed