[ABD] Rin Editor for phpBB (WYSIWYG Editor) (Powerd by CKEditor)

[martec]

Strange regardless of my extension's existence, it shouldn't affect the inner workings of a function.

sorry you're right

the issue is only in quick reply
but if quick reply is enabled the quote goes direct to quick reply

so this function doesn't get executed

Hi this issue only happen when my extension enabled in quick reply? Without my extension in quick reply the issue doesnt happen?

[KFMDM Solutions]

wi

sorry you're right

the issue is only in quick reply
but if quick reply is enabled the quote goes direct to quick reply

so this function doesn't get executed

Hi this issue only happen when my extension enabled in quick reply? Without my extension in quick reply the issue doesnt happen?

without your extension you can't quote in quick reply
only manual

[KFMDM Solutions]

wi

Hi this issue only happen when my extension enabled in quick reply? Without my extension in quick reply the issue doesnt happen?

without your extension you can't quote in quick reply
only manual

fix would be

replace

Code: Select all

	public function rce_quick_reply($event)
	{
		if ($this->config['RCE_quickreply'] && $this->request->is_ajax() && $event['mode'] == 'quote')
		{
			$data = array('quick_reply_msg' => $event['post_data']['post_text']);
			$json = new \phpbb\json_response();
			$json->send($data);
		}
	}

with

Code: Select all

	public function rce_quick_reply($event)
	{
		if ($this->config['RCE_quickreply'] && $this->request->is_ajax() && $event['mode'] == 'quote')
		{
			$post_data = $event['post_data'];
			$post_data['post_text'] = preg_replace('#\[mention\](.*?)\[\/mention\]#uis', '@\\1', $post_data['post_text']);
			$post_data['post_text'] = preg_replace('#\[smention u=([0-9]+)\](.*?)\[\/smention\]#uis', '@\\2', $post_data['post_text']);
			$post_data['post_text'] = preg_replace('#\[smention g=([0-9]+)\](.*?)\[\/smention\]#uis', '@\\2', $post_data['post_text']);
			
			$data = array('quick_reply_msg' => $post_data['post_text']);
			$json = new \phpbb\json_response();
			$json->send($data);
		}
	}

[martec]

wi
without your extension you can't quote in quick reply
only manual

fix would be

replace

Code: Select all

	public function rce_quick_reply($event)
	{
		if ($this->config['RCE_quickreply'] && $this->request->is_ajax() && $event['mode'] == 'quote')
		{
			$data = array('quick_reply_msg' => $event['post_data']['post_text']);
			$json = new \phpbb\json_response();
			$json->send($data);
		}
	}

with

Code: Select all

	public function rce_quick_reply($event)
	{
		if ($this->config['RCE_quickreply'] && $this->request->is_ajax() && $event['mode'] == 'quote')
		{
			$post_data = $event['post_data'];
			$post_data['post_text'] = preg_replace('#\[mention\](.*?)\[\/mention\]#uis', '@\\1', $post_data['post_text']);
			$post_data['post_text'] = preg_replace('#\[smention u=([0-9]+)\](.*?)\[\/smention\]#uis', '@\\2', $post_data['post_text']);
			$post_data['post_text'] = preg_replace('#\[smention g=([0-9]+)\](.*?)\[\/smention\]#uis', '@\\2', $post_data['post_text']);
			
			$data = array('quick_reply_msg' => $post_data['post_text']);
			$json = new \phpbb\json_response();
			$json->send($data);
		}
	}

thanks. . i will incorporate in next version..

[KFMDM Solutions]

thanks. . i will incorporate in next version..

would this be fixed too?

replace
rin/editor/styles/all/template/js/automention.js

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:encodeURIComponent(a)},function(a){b(a)})}

with this

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:a},function(a){b(a)})}

and for overall it's a great extension

thanks

[martec]

thanks. . i will incorporate in next version..

would this be fixed too?

replace
rin/editor/styles/all/template/js/automention.js

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:encodeURIComponent(a)},function(a){b(a)})}

with this

Code: Select all

function remoteSearch(a,b){a.length<MIN_MENTION_LENGTH?b([]):$.getJSON(U_AJAX_MENTION_URL,{q:a},function(a){b(a)})}

and for overall it's a great extension

thanks

hi, yes..
Miri4ever bug report I will also check but I can't promise if it will be fixed.

[Octopus]

wi

Hi this issue only happen when my extension enabled in quick reply? Without my extension in quick reply the issue doesnt happen?

without your extension you can't quote in quick reply
only manual

I think this is a bug in the mentions 2.0 extension: https://www.phpbb.com/customise/db/exte ... s/faq/3696

[KFMDM Solutions]

wi
without your extension you can't quote in quick reply
only manual

I think this is a bug in the mentions 2.0 extension: https://www.phpbb.com/customise/db/exte ... s/faq/3696

one has nothing to do with the other
I'm referring to quote in general not mention

[martec]

0.4.8-beta Released

Bug Fix:

- Fixed issue related with Simples mentions 2.0 reported by Thank you and KFMDM Solutions (thanks for report)

[Thank you]

Hello, I noticed that the quick quote feature only works when Rin editor is enabled in quick reply,

It's possible to use quick quote without having Rin editor in quick reply?

Thank you

[martec]

Quick quote of this extension is feature of Rin Editor. So only will work with Rin Editor enabled.

[Thank you]

Quick quote of this extension is feature of Rin Editor. So only will work with Rin Editor enabled.

But the point of enabling quick reply is to not have a editor...

[martec]

Quick quote of this extension is feature of Rin Editor. So only will work with Rin Editor enabled.

But the point of enabling quick reply is to not have a editor...

you need to enable rin editor in quick reply

[masterbiz]

Hello Excellent ext I've been testing it for a couple of days and it seems to work very well. When do you expect to validate it?

[lúthien]

dear all,

I've been using Rin editor on our forum for several years and I love it. Many thanks for supplying it!

However, yesterday I noticed something very odd: when entering any text in the Rin Editor (creating a new topic or writing a reply), the [Source] button is pressed down by default. If I then tap it to activate the WYSIWYG mode, and then tap it again to enter the source mode again, the text area is filled with spammy gibberish. See these examples:

IMG_8732.jpg

IMG_8733.jpg

IMG_8734.jpg

This ONLY happens:

• when using the Brave browser on iOS (both most recent versions as of yesterday) (Chrome and Safari @ iOS don't show this)
• with the "Brave shields" switched [ON]
• when toggling the [source] switch off and on again

What I tried so far:

• update Rin Editor plus five other phpbb add-ons
• update PHPBB to the most recent version (3.3.10)
• for now, disabled the Rin editor until I found a solution

It's especially puzzling because I don't even know where to start looking.
It could be a Brave browser issue, the Rin editor, or maybe the PHPBB software. Or it might even be an iOS problem.I just noticed iOS has a minor update, I'll install that asap.
It might also be some kind of selective malware that made its way to my hosting space.
I'm absolutely clueless right now.

Does anyone have a clue where I could start looking? Or maybe I should rather ask this on the Brave support forum?
Thanks,

Lúthien