phpBB 3.2 style changes

[P_I]

3.2.1 to 3.2.2:
https://gist.github.com/marc1706/dbca9c ... 17e98916b9

If there are style changes in a dot release, I'm a bit curious why styles/prosilver/theme/stylesheet.css isn't being updated with each dot release to reflect the new phpBB version?

Code: Select all

/*  phpBB3 Style Sheet
    --------------------------------------------------------------
	Style name:			prosilver (the default phpBB 3.2.x style)
	Based on style:
	Original author:	Tom Beddard ( http://www.subblue.com/ )
	Modified by:		phpBB Limited ( https://www.phpbb.com/ )
    --------------------------------------------------------------
*/

@import url("normalize.css?v=3.2");
@import url("base.css?v=3.2");
@import url("utilities.css?v=3.2");
@import url("common.css?v=3.2");
@import url("links.css?v=3.2");
@import url("content.css?v=3.2");
@import url("buttons.css?v=3.2");
@import url("cp.css?v=3.2");
@import url("forms.css?v=3.2");
@import url("icons.css?v=3.2");
@import url("colours.css?v=3.2");
@import url("responsive.css?v=3.2");

Shouldn't the v=3.2 become v=3.2.2 with the phpBB 3.2.2 release just announced?

[Lumpy Burgertushie]

notice it says 3.2.x
that means that it will stay the same with all 3.2 versions. If that changes then it would be updated to reflect those changes.


robert

[Hanakin]

well, your both kind of correct. the v=3.2 was added to force browsers to recache as nothing was being changed in the stylesheet.css there were render issues. This is also due to an archaic practice of using loading multiple css files via imports. This is an extremely bad practice from the browser's perspective and one we will be eliminated going forward in 3.3 as we push to move towards using scss and a minified served css file. If anything it should have just been a style version tag added rather than versioning the imports but its already said and done for 3.2.

[Sajaki]

I presume you'll include scss source files with 3.3 then ?

[Hanakin]

yes, if not then at least in the dev repo. There will be minified and non-minified versions of the css files however.

[WWu777]

If I upgrade to phpbb 3.2.2 would any of my extensions be affected? Could any issues result?

[Crizzo]

If I upgrade to phpbb 3.2.2 would any of my extensions be affected? Could any issues result?

How could anyone know, nobody knows your extensions. Try it with a test board. And yes, issues can result. But this is not a support topic.

[Marc]

Updated the first post to add changes between 3.2.2 & 3.2.3-RC1.

[Marc]

Update first post with changes for 3.2.3-RC2.

[WWu777]

What does RC1 mean?

[RMcGirr83]

Release Candidate 1 viewtopic.php?p=15064096#p15064096

[Raul [ThE KuKa]]

Update first post with changes for 3.2.3-RC2.

Marc hardcoded for "Terms" and "Privacy" text...

Thanks for all!

[3Di]

Marc hardcoded for "Terms" and "Privacy" text...

https://github.com/phpbb/phpbb/pull/5314

[Marc]

List of diffs updated after latest changes.

[Marc]

Added 3.2.3 to 3.2.4-RC1