[3.1][3.2][3.3][RC] Twig Converter

[mrgoldy]

Out of curiosity;
Is it possible to run a vanilla prosilver through this converter and receive a working style? Or are there any files that will need adjusting afterwards? Have you (or anyone else for that matter) tried that already?

[kasimi]

David had this idea and the feature was added to version 1.1.0. phpBB converts all template files to Twig before caching them anyway, so converting prosilver shouldn't be necessary. That feature is mainly geared towards style authors.

[mrgoldy]

Currently on my phone and I hate the search on it, my bad

And I am writing a style based on prosilver for personal use and due to extension writing I am now more used to the twig syntax than phpbb's.

Anyway, thanks for the quick response.

[Galixte de EzCom]

Hi kasimi,

…

Colons are missing by twig style convertor extension

Source: https://github.com/oxpus/Download-32-Ex ... -498327691.

Is it possible to add this feature?

Regards.

[3Di]

Colons aren't missing if not hard-coded.

Example of old syntax: {L_CONTACT}{L_COLON}

Not {L_CONTACT}:

[Tastenplayer]

According to Requirements: it should work in 3.3.x. ? In 3.3.0-b2 I get an error message. Does this Ext normally work in 3.3.0-b2?

[david63]

I get an error message

Which says?????

[andares]

In 3.3.0-b2 I get an error message:

Code: Select all

Fatal error: Uncaught TypeError: Argument 1 passed to lexer_0f47be9::tokenize() must be an instance of Twig\Source, string given, called in /srv/disk1/2868406/www/xxx.atspace.cc/ext/kasimi/twigconverter/controller/main.php on line 267 and defined in /srv/disk1/2868406/www/xxx.atspace.cc/cache/production/container_dbdbe80dc7030ae9bd39ee30cca82130.php:4857 Stack trace: #0 /srv/disk1/2868406/www/xxx.atspace.cc/ext/kasimi/twigconverter/controller/main.php(267): lexer_0f47be9->tokenize('<!-- INCLUDECSS...', 'ext/kirk/stylec...') #1 /srv/disk1/2868406/www/xxx.atspace.cc/ext/kasimi/twigconverter/controller/main.php(245): kasimi\twigconverter\controller\main->convert_files(Array) #2 /srv/disk1/2868406/www/xxx.atspace.cc/ext/kasimi/twigconverter/controller/main.php(116): kasimi\twigconverter\controller\main->run('kirk/stylechang...', Array) #3 /srv/disk1/2868406/www/xxx.atspace.cc/ext/kasimi/twigconverter/acp/main_module.php(28): kasimi\twigconverter\controlle in /srv/disk1/2868406/www/xxx.atspace.cc/cache/production/container_dbdbe80dc7030ae9bd39ee30cca82130.php on line 4857

[Tastenplayer]

I didn't want to insert the error code unnecessarily if it's already clear that the Ext in 3.3.0-b2 doesn't work. Sorry
I don't have exactly the same error message, because a local Quickinstall TB in Xampp.
I have also installed the stylechanger from Kirk but there are no bugs or a mention of in this Ext from Kasimi therefore, as in the code by Andares. I wanted to convert my style not an extension. Maybe that's why.

Code: Select all

Fatal error: Uncaught TypeError: Argument 1 passed to lexer_0f47be9::tokenize() must be an instance of Twig\Source, string given, called in C:\xampp\htdocs\quickinstall-1.3.6\boards\3.3.0b2_style_tb\ext\kasimi\twigconverter\controller\main.php on line 257 and defined in C:\xampp\htdocs\quickinstall-1.3.6\boards\3.3.0b2_style_tb\cache\production\container_dbdbe80dc7030ae9bd39ee30cca82130.php:4430 Stack trace: #0 C:\xampp\htdocs\quickinstall-1.3.6\boards\3.3.0b2_style_tb\ext\kasimi\twigconverter\controller\main.php(257): lexer_0f47be9->tokenize('\n<!-- BEGIN for...', 'styles/Graphit/...') #1 C:\xampp\htdocs\quickinstall-1.3.6\boards\3.3.0b2_style_tb\ext\kasimi\twigconverter\controller\main.php(235): kasimi\twigconverter\controller\main->convert_files(Array) #2 C:\xampp\htdocs\quickinstall-1.3.6\boards\3.3.0b2_style_tb\ext\kasimi\twigconverter\controller\main.php(120): kasimi\twigconverter\controller\main->run('Graphit', Array) #3 C:\xampp\htdocs\quickinstall-1.3.6\boards\3.3.0b2_style_tb\ext\kasimi\twigconverter\acp\main_mo in C:\xampp\htdocs\quickinstall-1.3.6\boards\3.3.0b2_style_tb\cache\production\container_dbdbe80dc7030ae9bd39ee30cca82130.php on line 4430

It can't be an error from my style either - trying Prosilver brought the same error code.

[kasimi]

phpBB 3.3 uses a more recent version of Twig that doesn't allow accessing the parsed code anymore. I'll look into it when time allows.

[rxu]

The following worked for me:
replacing 2 rows here https://github.com/kasimi/phpbb-ext-twi ... #L267-L268 with

Code: Select all

$source = $this->lexer->tokenize(new \Twig_Source($contents, $filename))->getSourceContext();
$converted_syntax[$filename] = $source->getCode();

[Mannix_]

The following worked for me:
replacing 2 rows here https://github.com/kasimi/phpbb-ext-twi ... #L267-L268 with

Code: Select all

$source = $this->lexer->tokenize(new \Twig_Source($contents, $filename))->getSourceContext();
$converted_syntax[$filename] = $source->getCode();

Worked for me to ty

[andares]

The following worked for me:
replacing 2 rows here https://github.com/kasimi/phpbb-ext-twi ... #L267-L268 with

Code: Select all

$source = $this->lexer->tokenize(new \Twig_Source($contents, $filename))->getSourceContext();
$converted_syntax[$filename] = $source->getCode();

It seems to work well, Спасибо

[Tastenplayer]

I tried to convert my style in my local TB:

Failed to create zip file.

Quickinstall TB in Xampp - Win10
Database server: MySQL(i) 10.1.34-MariaDB
PHP version: 7.1.19

[kasimi]

Version 1.3.0 is available in the first post.

• Compatibility with phpBB 3.3.x, thanks rxu for the fix
• Added ZIP error code to error message

@Tastenplayer, try again with this version, it will tell you an error code.