[3.2][3.3][BETA] Advanced Polls

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Nephilim
Registered User
Posts: 60
Joined: Tue Oct 26, 2010 8:46 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by Nephilim »

Ok, one last difference: my poll already ended and is closed.

And when I deactivate the option "Show poll voters" the problem is not appearing.
Last edited by Nephilim on Fri Sep 09, 2022 8:20 am, edited 1 time in total.
SeewolfPK
Registered User
Posts: 109
Joined: Sat Apr 09, 2011 10:18 am

Re: [3.2][3.3][BETA] Advanced Polls

Post by SeewolfPK »

Uups,
I started the Forum new and now Error shown
poll5.jpg
After deleting the poll thread all errors gone away :mrgreen:
You do not have the required permissions to view the files attached to this post.
Best wishes
Paul
Nephilim
Registered User
Posts: 60
Joined: Tue Oct 26, 2010 8:46 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by Nephilim »

SeewolfPK wrote: Fri Sep 09, 2022 8:19 am Uups,
I started the Forum new and now Error shown

poll5.jpg

After deleting the poll thread all errors gone away :mrgreen:
Ok, the problem must than be located in the option "Show poll voters".
Nephilim
Registered User
Posts: 60
Joined: Tue Oct 26, 2010 8:46 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by Nephilim »

Sorry, this posting can be deleted.
Nephilim wrote: Fri Sep 09, 2022 8:24 am
SeewolfPK wrote: Fri Sep 09, 2022 8:19 am Uups,
I started the Forum new and now Error shown

After deleting the poll thread all errors gone away :mrgreen:
Ok, the problem must than be located in the option "Show poll voters".
Last edited by Nephilim on Fri Sep 09, 2022 8:40 am, edited 1 time in total.
SeewolfPK
Registered User
Posts: 109
Joined: Sat Apr 09, 2011 10:18 am

Re: [3.2][3.3][BETA] Advanced Polls

Post by SeewolfPK »

The Error shown only when deleting the pollvoter.
Maybe the EXT cannot work with Guest
Best wishes
Paul
User avatar
jasolo
Registered User
Posts: 132
Joined: Sat Jan 20, 2018 9:17 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by jasolo »

Removing users who have voted is problematic, as the previous developer already commented:
viewtopic.php?p=14666226#p14666226
SeewolfPK
Registered User
Posts: 109
Joined: Sat Apr 09, 2011 10:18 am

Re: [3.2][3.3][BETA] Advanced Polls

Post by SeewolfPK »

So it is the better way to rename the user
for example deletedUser1
Best wishes
Paul
Nephilim
Registered User
Posts: 60
Joined: Tue Oct 26, 2010 8:46 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by Nephilim »

jasolo wrote: Fri Sep 09, 2022 8:50 am Removing users who have voted is problematic, as the previous developer already commented:
viewtopic.php?p=14666226#p14666226
The users should not be removed from the poll in my opinion, showing them as guests is ok. Only the coding should be changed for guest-pollers not trying to show different colours an so on. By changing this the errors would be solved, or isn't it possible to handle deleted poll-users this way?
User avatar
jasolo
Registered User
Posts: 132
Joined: Sat Jan 20, 2018 9:17 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by jasolo »

Fixed the compatibility of this extension with phpBB 3.3.9: https://github.com/jasoloz/advancedpoll ... .2.4.3.zip
Lord Phobos
Registered User
Posts: 934
Joined: Tue May 18, 2004 11:41 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by Lord Phobos »

Does it work or it still has issues?
User avatar
jasolo
Registered User
Posts: 132
Joined: Sat Jan 20, 2018 9:17 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by jasolo »

The fix is related with this Twig behavior, that affected two files of this extension. On my test server it works with version 3.3.9, but I haven't had time to do extensive testing.
Lord Phobos
Registered User
Posts: 934
Joined: Tue May 18, 2004 11:41 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by Lord Phobos »

Do someone knows which files have to be modified and how?

Thanks
User avatar
warmweer
Jr. Extension Validator
Posts: 11487
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: [3.2][3.3][BETA] Advanced Polls

Post by warmweer »

Lord Phobos wrote: Sun Jan 08, 2023 1:35 am Do someone knows which files have to be modified and how?

Thanks
Compare your version with the one 2 posts higher (viewtopic.php?p=15904391#p15904391)
Spelling is freeware, which means you can use it for free.
On the other hand, it is not open source, which means you cannot change it or publish it in a modified form.


Time flies like an arrow, but fruit flies like a banana.
User avatar
jasolo
Registered User
Posts: 132
Joined: Sat Jan 20, 2018 9:17 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by jasolo »

Lord Phobos wrote: Sun Jan 08, 2023 1:35 am Do someone knows which files have to be modified and how?
The modified file is: styles/prosilver/template/event/overall_header_head_append.html
Line 2 has changed from:

Code: Select all

	<!-- INCLUDECSS ../theme/advancedpolls.css -->
to:

Code: Select all

	<!-- INCLUDECSS @wolfsblvt_advancedpolls/advancedpolls.css -->
The other modified file is composer.json because it contains the version number.
ponchi101
Registered User
Posts: 43
Joined: Fri Dec 04, 2020 3:12 pm

Re: [3.2][3.3][BETA] Advanced Polls

Post by ponchi101 »

Hey Jasolo.
I had not updated the original extension, and did not notice that there was a new one. I had updated to 3.3.9.
So I tried to update. I disabled the extension, and this happened:

Code: Select all

Fatal error: Uncaught Twig\Error\LoaderError: Looks like you try to load a template outside configured directories (../theme/advancedpolls.css) in "@wolfsblvt_advancedpolls/event/overall_header_head_append.html" at line 2. in /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Loader/FilesystemLoader.php:291 Stack trace: #0 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Loader/FilesystemLoader.php(211): Twig\Loader\FilesystemLoader->validateName() #1 /home/u236777983/domains/talkabouttennis2.com/public_html/phpbb/template/twig/loader.php(135): Twig\Loader\FilesystemLoader->findTemplate() #2 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Loader/FilesystemLoader.php(150): phpbb\template\twig\loader->findTemplate() #3 /home/u236777983/domains/talkabouttennis2.com/public_html/phpbb/template/twig/environment.php(313): Twig\Loader\FilesystemLoader->getCacheKey() #4 /home/u236777983/domains/talkabouttennis2.com/public_html/cache/production/twig/af/afb614a4f562e42bc8750b0b578f468d4cb767a44de95256c945df03a5c2b70e.php(45): phpbb\template\twig\environment->findTemplate() #5 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Template.php(405): __TwigTemplate_c26e858057f2a2f7afb0154860f05b2c219de0631e3f7c11348c22f9142eac32->doDisplay() #6 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling() #7 /home/u236777983/domains/talkabouttennis2.com/public_html/cache/production/twig/11/11aacbf151aa040703cebfa81bc2803dfd7fc240794748784b8f33de355c5485.php(432): Twig\Template->display() #8 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Template.php(405): __TwigTemplate_5c1221bd7ec7d6c03428c2d7dd8647f48daa409b72b6cae019c5fada81afbcb1->doDisplay() #9 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling() #10 /home/u236777983/domains/talkabouttennis2.com/public_html/cache/production/twig/50/50633c7de03f3bb0feb74629518427e63d6a412c8e9d47f38ef8028906227c32.php(44): Twig\Template->display() #11 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Template.php(405): __TwigTemplate_71ffb51b2b8504ec703161081167f4a944e69b43454aab19f22a31e4e63714e5->doDisplay() #12 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling() #13 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Template.php(390): Twig\Template->display() #14 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/TemplateWrapper.php(45): Twig\Template->render() #15 /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Environment.php(318): Twig\TemplateWrapper->render() #16 /home/u236777983/domains/talkabouttennis2.com/public_html/phpbb/template/twig/environment.php(224): Twig\Environment->render() #17 /home/u236777983/domains/talkabouttennis2.com/public_html/phpbb/template/twig/environment.php(194): phpbb\template\twig\environment->display_with_assets() #18 /home/u236777983/domains/talkabouttennis2.com/public_html/phpbb/template/twig/twig.php(317): phpbb\template\twig\environment->display() #19 /home/u236777983/domains/talkabouttennis2.com/public_html/includes/functions.php(4292): phpbb\template\twig\twig->display() #20 /home/u236777983/domains/talkabouttennis2.com/public_html/viewtopic.php(2426): page_footer() #21 {main} thrown in /home/u236777983/domains/talkabouttennis2.com/public_html/vendor/twig/twig/src/Loader/FilesystemLoader.php on line 291
END ERROR
So, something is happening that does not allow for the extension to be disabled. I was then able to simply overwrite it, but had to do a full restore because I was unable to recover from that error.

Thanks for the extension. We use it a lot, and it is great.
:thumbsup:
Last edited by Mick on Thu Feb 16, 2023 9:40 am, edited 1 time in total.
Reason: Code tags added for clarity.

Return to “Extensions in Development”