[CDB] Prime Post Revisions

[primehalo]

Hello,
I've installed this ext and it works fine, but I've only one problem, once a day the extension fills the admis registry with this message:

Auto-pruned post revisions » Revisions deleted: 0

All forums set to 0 on auto prune revisions and every day PPR spawning the message above. Messages don't stop (around 300-400 pages!) until I clear the board cache.

Apache and phpbb debug don't report anything unusual.

Any idea?



Nota: phpbb 3.2.9, php 7.2.

Sorry for the delayed response. I looked over the code again and have no idea why that's happening. According to the documentation they have for extensions using cron it should only run and log once every 24 hours. Still, I just uploaded a fix that will not log the cron job results if no revisions were actually deleted.

[Janvitus]

Sorry for the delayed response. I looked over the code again and have no idea why that's happening. According to the documentation they have for extensions using cron it should only run and log once every 24 hours. Still, I just uploaded a fix that will not log the cron job results if no revisions were actually deleted.

Ok, I apply the fix and works, tnx.

Suggest: maybe show a warning as for shadow topics where indicating in which forum the revisions are deleted.

[primehalo]

Suggest: maybe show a warning as for shadow topics where indicating in which forum the revisions are deleted.

I'm not sure I quite understand this. Show a warning where? When clicking a shadow topic link it brings you to the actual topic, from there you click on a specific post's revision history, and from that revision history is where you delete revisions. At that point I don't know if you arrived at the revision history by clicking the real topic link or the shadow topic link. Not even sure how I could know that.

[Janvitus]

No, i mean "Admin log" in the ACP:

Schermata da 2020-04-07 12-04-31.png

"Revisions deleted: 1" where?

However, as seen from the image, still too many messages from PPR. I've set only 2 forums to test it, and the prune revisions every 1 day... Now i've set to 15 days, let's see what happens.

[Dark❶]

...
However, as seen from the image, still too many messages from PPR. I've set only 2 forums to test it, and the prune revisions every 1 day... Now i've set to 15 days, let's see what happens.

I have made a PR here : https://github.com/primehalo/primepostrevisions/pull/6
Since it's Migration file , you will have to Disable the extension then copy that file to it's respective location and then Enable the extension.

Do let me know the results...

Best regards

[primehalo]

Thanks for finding and fixing the issue!

[Dark❶]

Thanks for finding and fixing the issue!

Welcome

Can I give you a suggestion here ???

Best regards

[primehalo]

Of course!

[Dark❶]

Ok. Thanks

1. I think you forgot to update the version number on first post to1.0.0-beta8 it's still 1.0.0-beta3 .
2. About Cron , A special page will be required for the following settings :
   • ability to Enable & disable cron as per the user convenience.
   • ability to select the Frequency to Run the cron , like 1 day , 2 days , ...etc... , I highly suggest in day(s) & Should be input element with restriction to numbers only from 0 & above.

There is one more thing , a bug report , but I have to check it thoroughly if it's my side or this extension.
I'll report it in 2 days.

BTW I like your Extension VERY much.

Best regards

[primehalo]

I think I understand... you want a single page were you can adjust the cron settings for every forum? So just recreate the cron options that already exist but displayed on a single page so you don't have to go into each forum's setting specifically?

[Dark❶]

I think I understand... you want a single page were you can adjust the cron settings for every forum? So just recreate the cron options that already exist but displayed on a single page so you don't have to go into each forum's setting specifically?

No... No... No...

I mean a Master switch & setting specifically for Cron Task.
Not for each forum.

If you don't mind , can I link to some of my repo to point you parts of the code?
so that I can explain myself ???
And some images too...

Best regards

[primehalo]

Sure, go ahead.

[Dark❶]

Thanks

---

So at this line of your extension : 130 :

Code: Select all

return true;

& at this line of my extension : 64 :

Code: Select all

return ($this->config['dark1_rsi_auto_reduce_sync_enable'] && $this->config['dark1_rsi_enable']);

To enable / disable the cron task , in your case should be :

Code: Select all

return $this->config['primepostrev_cron_enable'];

If user set's config['primepostrev_cron_enable'] aka Enable Cron Task as false aka NO then cron task should not run.
Default should be true.
So when user has issues with cron or they don't want it to be run , you can ask them to disable it.

---

Now at this line of your extension : 141 :

Code: Select all

return $this->config['primepostrev_cron_last_run'] < time() - $this->cron_frequency;

& at this line of my extension : 74 :

Code: Select all

return (($this->config['dark1_rsi_auto_reduce_sync_last_gc'] < (time() - $this->config['dark1_rsi_auto_reduce_sync_gc'])) && ($this->config['dark1_rsi_time'] < (time() - $this->config['dark1_rsi_interval'])));

To control the frequency of the cron task , in your case should be :

Code: Select all

return $this->config['primepostrev_cron_last_run'] < (time() - $this->config['primepostrev_cron_frequency']);

assuming you will store the Day(s) in seconds.
If user set's config['primepostrev_cron_frequency'] aka Cron Task Frequency as 172800 (secs) aka 2 days then cron task should run every 2 days.
Default should be 86400.
So when user want's to run cron at lower frequency , you can ask them to increase the number of Days.

---

I hope you will understand the above.

Best regards

[Janvitus]

...
However, as seen from the image, still too many messages from PPR. I've set only 2 forums to test it, and the prune revisions every 1 day... Now i've set to 15 days, let's see what happens.

I have made a PR here : https://github.com/primehalo/primepostrevisions/pull/6
Since it's Migration file , you will have to Disable the extension then copy that file to it's respective location and then Enable the extension.

Do let me know the results...

Best regards

I've add this file, seems to work but i would test it for a couple of days

[Dark❶]

...
I've add this file, seems to work but i would test it for a couple of days

Yea!!! sure...

currently primehalo also made some changes , check them too...

also check :
1. https://github.com/primehalo/primepostrevisions/pull/7
2. https://github.com/primehalo/primepostrevisions/pull/8

Best regards