primehalo wrote: Tue Apr 14, 2020 1:59 am
One of your suggestions was to move all the HTML files from styles/prosilver to styles/all. When originally setting this up, I actually wasn't sure if I should place them in prosilver or all. I chose prosilver because they are made and pretty much dependent on a prosilver-based style.
But I'm not 100% sure how this whole system works with other styles. If the HTML files are in prosilver like they are now and someone installs a prosilver-based style, will it automatically look in this prosilver directory for the files or is the user required to copy the files to the new style?
There are two types of styles in phpBB :
1.
Parent Style : a independent style not depending on any external style assets.
2.
Child Style : a dependent style which does "template inheritance" from
Parent Style for any external style assets.
For More Info read this :
https://www.phpbb.com/styles/installing/ &&
https://www.phpbb.com/styles/create/
Now , not all
prosilver-based style use parent as
prosilver
,
some of them are independent too,
but they update their styles based on
prosilver for maximum compatibility with various Extensions.
so those styles will get error for your controller,
coz the phpBB could not find the controller template file in it's style dir
styles/{some_style}
or in Universal style dir
styles/all
.
So to answer your question , Yes! user is required to copy the files to the new style.
---
I have made new PR :
https://github.com/primehalo/primepostrevisions/pull/9
In this I have moved all the HTML files from
styles/prosilver
to
styles/all
.
Along with that , I have made it so to compare 2 BBcode Text of a Post, instead of 2 HTML entities.
Also added the ability to compare the Post Subject.
---
Best regards