[3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
jhnmdahl
Registered User
Posts: 26
Joined: Wed Jun 24, 2015 7:49 pm
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by jhnmdahl »

My test images resize according to whatever hardcoded maximum dimensions I input (using the second, longer edit to the main_listener.php file), but the image rotation is not corrected. In other words, it appears the edits to the php file are properly saved and the resizing function is being executed, but the image rotation function is not being performed.

A sample image with exif orientation data present but that is not rotated when uploaded is attached, and the board is (removed). User error, I'm sure, but I'm stumped. Any thoughts?

Link to page on my board with processed post is: (removed)

and my main_listener.php file is attached. Thanks again for all the work on this.
Attachments
main_listener.php
(4.07 KiB) Downloaded 7 times
IMG_3854.jpg
Last edited by jhnmdahl on Wed Jul 29, 2020 7:24 pm, edited 1 time in total.
Administrator of www.cobaltchat.com - a Cobalt Boats web forum
User avatar
3Di
Former Team Member
Posts: 15892
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by 3Di »

About links to images in a forum where we can't watch attachments: please remove those useless links.

You do not have the required permissions to view the files attached to this post.

The attached image has no EXIF data.
I need the original (put it somewhere and link it).
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
jhnmdahl
Registered User
Posts: 26
Joined: Wed Jun 24, 2015 7:49 pm
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by jhnmdahl »

Administrator of www.cobaltchat.com - a Cobalt Boats web forum
User avatar
3Di
Former Team Member
Posts: 15892
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by 3Di »

jhnmdahl wrote:
Wed Jul 29, 2020 1:21 pm
Try:

https://www.cobaltchat.com/IMG_3854.jpg

John
This is your original
2020-07-29 15_42_24-IMG_3854.jpg (immagine JPEG, 3024 × 4032 pixel) - Riscalata (22%).png
About links to images in a forum where we can't watch attachments:

please remove those useless links.

This is my test with

Code: Select all

			$max_width = 850;
			$max_height = 650;
2020-07-29 15_40_32-test exir at 800x600 - 3.3.1-rc1.png
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
jhnmdahl
Registered User
Posts: 26
Joined: Wed Jun 24, 2015 7:49 pm
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by jhnmdahl »

So it works with the same image on your board with what I believe is the same main_listener.php file. I'll keep digging and see if I can discover what's going on. It does get resized on my board, so I know it's getting processed, just not rotated. Thanks for the confirmation,

John
Administrator of www.cobaltchat.com - a Cobalt Boats web forum
User avatar
3Di
Former Team Member
Posts: 15892
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by 3Di »

If you have any hard-coded stuff in the core code that's related to this... just remove it.

More than that I do not know. Luck.

Oh, and your useless links still are there, should I report your post? :geek:
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
jhnmdahl
Registered User
Posts: 26
Joined: Wed Jun 24, 2015 7:49 pm
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by jhnmdahl »

I guess you could report it, but I'm not sure I see the point. I removed links in my previous post in any event.

In the main PHPBB ACP page ("General" tab), there is a menu item under "Board Configuration" that is named "Post Settings." If you select that, under "Posting," there are "Maximum Image Width per Post" and Maximum Image Height per Post" settings that I confused with the attachment settings under the "Posting" tab at the top, which are "Maximum Image Dimensions" and are NOT the same variables.

I discovered this was the problem after removing the extension and finding my images were still being resized. So, user error as I suspected. Hope this helps someone else who might confuse the two settings - it's the "Maximum Image Dimensions" that have to be set to zero.

Thanks again for all your work,

John
Administrator of www.cobaltchat.com - a Cobalt Boats web forum
User avatar
3Di
Former Team Member
Posts: 15892
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by 3Di »

jhnmdahl wrote:
Wed Jul 29, 2020 7:29 pm
In the main PHPBB ACP page ("General" tab), there is a menu item under "Board Configuration" that is named "Post Settings." If you select that, under "Posting," there are "Maximum Image Width per Post" and Maximum Image Height per Post" settings that I confused with the attachment settings under the "Posting" tab at the top, which are "Maximum Image Dimensions" and are NOT the same variables.
Thanks for feedback, will be investigated.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
Hervé
Registered User
Posts: 116
Joined: Tue Jun 04, 2019 7:51 am

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by Hervé »

For information : on my forum, image size ist 0 x 0 on the 2 locations
  1. General Tab >> attatchments size
    OR Messages tab >> attatchments size
    both gives on the same window
  2. Messages tab >> Messages parameters
User avatar
3Di
Former Team Member
Posts: 15892
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by 3Di »

jhnmdahl wrote:
Wed Jul 29, 2020 7:29 pm
In the main PHPBB ACP page ("General" tab), there is a menu item under "Board Configuration" that is named "Post Settings." If you select that, under "Posting," there are "Maximum Image Width per Post" and Maximum Image Height per Post" settings that I confused with the attachment settings under the "Posting" tab
I don't know aka I am not sure how this could affect the attachments
since those configuration variables are just in use for the IMG and FLASH BBcodes AFAIK.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
User avatar
3Di
Former Team Member
Posts: 15892
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by 3Di »

jhnmdahl wrote:
Wed Jul 29, 2020 7:29 pm
In the main PHPBB ACP page ("General" tab), there is a menu item under "Board Configuration" that is named "Post Settings." If you select that, under "Posting," there are "Maximum Image Width per Post" and Maximum Image Height per Post" settings that I confused with the attachment settings under the "Posting" tab
I don't know aka I am not sure how this could affect the attachments
since those configuration variables are just in use for the IMG and FLASH BBcodes AFAIK.
Moreover but not related to this extension, this has ben removed now due to security stuffs (there is not anymore a check for the IMG bbcode, just FLASH still) for the new 3.2.10 and 3.3.1 phpBB versions.

https://github.com/phpbb/phpbb/commit/d ... 769c54ee01
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
User avatar
3Di
Former Team Member
Posts: 15892
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by 3Di »

The next version of this extension will only work from phpBB 3.3.1, I recommend you to upgrade.
I will certainly not offer support of any kind for lower versions, including phpBB 3.2.x.

Clear pacts long friendship. :P

Any support question should have a link to your board so that I can check its version, no alternatives. :ugeek:
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
Hervé
Registered User
Posts: 116
Joined: Tue Jun 04, 2019 7:51 am

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by Hervé »

Hi,
Has this new version resize capabilities as your patch for phpBB 3.2 does ?
User avatar
3Di
Former Team Member
Posts: 15892
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by 3Di »

Do you think it could?
I'm in a position to answer a question with another question. :|
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
Looking for a specific feature or alternative option? We will rock you! 🚀
Hervé
Registered User
Posts: 116
Joined: Tue Jun 04, 2019 7:51 am

Re: [3.2][3.3][ALPHA] EXIR - Exif Image Rotation 📸

Post by Hervé »

It should.
Post Reply

Return to “Extensions in Development”