After the release of phpBB 3.2.4 we've noticed an issue that can affect users with extensions that employ the generate_text_for_display() function.
A fix for this can be found on Github and will be included in the 3.2.5 release: https://github.com/phpbb/phpbb/pull/5448/files
After the release of phpBB 3.2.4 we've noticed an issue that can affect users with extensions that employ the generate_text_for_display() function.
A fix for this can be found on Github and will be included in the 3.2.5 release: https://github.com/phpbb/phpbb/pull/5448
Thanks for the quick update and fix.
Has anyone started to compile a list of extensions that employ this call or is it up the end users to scan their ext directory for calls to the function before deciding to update their boards to 3.2.4.
Added: So far I've found that the Board Rules extension makes this call.
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams
My Privacy Policy and User Details extensions use this function.
David Remember: You only know what you know and - you don't know what you don't know! My CDB Contributions | How to install an extension I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic. No support requests via PM or email as they will be ignored
It only affects extensions that render rich text in the old style format used in phpBB 3.1.x and earlier. In phpBB 3.2.x the content is saved in the database as XML. When calling generate_text_for_display() with XML content, the bugged code is not called. So this only affects extensions written before 3.2.x that haven't migrated to the new XML format yet. For example, mChat 2.1.x uses the new XML format exclusively and therefore is not affected, while mChat 2.0.x is.
It only affects extensions that render rich text in the old style format used in phpBB 3.1.x and earlier. In phpBB 3.2.x the content is saved in the database as XML. When calling generate_text_for_display() with XML content, the bugged code is not called. So this only affects extensions written before 3.2.x that haven't migrated to the new XML format yet. For example, mChat 2.1.x uses the new XML format exclusively and therefore is not affected, while mChat 2.0.x is.
Thanks for this additional information.
On the boards I'm involved with I've scanned for calls to generate_text_for_display() and so far only the Board Rules extension makes this call. Rather than dig further into the code and database, I've asked the extension developers if the extension is affected or not. Since there is a 3.2.x and 3.1.x version of the extension I'm guessing not but I'd rather have the developers confirm to be sure.
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams
Can you update the 3.2.4 code package right now so people from now on doing the upgrade aren't affected? I haven't upgraded to 3.2.4 yet, I usually wait a few days after release in case there are known "bugs".
Can you update the 3.2.4 code package right now so people from now on doing the upgrade aren't affected? I haven't upgraded to 3.2.4 yet, I usually wait a few days after release in case there are known "bugs".
Same here haha. I get a bit nervous now with the updates. Even though we don't run many extensions we've had a couple of issues in the past like that one update that made it unable to upload attachments. Everyone on our forum had a fit
Proudly powered by phpBB for almost 4 years now: forex-station.com
Global Alexa rank: 40,500
Can you update the 3.2.4 code package right now so people from now on doing the upgrade aren't affected? I haven't upgraded to 3.2.4 yet, I usually wait a few days after release in case there are known "bugs".
This would lead to two different versions with the same name/number and would lead to a mess.