[3.2][3.3][RC] Random Password Generator

[HiFiKabin]

<snip>
Okay, I'm code stupid, but I can understand that the characters used have to be between brackets [ ] How would I add those to the symbols that the script can pick from? Would there be any kind of mess up, or does it even matter so long as the symbols fall between brackets?

Yes we cross posted, I'll have a look at the styling error later.

If you want to add a new 'special character' just paste it at the end of the other special characters before the closing ] so for example you want to add a > to the string, the code would look like this

Code: Select all

	_pattern: /[a-zA-Z0-9!£$%^&*?>]/,

(I have not tested to see if > will work by the way, I just used it as an example)

Whatever you do, DO NOT break up the a-zA-Z0-9 part of the code

[2600]

Okay. But my question was more on whether you could actually use a ] as an added symbol in the formation of a random password without it messing around with the open and close brackets that the letters and symbols are used in.

So would this work? [a-zA-Z0-9!£$%^[]&*?>]

[mrgoldy]

You’ll have to escape the closing bracket.
[a-zA-Z0-9!£$%^[\]&*?>]

[2600]

Bear with me, I'm code stupid and don't understand what it means by escaping. It looks like you have to format it like what you indicated in this way? [\] so the \ escapes it? What does escape really mean?

Actually, is that a fancy way of saying separation?

Now why wouldn't the \ become used?

[HiFiKabin]

To expand on what MrGoldy said. As the he code is starting with a [ it must also end with a ] so will 'see' the first one in comes across

ie

[a-zA-Z0-9!£$%^[]&*?>]

will be seen as

[a-zA-Z0-9!£$%^[]

adding the \ before the additional ] tells the JS coding that it is not a closing tag but a symbol to be used. Accordingly you can not use \ as a character in this password generator unless you also escape it. So to have a \ you need to have \\

In fact several of the characters already in the generator should have been escaped, and I forgot New version avaliable within the next 15 min or so.

For reference 9and in case you want to add any characters yourself) the following

Code: Select all

\ ^ $ * + ? . ( ) | { } [ ]")

should appear in the js file as

Code: Select all

\\ \^ \$ \* \+ \? \. \( \) \| \{ \} \[ \]

[HiFiKabin]

3.2.0-RC3 now available.

Bug Fix

Update from previous version:

• Download the latest release and unzip it.
• Disable Password Generator in the ACP
• Delete password folder from the server
• Upload the folder hifikabin to root/ext/
• Enable it in the ACP

[Meis2M]

very nice extension this is has potential to add in phpBB core.

[mrgoldy]

@Hifi
Nothing needs escaping inside a character set [], except the actual ] sign. All characters inside a character set are taken as literals. Apart from the closing bracket and the dash between a-z, A-Z and 0-9.

I personally always use https://regexr.com/

[jemiNii]

I noticed that if you have special characters as a requirement in PHPBB then not all of the codes generated are valid - it only adds a special character sometimes. Maybe add option to always include one for those of us with that requirement.

Thanks for the extensions - great idea!


- jemiNii

[HiFiKabin]

@Hifi
Nothing needs escaping inside a character set [], except the actual ] sign. All characters inside a character set are taken as literals. Apart from the closing bracket and the dash between a-z, A-Z and 0-9.

I personally always use https://regexr.com/

Thanks. I always get totally confused with JS

[HiFiKabin]

I noticed that if you have special characters as a requirement in PHPBB then not all of the codes generated are valid - it only adds a special character sometimes. Maybe add option to always include one for those of us with that requirement.

Thanks for the extensions - great idea!


- jemiNii

I am not sure how easy (or not) that would be to implement. I will investigate further

[mrgoldy]

You can check if any of the characters is in the generated password, if not, generate a new one.

Code: Select all

do 
{ 
    $password = generate_pass();
} 
while (strpbrk($password, ‘^*+=%’) === false);

Or something of the sorts. Or see how the core checks if a password meets the rquirements.
Perhaps make a build in escape that it can only run a maximum of 5-10 times or something like that.

Good luck

[HiFiKabin]

Thanks for that. I'll look into that but I think I have found a better code to start from (yes, I tend to 'borrow' other peoples good ideas)

[HiFiKabin]

3.2.0-RC4 now available.

The generated password is now created from at least one each of the following:-

• Upper Case Letters.
• Lower Case Letters.
• Numbers 0-9
• 18 "special characters"

Update from previous version:

• Download the latest release and unzip it.
• Disable Password Generator in the ACP
• Delete password folder from the server
• Upload the folder hifikabin to root/ext/
• Enable it in the ACP

[3Di]

Hi James.
It makes me think, not having read the code, if and how the generated passwords obey the roles assigned in ACP?

I guess there's no problem if these are "No requirements".
See: ACP / User registration settings / Password complexity and Password length