[ABD] Extension .yml check

[david63]

phpbb3-extension-extservicescheck

Description:
Checks the syntax of the services.yml file in extensions prior to phpBB 3.3.



Note:
This extension will only check that the syntax of the services.yml file is compatible with phpBB 3.3 - it does no other checks and does not make any guarantees that any extension will be compatible with phpBB 3.3 in any other respect.

Features:

• Lists the status of all extensions.
• Shows a comparison of the "original" file and the "re-formatted" file.
• Highlights the difference between the two files
• Option to disable an extension that has errors and/or queries

Languages:
en

Status:
2.1.0-RC8

Installation:

• Download the latest release and unzip it.
• Upload the unzipped files to [board root]/ext/david63/extservicescheck and enable it in the ACP

GitHub Repository:

Extension Download:

Useage:
ACP > Customise > Extension management > Extension services check

[david63]

The reason for this extension is that in phpBB 3.3 there is a change in Symfony that requires the services.yml file to have a particular syntax. There are some, probably quite old, extensions that may not conform to this syntax and the extension will not work - and may possibly break your board.

By running this extension you will be able to check your extensions and take appropriate action prior to upgrading to phpBB 3.3 (when it is released)

[HiFiKabin]

Very clever, and most helpful. Many thanks David

[pierredu]

Do you check the 'pattern' keyword?

[david63]

Do you check the 'pattern' keyword?

Not sure what you mean by "keyword" but I am checking that the @ and % arguments are not without a leading character.

I am not claiming this to be infallible but more as a guide

[</Solidjeuh>]

Do you check the 'pattern' keyword?

Not sure what you mean by "keyword" but I am checking that if an argument starts with either @ or % then it also has a quote

I guess this:
https://area51.phpbb.com/phpBB/viewtopi ... 30#p332791

[P_I]

Thanks David. This will be very helpful going forward.

[nou nou]

Very helpful indeed! Thank you very much!

[pierredu]

Do you check the 'pattern' keyword?

Not sure what you mean by "keyword" but I am checking that if an argument starts with either @ or % then it also has a quote

I guess this:
https://area51.phpbb.com/phpBB/viewtopi ... 30#p332791

Exactly.

[david63]

Updated to RC2

Added check for routing.yml

[dmzx]

Updated to RC2

Added check for routing.yml

Maybe change the text in ACP that routing.yml is also checked.


-------------
Extension Services File Syntax Check
This extension will check the syntax of the services.yml file in all of the enabled extensions on this board for compatibility with phpBB 3.3.

It does NOT guarantee that the extension is compatible in any other way with phpBB 3.3 nor does it guarantee that there are no other issues with the services.yml file.

------------

[kasimi]

You may also want to check services & parameters of setter injections: https://github.com/phpbb/phpbb/blob/rel ... es.yml#L41

[david63]

You may also want to check services & parameters of setter injections: https://github.com/phpbb/phpbb/blob/rel ... es.yml#L41

To save me spending the next three days digging around documentation what are the correct and incorrect setting?

And while I am about it are there any others that come to mind?

[kasimi]

The same rules apply, incorrect: - [set_cache, [@cache.driver]], correct: - [set_cache, ['@cache.driver']].

And maybe you should check all .yml files in the config folder & its subfolders.

[david63]

The same rules apply, incorrect: - [set_cache, [@cache.driver]], correct: - [set_cache, ['@cache.driver']].

Thanks - I will check for that

And maybe you should check all .yml files in the config folder

I was hoping nobody would suggest that

& its subfolders.

Do any extensions have subfolders? I cannot recall ever seeing any