[3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

Since your report, it has been resolved one important bug, and i've see one secondary (or even less) and not so important about mouseover behavior. It seem not so wasted! To switch my localhost from php 7 to 8 and viceversa require 15 seconds. Thank you for the report!
Do not take me too serious
Anyway i do not like Discourse
scheccia
Registered User
Posts: 94
Joined: Fri Feb 10, 2017 8:16 am

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by scheccia »

Moderators haven't permission to edit users's post, how can enable them?
User avatar
HaioPaio
Registered User
Posts: 265
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by HaioPaio »

By setting the permission to do so. The standard moderator roles have that permission set to yes by default.
www.der-räuchertreff.de phpBB 3.3.x php 7.4
scheccia
Registered User
Posts: 94
Joined: Fri Feb 10, 2017 8:16 am

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by scheccia »

HaioPaio wrote: Thu Jun 17, 2021 1:39 pm By setting the permission to do so. The standard moderator roles have that permission set to yes by default.
i don't found any option in permission.
When any my moderators try to rotate image of user a popup tell "NO PERMISSION"
User avatar
HaioPaio
Registered User
Posts: 265
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by HaioPaio »

Please check at ACP/Permissions/Permission Masks/View global moderation permissions/look up user
enter user name, View Permissions
Check if under the tab "Post actions" for " can edit posts" is set to yes.
If not, click on the circle arrow symbol to track down the settings.
www.der-räuchertreff.de phpBB 3.3.x php 7.4
scheccia
Registered User
Posts: 94
Joined: Fri Feb 10, 2017 8:16 am

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by scheccia »

HaioPaio wrote: Thu Jun 17, 2021 5:06 pm Please check at ACP/Permissions/Permission Masks/View global moderation permissions/look up user
enter user name, View Permissions
Check if under the tab "Post actions" for " can edit posts" is set to yes.
If not, click on the circle arrow symbol to track down the settings.
yes, the are enable to edit posts.
I must comment this code at line 155

Code: Select all

// let admins and attachment owner to follow 
	$own_attachment = ($auth->acl_get('a_attach') || $attachment['poster_id'] == $user->data['user_id']) ? true : false;
	if (!$own_attachment) {
			echo 'W3ERROR_NO PERMISSION'; exit;
		}
mrix2000
Registered User
Posts: 1204
Joined: Sun Dec 03, 2006 2:23 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by mrix2000 »

Hello this EXT seems to work perfectly but as I have a custom side bar on my forum which is approx. 70px wide it squeezes up the information on the attachment edit page as below, its only a issue with my style as I have added what it looks like with the default theme also added...
My question is what would I need to edit to make the content display better :?
Thanks for any help
Attachments
EMIR.png
EMIR2.png
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

It is +- on top of the
/ext/w3all/imageattachrotation/styles/prosilver/template/event/overall_footer_body_after.html

Code: Select all

<div id="w3rPopup" class="w3rPopupContainer text-center inputbox" style="display:none">
<table class="w3wrapTABC">
<tr><td class="w3wrapTDC">
<div class="w3divContainer">
<div class="w3divCont"><strong>{{ lang('W3POPUP_TEXTEXPLAIN') }}</strong></div>
<div class="w3divimg"><img id="w3-img-rotate" src="" onclick="w3rotateByDeg(this);" /></div>
<div class="w3divCont"><button class="w3divCont button" type="submit" id="w3btn" onclick="w3sendThis(document.getElementById('w3-img-rotate'));">{{ lang('W3POPUP_BUTTONTEXT') }}</button></div>
</div>
</td></tr></table>
</div>
and the related css is:
/ext/w3all/imageattachrotation/styles/prosilver/template/css/style.css

as also explained here:
https://github.com/axew3/phpBB-image-at ... s-rotation

The extension will be soon improved. Cheers!
Do not take me too serious
Anyway i do not like Discourse
mrix2000
Registered User
Posts: 1204
Joined: Sun Dec 03, 2006 2:23 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by mrix2000 »

Thank you for the very swift response very much appreciated :D 8-)
mrix2000
Registered User
Posts: 1204
Joined: Sun Dec 03, 2006 2:23 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by mrix2000 »

Hello I am struggling to try and display the information in a smaller window, with my blue side bar menu its pretty messed up as you can see by the screen shot, is there any way I can tweak the code to allow it to fit better ? you so kindly posted the reply but I am still unsure how to proceed to get it displaying better :?
Huge thanks for any help
Attachments
Display Error.png
mrix2000
Registered User
Posts: 1204
Joined: Sun Dec 03, 2006 2:23 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by mrix2000 »

Also one other thing my moderator went to edit image whereby he edited it where the image popped up but then he was not allowed to save the image due to a permissions issue :?
I can edit it as admin
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

Hello! It is very hard (unfortunately) to give you an answer, without knowing what html wrap your elements into this theme, that's may the same as on default, while the CSS is obviously what you have to change to get t he result because it is surely changed. May an online example would help (so someone can see the outputted source code), or the fact that you let know what's the html output generated by your theme for the attachment panel.
I could suggest you to add white-space: nowrap; into the CSS like this

Code: Select all

.attach-row > td{ white-space: nowrap; }
may it work, but it is like to guess to win superenalotto. I am unlucky normally, but the answer himself may will help you.

While about the moderator that can't save.
I will give a look into code in short soon, because last night, i've take a fast re-look to the logic on it, and i detected almost 3 4 things that need to be surely adjusted.

I know it is may not the answer you want, but i hope you'll find out the way to fix it.
Do not take me too serious
Anyway i do not like Discourse
mrix2000
Registered User
Posts: 1204
Joined: Sun Dec 03, 2006 2:23 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by mrix2000 »

Huge thanks for your in-depth reply, I think overall the EXT is very useful 8-)
I will try your idea and see what happens.
Thanks again
mrix2000
Registered User
Posts: 1204
Joined: Sun Dec 03, 2006 2:23 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by mrix2000 »

axe70 wrote: Sun Jan 23, 2022 4:13 pm I will give a look into code in short soon, because last night, i've take a fast re-look to the logic on it, and i detected almost 3 4 things that need to be surely adjusted.
Just one last thing when this mod is enabled my moderators keep getting logged out and have to keep logging in.
I have had to now disable this EXT which has stopped this from happening.
Hopefully this can be resolved as its very useful.
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

Ok, going to take a look. Any moderator that attempt to save an image that belong to another user, goes logged out?
Or how it happen please can you say? (so i can go right to the point)
Do not take me too serious
Anyway i do not like Discourse
Post Reply

Return to “Extensions in Development”