[Info] Changes to twig behavior on loading files in 3.3.9

[Marc]

Starting with the twig version used in phpBB 3.3.9, some extensions might display error messages like the following:

Code: Select all

Fatal error: Uncaught Twig\Error\LoaderError: Looks like you try to load a template outside configured directories (../theme/some_file.css) in "@ExtAuthor_ExtName/some_other_file.html"

This is caused by the more restrictive handling of files that are allowed to be loaded by twig.

Lines that can cause this are for example:

Code: Select all

<!-- INCLUDECSS ../theme/foobar.css -->

Code: Select all

{% INCLUDECSS '../theme/foobar.css' %}

One can easily solve this problem by using the extension prefix instead of relative paths:

Code: Select all

<!-- INCLUDECSS @ExtAuthor_ExtName/foobar.css -->

Code: Select all

{% INCLUDECSS '@ExtAuthor_ExtName/foobar.css' %}

Other includes like INCLUDEJS or the twig include will be affected by this behavior as well. It's recommended to always use the prefix for your extension as outlined above.

[GTI]

One can easily solve this problem by using the extension prefix instead of relative paths:
<!-- INCLUDECSS @some_extension/foobar.css -->
{% INCLUDECSS '@some_extension/foobar.css' %}

For anyone that may want clarity on 'some_extension'... 'some' represents extension author and 'extension' represents extension name.
Of course, don't forget the underscore between them.

Examples:
<!-- INCLUDECSS @ExtAuthor_ExtName/foobar.css -->
{% INCLUDECSS '@ExtAuthor_ExtName/foobar.css' %}

[pierredu]

Does this also hold true for INCLUDEJS?

[Marc]

@GTI: Thanks for the hint, updated the first post accordingly.

@pierredu: Yes, those should also be affected. I've added this to the first post as well.

[CyrusG]

Thanks for the reply. Will there be a fix for this that you can download and replace this bug?

[Crizzo]

This needs to be fixed in the extension, so the extension authors need to update their code.

[CyrusG]

I understand. A shame as this worked great under the previous version of phpBB. Most likely this extension will not be updated as the owner seems to have a low profile on the forum and under Github.

[Crizzo]

And it is a really easy minor change, so you could do it yourself, too

[warmweer]

I understand. A shame as this worked great under the previous version of phpBB. Most likely this extension will not be updated as the owner seems to have a low profile on the forum and under Github.

The fix is quite simple.
A perfect opportunity to avoid having to wait.

Added: again no notification that a new post was submitted before I submitted mine.

[Raul [ThE KuKa]]

Thanks Marc, info added in phpBB Spain.

[LukeWCS]

Yesterday we published a variant of Marc's message on phpBB.de. As part of this, I examined in advance what exactly causes the problem when switching from phpBB 3.3.8 to phpBB 3.3.9. Below is the relevant section. The text was translated with Google, please forgive me.

Background

In principle, the error message in question has existed for a long time, precisely since phpBB 3.1.0 (Twig 1.13.2). However, the associated check has changed several times over the years and remained unchanged for a long time with phpBB 3.3 up to and including phpBB 3.3.8 (Twig 2.15.1). However, with phpBB 3.3.9 (Twig 2.15.3) there was a tiny change in the following file, which in combination with relative path specifications then leads to the error message mentioned:

vendor\twig\twig\src\Loader\FilesystemLoader.php (Lines 209-211)

Twig 2.15.1:

Code: Select all

            list($namespace, $shortname) = $this->parseName($name);

            $this->validateName($shortname);

Twig 2.15.3:

Code: Select all

            $this->validateName($name);

            list($namespace, $shortname) = $this->parseName($name);

So this is an unnoticed change in Twig, not an intentional change in phpBB 3.3.9.

[pierredu]

Thanks for the precision.

[Raul [ThE KuKa]]

About "include" JS info, other example.

Code: Select all

<!-- INCLUDEJS @ExtAuthor_ExtName/file.js -->

Code: Select all

{% INCLUDEJS '@ExtAuthor_ExtName/file.js' %}

[nice100]

Can anyone do that for me?
if a donation
I don't know anything about that?

[Paul]

You should contact the extension author for support.