Discuss: phpBB 3.3.12 Release

[HB]

Have a look here: https://www.phpbb.com/support/docs/en/3 ... meoutquot/

Thanks! The error was in include/diff/diff.php, which has been corrected in the 3.3.12 release; here's the change:

FIND:

Code: Select all

				// We can simplify one case where the array is usually supposed to be empty...
				if (count($orig) == 1 && trim($orig[0]) === '') $orig = array();
				if (count($final) == 1 && trim($final[0]) === '') $final = array();

REPLACE WITH:

Code: Select all

                // We can simplify one case where the array is usually supposed to be empty...
                if (is_array($orig) && count($orig) == 1 && trim($orig[0]) === '')
                {
                    $orig = array();
                }
                if (is_array($final) && count($final) == 1 && trim($final[0]) === '')
                {
                    $final = array();
                }

The "timeout detected" error message should link that KB article. I've open up a suggestion bug report here. Thanks again!

[softlight]

I'm still running 3.3.10.
Will it be OK to update with 3.3.12?
I've not had to skip an update before.

[Kailey]

I ran into 1 HUNK file (I use the patch files for various reasons). The file was /styles/prosilver/theme/stylesheet.css, which was caused by this. Otherwise, no issues to report.

I'm still running 3.3.10.
Will it be OK to update with 3.3.12?

You should be fine.

[softlight]

I'm still running 3.3.10.
Will it be OK to update with 3.3.12?

You should be fine.

Thank you, I have the new package now and will attempt to update it at the weekend. I'll throw away the 3.3.11 package I've held for a couple of weeks.

[ssl]

If you have any doubts about how to proceed with this update, open a topic on the support board instead of rushing in head first and making stupid mistakes.

[Tommy Herrmann]

Hello Team,

after completing the German translation yesterday, I successfully installed v3.3.12 without any issues.

Thank you for your professional work.

[Madalin10]

Upgraded from 3.3.11 to 3.3.12 for some clients, and from 3.2.9 to 3.3.12 and had no issues with the upgrade process. Props to dev team for this release!

[invenio]

Another easy clean upgrade. Thank you developers.

[SpIdErPiGgY]

I see this in Firefox inspector

Code: Select all

Uncaught SyntaxError: expected expression, got keyword 'const'

/template/ajax.js

Code: Select all

// Prevent accidental double submission of form
+$('[data-prevent-flood] input[type=submit]').click(function(event) {
+	const $submitButton = $(this); // Store the button element
+	const $form = $submitButton.closest('form');

[GanstaZ]

Got an error while updating from 3.3.10 to 3.3.12:
[phpBB Debug] PHP Warning: in file [ROOT]/phpbb/session.php on line 444: Undefined array key "user_last_active"

Other than that, all seems good)

[SpIdErPiGgY]

I see this in Firefox inspector

Code: Select all

Uncaught SyntaxError: expected expression, got keyword 'const'

/template/ajax.js

Code: Select all

// Prevent accidental double submission of form
+$('[data-prevent-flood] input[type=submit]').click(function(event) {
+	const $submitButton = $(this); // Store the button element
+	const $form = $submitButton.closest('form');

Nevermind. I forgot to update ajax.js