Issues with 3.3.12 update

Get help with installation and running phpBB 3.3.x here. Please do not post bug reports, feature requests, or extension related questions here.
bluefords
Registered User
Posts: 2
Joined: Fri Jun 02, 2023 5:37 pm

Issues with 3.3.12 update

Post by bluefords »

I updated from 3.3.11 and have encountered two issues:
  • The default action on the posting page has changed from 'Submit' to 'Preview'. By default action, I mean pressing CTRL+Enter with the text are focused. I did a diff of the Prosilver HTML files and don't see anything that would cause this.
  • The posts shown by by the "New Posts" page( search.php?search_id=newposts ) has changed. Before, it showed all topics, now it only shows a handful. My users noticed this immediately and complained, as I do not use the feature myself I am just relaying what they have stated. I do see some changes to the SQL query used in search.php for 3.3.12, but don't see anything listed in the release notes. Was this intentional?
Thank you for your time.
User avatar
P_I
Community Team Member
Community Team Member
Posts: 2406
Joined: Tue Mar 01, 2011 8:35 pm
Location: Western Canada 🇨🇦

Re: Issues with 3.3.12 update

Post by P_I »

bluefords wrote: Tue Jun 18, 2024 11:33 pm The posts shown by by the "New Posts" page( search.php?search_id=newposts ) has changed. Before, it showed all threads, now it only shows a handful. My users noticed this immediately and complained, as I do not use the feature myself I am just relaying what they have stated. I do see some changes to the SQL query used in search.php for 3.3.12, but don't see anything listed in the release notes.
I've had one user report something similar and I have the same challenge as I don't use the 'New posts' link. My standard bookmark is 'View unread'.
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams
User avatar
thecoalman
Community Team Member
Community Team Member
Posts: 6028
Joined: Wed Dec 22, 2004 3:52 am
Location: Pennsylvania, U.S.A.

Re: Issues with 3.3.12 update

Post by thecoalman »

The new posts issue is apparently a bug in 3.3.12

https://tracker.phpbb.com/browse/PHPBB-17312

Tell them to use the active topics list in the meantime, the only difference is it doesn't limit it to last activity.
“Results! Why, man, I have gotten a lot of results! I have found several thousand things that won’t work.”

Attributed - Thomas Edison
rxu
Extensions Development Team
Posts: 3804
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation

Re: Issues with 3.3.12 update

Post by rxu »

Not really as the fix https://github.com/phpbb/phpbb/pull/6618 has been merged into prep-release-3.3.12 and included into 3.3.12.
User avatar
bonelifer
Community Team Member
Community Team Member
Posts: 3618
Joined: Wed Oct 27, 2004 11:35 pm
Name: William

Re: Issues with 3.3.12 update

Post by bonelifer »

rxu wrote: Wed Jun 19, 2024 6:23 am Not really as the fix https://github.com/phpbb/phpbb/pull/6618 has been merged into prep-release-3.3.12 and included into 3.3.12.
The time active after using the link is vastly shorter than it used to be.
William Jacoby - Community Team
Knowledge Base | phpBB Board Rules | Search Customisation Database
Please don't contact me via PM or email for phpBB support .

phpBB Modders is looking for developers! If you have phpBB experience and want to join us, click here!
User avatar
KevC
Support Team Member
Support Team Member
Posts: 72475
Joined: Fri Jun 04, 2004 10:44 am
Location: Oxford, UK

Re: Issues with 3.3.12 update

Post by KevC »

I agree completely about the new posts time frame. It's definitely not fixed. I came on for the first time yesterday and there were no new posts, but looking down the index page there were plenty.
-:|:- Support Request Template -:|:-
Image
"Step up to red alert. Sir, are you absolutely sure? It does mean changing the bulb"
User avatar
Brf
Support Team Member
Support Team Member
Posts: 53486
Joined: Tue May 10, 2005 7:47 pm
Location: {postrow.POSTER_FROM}

Re: Issues with 3.3.12 update

Post by Brf »

bluefords wrote: Tue Jun 18, 2024 11:33 pm
  • The default action on the posting page has changed from 'Submit' to 'Preview'. By default action, I mean pressing CTRL+Enter
The ctrl-enter action is determined by your webbrowser, which is supposed to be the first Submit button.
In this case it would be the Save-Draft (if enabled) or Preview button. Alt-S still works as the Submit button.
User avatar
P_I
Community Team Member
Community Team Member
Posts: 2406
Joined: Tue Mar 01, 2011 8:35 pm
Location: Western Canada 🇨🇦

Re: Issues with 3.3.12 update

Post by P_I »

bonelifer wrote: Wed Jun 19, 2024 8:53 am
rxu wrote: Wed Jun 19, 2024 6:23 am Not really as the fix https://github.com/phpbb/phpbb/pull/6618 has been merged into prep-release-3.3.12 and included into 3.3.12.
The time active after using the link is vastly shorter than it used to be.
So it that a feature (intended change) or a new bug?
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams
User avatar
Mick
Support Team Member
Support Team Member
Posts: 26710
Joined: Fri Aug 29, 2008 9:49 am

Re: Issues with 3.3.12 update

Post by Mick »

I suppose many people, like me, wouldn’t notice the button selection issue if they use a mouse and or touch screen.
  • "The more connected we get the more alone we become" - Kyle Broflovski©
  • "The good news is hell is just the product of a morbid human imagination.
    The bad news is, whatever humans can imagine, they can usually create.
    " - Harmony Cobel©
🇬🇧
User avatar
KevC
Support Team Member
Support Team Member
Posts: 72475
Joined: Fri Jun 04, 2004 10:44 am
Location: Oxford, UK

Re: Issues with 3.3.12 update

Post by KevC »

I'll be honest, I've literally never heard of anyone using that button option instead of just clicking submit. I didn't even know it existed.
-:|:- Support Request Template -:|:-
Image
"Step up to red alert. Sir, are you absolutely sure? It does mean changing the bulb"
User avatar
thecoalman
Community Team Member
Community Team Member
Posts: 6028
Joined: Wed Dec 22, 2004 3:52 am
Location: Pennsylvania, U.S.A.

Re: Issues with 3.3.12 update

Post by thecoalman »

There is a actually a lot of actions with keyboard shortcut, search the source code for the "accesskey" attribute.

As far as any change either the template code changed or the browser behavior changed.
“Results! Why, man, I have gotten a lot of results! I have found several thousand things that won’t work.”

Attributed - Thomas Edison
rxu
Extensions Development Team
Posts: 3804
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation

Re: Issues with 3.3.12 update

Post by rxu »

P_I wrote: Fri Jun 21, 2024 12:38 pm it that a feature (intended change) or a new bug
Personally I'd say it's a fixed bug.
Currently user_lastvisit time is being syncronised with the most recent session_time which is the last (literally previous) visit time. This wasn't the case before as user_lastvisit was synced with the most recent expired session time (which is obviously earlier than the most recent one). Sorry for being too confusing probably but that's what happened in 3.3.12.
This is why the time gap for searching "New posts" has became [vastly] shorter.
User avatar
Gumboots
Registered User
Posts: 712
Joined: Fri Oct 11, 2019 1:59 am

Re: Issues with 3.3.12 update

Post by Gumboots »

thecoalman wrote: Fri Jun 21, 2024 2:15 pm There is a actually a lot of actions with keyboard shortcut, search the source code for the "accesskey" attribute.
And they don't ever seem to work, at least not with Firefox on Windows 10, so in practice I never bother trying to use them.

TBH I think that trying to play silly buggers with accesskey (and tabindex) is a waste of time, and is just likely to screw other things.
🇺🇦 Слава Україні! 🇺🇦 Героям слава! 🇺🇦
User avatar
P_I
Community Team Member
Community Team Member
Posts: 2406
Joined: Tue Mar 01, 2011 8:35 pm
Location: Western Canada 🇨🇦

Re: Issues with 3.3.12 update

Post by P_I »

rxu wrote: Fri Jun 21, 2024 2:16 pm Personally I'd say it's a fixed bug.
Currently user_lastvisit time is being syncronised with the most recent session_time which is the last (literally previous) visit time. This wasn't the case before as user_lastvisit was synced with the most recent expired session time (which is obviously earlier than the most recent one). Sorry for being too confusing probably but that's what happened in 3.3.12.
This is why the time gap for searching "New posts" has became [vastly] shorter.
Thanks for the technical explanation. How would you explain this change to members who have noticed the change?

From https://www.phpbb.com/support/docs/en/3 ... redefined/
VIEW NEW POSTS - Returns a list of topics containing posts which have been made since the last time you logged in.
The complicating factor is many users utilize the "Remember me" checkbox at login so have no reference point as to "the last time you logged in."
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams
rxu
Extensions Development Team
Posts: 3804
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation

Re: Issues with 3.3.12 update

Post by rxu »

Yes, this is rather not correct (and never was to be honest). I'd word it like
Returns a list of topics containing posts which have been made since the previous time you visited the board.

Return to “[3.3.x] Support Forum”