Issues with 3.3.12 update

[bluefords]

I updated from 3.3.11 and have encountered two issues:

• The default action on the posting page has changed from 'Submit' to 'Preview'. By default action, I mean pressing CTRL+Enter with the text are focused. I did a diff of the Prosilver HTML files and don't see anything that would cause this.
• The posts shown by by the "New Posts" page( search.php?search_id=newposts ) has changed. Before, it showed all topics, now it only shows a handful. My users noticed this immediately and complained, as I do not use the feature myself I am just relaying what they have stated. I do see some changes to the SQL query used in search.php for 3.3.12, but don't see anything listed in the release notes. Was this intentional?

Thank you for your time.

[P_I]

The posts shown by by the "New Posts" page( search.php?search_id=newposts ) has changed. Before, it showed all threads, now it only shows a handful. My users noticed this immediately and complained, as I do not use the feature myself I am just relaying what they have stated. I do see some changes to the SQL query used in search.php for 3.3.12, but don't see anything listed in the release notes.

I've had one user report something similar and I have the same challenge as I don't use the 'New posts' link. My standard bookmark is 'View unread'.

[thecoalman]

The new posts issue is apparently a bug in 3.3.12

https://tracker.phpbb.com/browse/PHPBB-17312

Tell them to use the active topics list in the meantime, the only difference is it doesn't limit it to last activity.

[rxu]

Not really as the fix https://github.com/phpbb/phpbb/pull/6618 has been merged into prep-release-3.3.12 and included into 3.3.12.

[bonelifer]

Not really as the fix https://github.com/phpbb/phpbb/pull/6618 has been merged into prep-release-3.3.12 and included into 3.3.12.

The time active after using the link is vastly shorter than it used to be.

[KevC]

I agree completely about the new posts time frame. It's definitely not fixed. I came on for the first time yesterday and there were no new posts, but looking down the index page there were plenty.

[Brf]

• The default action on the posting page has changed from 'Submit' to 'Preview'. By default action, I mean pressing CTRL+Enter

The ctrl-enter action is determined by your webbrowser, which is supposed to be the first Submit button.
In this case it would be the Save-Draft (if enabled) or Preview button. Alt-S still works as the Submit button.

[P_I]

Not really as the fix https://github.com/phpbb/phpbb/pull/6618 has been merged into prep-release-3.3.12 and included into 3.3.12.

The time active after using the link is vastly shorter than it used to be.

So it that a feature (intended change) or a new bug?

[Mick]

I suppose many people, like me, wouldn’t notice the button selection issue if they use a mouse and or touch screen.

[KevC]

I'll be honest, I've literally never heard of anyone using that button option instead of just clicking submit. I didn't even know it existed.

[thecoalman]

There is a actually a lot of actions with keyboard shortcut, search the source code for the "accesskey" attribute.

As far as any change either the template code changed or the browser behavior changed.

[rxu]

it that a feature (intended change) or a new bug

Personally I'd say it's a fixed bug.
Currently user_lastvisit time is being syncronised with the most recent session_time which is the last (literally previous) visit time. This wasn't the case before as user_lastvisit was synced with the most recent expired session time (which is obviously earlier than the most recent one). Sorry for being too confusing probably but that's what happened in 3.3.12.
This is why the time gap for searching "New posts" has became [vastly] shorter.

[Gumboots]

There is a actually a lot of actions with keyboard shortcut, search the source code for the "accesskey" attribute.

And they don't ever seem to work, at least not with Firefox on Windows 10, so in practice I never bother trying to use them.

TBH I think that trying to play silly buggers with accesskey (and tabindex) is a waste of time, and is just likely to screw other things.

[P_I]

Personally I'd say it's a fixed bug.
Currently user_lastvisit time is being syncronised with the most recent session_time which is the last (literally previous) visit time. This wasn't the case before as user_lastvisit was synced with the most recent expired session time (which is obviously earlier than the most recent one). Sorry for being too confusing probably but that's what happened in 3.3.12.
This is why the time gap for searching "New posts" has became [vastly] shorter.

Thanks for the technical explanation. How would you explain this change to members who have noticed the change?

From https://www.phpbb.com/support/docs/en/3 ... redefined/

VIEW NEW POSTS - Returns a list of topics containing posts which have been made since the last time you logged in.

The complicating factor is many users utilize the "Remember me" checkbox at login so have no reference point as to "the last time you logged in."

[rxu]

Yes, this is rather not correct (and never was to be honest). I'd word it like
Returns a list of topics containing posts which have been made since the previous time you visited the board.