Issues with 3.3.12 update

[Mick]

There is a actually a lot of actions with keyboard shortcut

Those, in most cases, have been there since the GUI was adopted, it’s just that a lot of people don’t use them as much anymore. Many modern devices such as mobile phones and tablets don’t have ctrl keys (or function keys) so I suppose folks have got out of the habit.

[rxu]

Keyboard shortcut issue might be a regression of this change https://github.com/phpbb/phpbb/pull/659 ... a8092d2e00 but should be checked first.

[cabot]

TBH I think that trying to play silly buggers with accesskey (and tabindex) is a waste of time, and is just likely to screw other things.

+1

Moreover, it is recommended that you avoid using accesskey wherever possible.
https://developer.mozilla.org/en-US/doc ... y_concerns
https://webaim.org/techniques/keyboard/accesskey#poor

[Gumboots]

Exactly, and tabindex as well.

[donaldN]

Posting here to mention the newposts issue on 3.3.12:

Selecting newposts no longer shows the newest posts since last login, it instead shows a growing list of posts, for several users this newposts selection is 6+ pages long (275 posts). I tried clearing the cache, marking the forums as read on my own account and the result has been the same.

[Suzan]

Currently user_lastvisit time is being syncronised with the most recent session_time which is the last (literally previous) visit time. This wasn't the case before as user_lastvisit was synced with the most recent expired session time (which is obviously earlier than the most recent one).

How would you explain the change to a person who always logs in and logs out and does not use "remember me"? What is a "session" because it seems to be something that keeps getting reset while they are active on the forum.

Previously, New Posts would mean when they log in in the morning, they would see all the posts (topics) which happened since their previous log out time. The total number of New Posts would continue to grow as they remain logged in because the elapsed time would be longer. The New Posts would basically reset when they log out.

Now if this person logs in and is on for several hours (automatic inactive logout is set to one hour so they are obviously active), the New Post count fluctuates up and down and up and down during the time they are logged in. (I was going to call it a logged in session, but it appears it is not a "session".) This user confusion was also described in Strange Results using New Posts Search Function in v3.3.12.

It's my understanding session_time is "UNIX timestamp of the last time the user clicked on a page" which would mean the start time for getting New Posts would continually change during their logged in period which is what seems to be happening.

Is that what the change meant to have happen?

[Marc]

I think we were finally able to track down this issue which caused the aforementioned issues with the new posts page:
https://tracker.phpbb.com/browse/PHPBB-17375

The linked pull request contains the currently proposed fix for this.

[Suzan]

The two lines of code were changed on our forum and the New Posts option now appears to be showing correct output. As a person remains logged in, the number of New Posts increases in size.

Thanks to those who contributed to the fix.

[Blacktiger63]

Still not fixed in 3.3.13 probably.

I visited a forum of a friend which I manage. Then didn't visit it for 4 days.

Today I visited and in "new posts" I only had 2 posts. These were from today.



In "unread posts" I had in total 7 unread posts from which one was even from yesterday and the rest of 4 and 5th september.
And 1 which is also in the "new posts", but that is correct because I haven't read that one yet. So in fact the other 6 posts should have been in the "new posts" as well and not in the unread posts.



So it's still not working as it should be unfortunately.
Or could this be because it was upgraded by the quick upgrade not full upgrade? If yes, which file contains the important change?

MySQL(i) 10.4.27
PHP 8.1.29
Apache 2.4.62

P.s. I'm always logged in there, I remain logged in.