Make Yes/No consistent during installation

[scootergrisen]

During phpBB installation I noticed that it says No before Yes which is opposite order than seen other places like ACP.
I suggest making it consistant which ever way is prefered (Yes/No or No/Yes consistently).

Also the spacing between No and Yes is not the same as in ACP.
So suggest making that consistent too.

NejJa.jpg

JaNej.jpg

[Mick]

You should post this in Ideas.

[Kailey]

I'd almost be willing to classify this as a bug, although a very minor one that doesn't impede the operation of the installer. As for switching the options around, this is untested but theoretically should work.

OPEN: /phpbb/install/module/obtain_data/task/obtain_server_data.php

FIND (around line 117):

Code: Select all

				'cookie_secure' => array(
					'label'			=> 'COOKIE_SECURE',
					'description'	=> 'COOKIE_SECURE_EXPLAIN',
					'type'			=> 'radio',
					'options'		=> array(
						array(
							'value'		=> 0,
							'label'		=> 'NO',
							'selected'	=> (!$cookie_secure),
						),
						array(
							'value'		=> 1,
							'label'		=> 'YES',
							'selected'	=> ($cookie_secure),
						),
					),
				),
				'force_server_vars' => array(
					'label'			=> 'FORCE_SERVER_VARS',
					'description'	=> 'FORCE_SERVER_VARS_EXPLAIN',
					'type'			=> 'radio',
					'options'		=> array(
						array(
							'value'		=> 0,
							'label'		=> 'NO',
							'selected'	=> true,
						),
						array(
							'value'		=> 1,
							'label'		=> 'YES',
							'selected'	=> false,
						),
					),
				),

REPLACE WITH:

Code: Select all

				'cookie_secure' => array(
					'label'			=> 'COOKIE_SECURE',
					'description'	=> 'COOKIE_SECURE_EXPLAIN',
					'type'			=> 'radio',
					'options'		=> array(
						array(
							'value'		=> 1,
							'label'		=> 'YES',
							'selected'	=> ($cookie_secure),
						),
						array(
							'value'		=> 0,
							'label'		=> 'NO',
							'selected'	=> (!$cookie_secure),
						),
					),
				),
				'force_server_vars' => array(
					'label'			=> 'FORCE_SERVER_VARS',
					'description'	=> 'FORCE_SERVER_VARS_EXPLAIN',
					'type'			=> 'radio',
					'options'		=> array(
						array(
							'value'		=> 1,
							'label'		=> 'YES',
							'selected'	=> false,
						),
						array(
							'value'		=> 0,
							'label'		=> 'NO',
							'selected'	=> true,
						),
					),
				),

OPEN: /phpbb/install/module/obtain_data/task/obtain_email_data.php

FIND (around line 102):

Code: Select all

				'smtp_delivery' => array(
					'label'			=> 'USE_SMTP',
					'description'	=> 'USE_SMTP_EXPLAIN',
					'type'			=> 'radio',
					'options'		=> array(
						array(
							'value'		=> 0,
							'label'		=> 'NO',
							'selected'	=> true,
						),
						array(
							'value'		=> 1,
							'label'		=> 'YES',
							'selected'	=> false,
						),
					),
				),

REPLACE WITH:

Code: Select all

				'smtp_delivery' => array(
					'label'			=> 'USE_SMTP',
					'description'	=> 'USE_SMTP_EXPLAIN',
					'type'			=> 'radio',
					'options'		=> array(
						array(
							'value'		=> 1,
							'label'		=> 'YES',
							'selected'	=> false,
						),
						array(
							'value'		=> 0,
							'label'		=> 'NO',
							'selected'	=> true,
						),
					),
				),