Can't get rid of underlines under links in prosilver

For support and discussion related to templates and themes in phpBB 3.3.
Bruce Banner
Registered User
Posts: 1383
Joined: Thu Sep 25, 2014 10:36 am

Can't get rid of underlines under links in prosilver

Post by Bruce Banner »

Something must have changed between 3.3.11 and 12 because all I used to have to do was replace the word underline with none in theme/links.css and add the following code at the bottom

Code: Select all

a, a:hover, a:active, a:visited, a:focus {
text-decoration:none;
}
But last night when I posted a link, it had an underline, so I checked links.css to make sure I'd definitely made the usual changes and I had. Then I checked prosilver French edition, which inherits from prosilver, and the link didn't have an underline. So then I used Atom to replace every instance everywhere in the forum folder of

Code: Select all

text-decoration: underline
with

Code: Select all

text-decoration: none
and

Code: Select all

text-decoration:underline
with

Code: Select all

text-decoration:none
Still didn't work. Still getting underlines under links in prosilver. Why? What should I do?
User avatar
ssl
Registered User
Posts: 2057
Joined: Sat Feb 08, 2020 2:15 pm
Location: Le Lude, Pays de la Loire - France
Name: Fred Rimbert

Re: Can't get rid of underlines under links in prosilver

Post by ssl »

Have you clear cache?
Do you use a personal style?
Sorry for my English ... I do my best! :anger_right:

:point_right_tone3: phpBB: 3.3.14 | PHP: 8.3.12
:point_right_tone4: [Kill spam on phpBB] - [Some French translation of extensions]
"Mistress, Mistress someone is bothering me in pm"
Bruce Banner
Registered User
Posts: 1383
Joined: Thu Sep 25, 2014 10:36 am

Re: Can't get rid of underlines under links in prosilver

Post by Bruce Banner »

ssl wrote: Thu Aug 29, 2024 3:36 pm Have you clear cache?
Do you use a personal style?
The cache makes no difference and I don't use a personal style.
User avatar
Mannix_
Registered User
Posts: 2037
Joined: Sun Oct 25, 2015 2:56 pm
Name: Matt

Re: Can't get rid of underlines under links in prosilver

Post by Mannix_ »

Just to make sure you cleared your browser cache not the one in ACP??
Did I helped You? Consider a donation.
New version of phpBB has been released? My styles aren't validated for it yet? Check my page for the latest downloads!
Bruce Banner
Registered User
Posts: 1383
Joined: Thu Sep 25, 2014 10:36 am

Re: Can't get rid of underlines under links in prosilver

Post by Bruce Banner »

Mannix_ wrote: Thu Aug 29, 2024 4:36 pm Just to make sure you cleared your browser cache not the one in ACP??
Yep, both caches.
User avatar
Mannix_
Registered User
Posts: 2037
Joined: Sun Oct 25, 2015 2:56 pm
Name: Matt

Re: Can't get rid of underlines under links in prosilver

Post by Mannix_ »

Care to share a link so we can see what is going on ??
Did I helped You? Consider a donation.
New version of phpBB has been released? My styles aren't validated for it yet? Check my page for the latest downloads!
Bruce Banner
Registered User
Posts: 1383
Joined: Thu Sep 25, 2014 10:36 am

Re: Can't get rid of underlines under links in prosilver

Post by Bruce Banner »

Mannix_ wrote: Thu Aug 29, 2024 4:39 pm Care to share a link so we can see what is going on ??
I'll PM you a link.
User avatar
Mannix_
Registered User
Posts: 2037
Joined: Sun Oct 25, 2015 2:56 pm
Name: Matt

Re: Can't get rid of underlines under links in prosilver

Post by Mannix_ »

I can report that the underline is gone so it must be a caching issue on your end. Try viewing your board with different browser or in incognito mode see if the issue still exists??

EDIT: The link in the post is border not a text-decoration adding

Code: Select all

.postlink {
    border: none;
}
should fix that
Did I helped You? Consider a donation.
New version of phpBB has been released? My styles aren't validated for it yet? Check my page for the latest downloads!
Bruce Banner
Registered User
Posts: 1383
Joined: Thu Sep 25, 2014 10:36 am

Re: Can't get rid of underlines under links in prosilver

Post by Bruce Banner »

Mannix_ wrote: Thu Aug 29, 2024 4:56 pmadding

Code: Select all

.postlink {
    border: none;
}
should fix that
OK, where should I add that? In links.css?

I've tried three different browsers, two of them in incognito mode (the third doesn't have an incognito mode), and all I keep seeing is this
Capture.PNG
EDIT: I tried changing the following code in links.css from

Code: Select all

.postlink {
	text-decoration: none;
	border-bottom: 1px solid transparent;
	padding-bottom: 0;
}

.postlink:hover {
	text-decoration: none;
}
to

Code: Select all

.postlink {
	text-decoration: none;
	border: none;
	border-bottom: 1px solid transparent;
	padding-bottom: 0;
}

.postlink:hover {
	text-decoration: none;
	border: none;
}
Now, when I hover over the link, the underline disappears, but when I stop hovering, it reappears.

EDIT: I got rid of the line

Code: Select all

border-bottom: 1px solid transparent;
And that's gotten rid of the underline completely but I never used to have to do that with 3.3.11 so I don't understand what's changed.

EDIT: Wait a second, I'm remembering something now. Maybe I actually did have to change that postlink code and then forgot. Damn it, yeah. Sorry, guys, I remember now having to change that postlink code before. Totally forgot about it. Oh well, problem solved now. Thanks.
You do not have the required permissions to view the files attached to this post.
User avatar
ssl
Registered User
Posts: 2057
Joined: Sat Feb 08, 2020 2:15 pm
Location: Le Lude, Pays de la Loire - France
Name: Fred Rimbert

Re: Can't get rid of underlines under links in prosilver

Post by ssl »

Bruce Banner wrote: Thu Aug 29, 2024 5:06 pm Sorry, guys, I remember now having to change that postlink code before. Totally forgot about it. Oh well, problem solved now. Thanks.
In such a case, using a child style, this type of error would not occur during updates.
Sorry for my English ... I do my best! :anger_right:

:point_right_tone3: phpBB: 3.3.14 | PHP: 8.3.12
:point_right_tone4: [Kill spam on phpBB] - [Some French translation of extensions]
"Mistress, Mistress someone is bothering me in pm"
Bruce Banner
Registered User
Posts: 1383
Joined: Thu Sep 25, 2014 10:36 am

Re: Can't get rid of underlines under links in prosilver

Post by Bruce Banner »

ssl wrote: Thu Aug 29, 2024 5:40 pm In such a case, using a child style, this type of error would not occur during updates.
Sorry, having difficulty understanding you. I don't know what you mean by a "child" style.
Bruce Banner
Registered User
Posts: 1383
Joined: Thu Sep 25, 2014 10:36 am

Re: Can't get rid of underlines under links in prosilver

Post by Bruce Banner »

I REMEMBER NOW!! It was colours.css!!

I should have changed this

Code: Select all

.postlink {
	border-bottom-color: #368AD2;
	color: #368AD2;
}

.postlink:visited {
	border-bottom-color: #5D8FBD;
	color: #5D8FBD;
}
to

Code: Select all

.postlink {
	color: #368AD2;
}

.postlink:visited {
	color: #5D8FBD;
}
I'd totally forgotten about the colours file!!
User avatar
bennybernaer
Registered User
Posts: 724
Joined: Tue Mar 22, 2011 9:53 pm

Re: Can't get rid of underlines under links in prosilver

Post by bennybernaer »

It might be an idea to place custom css in a custom.css file. This way you can't forget it anymore.
Bruce Banner
Registered User
Posts: 1383
Joined: Thu Sep 25, 2014 10:36 am

Re: Can't get rid of underlines under links in prosilver

Post by Bruce Banner »

bennybernaer wrote: Thu Aug 29, 2024 6:26 pm It might be an idea to place custom css in a custom.css file. This way you can't forget it anymore.
Good idea.

Return to “[3.3.x] Styles Support & Discussion”