Avoid reusing string in cli.php

Having a question about translating phpBB 3.3? Want to discuss and collaborate with people currently translating phpBB 3.3? Here would be the correct place to do so.
User avatar
scootergrisen
Translator
Posts: 257
Joined: Thu Aug 25, 2011 2:25 pm

Avoid reusing string in cli.php

Post by scootergrisen »

I notice there is a single string in the translation files (language/en/cli.php) that reuse another string.
Maybe to be consistent we could not do it like that.
But rather just have translators translate two strings. And then programmers can decide in the code if they want to combine two strings. Or just have the translators have the same text two places.

Code: Select all

	'CLI_DESCRIPTION_CRON_RUN'					=> 'Runs all ready cron tasks.',
[...]
	'CLI_HELP_CRON_RUN'			=> $lang['CLI_DESCRIPTION_CRON_RUN'] . ' Optionally you can specify a cron task name to run only the specified cron task.',
I suggest:

Code: Select all

	'CLI_DESCRIPTION_CRON_RUN'					=> 'Runs all ready cron tasks.',
[...]
	'CLI_HELP_CRON_RUN'			=> 'Optionally you can specify a cron task name to run only the specified cron task.',
Or:
I suggest:

Code: Select all

	'CLI_DESCRIPTION_CRON_RUN'					=> 'Runs all ready cron tasks.',
[...]
	'CLI_HELP_CRON_RUN'			=> 'Runs all ready cron tasks. Optionally you can specify a cron task name to run only the specified cron task.',

Return to “[3.3.x] Translations”