[Discuss] phpBB 3.3.15-RC1 available for testing

[Marc]

Use this topic to discuss the phpBB 3.3.15-RC1 available for testing blog post.

[P_I]

Update my testing board that was running 3.3.14 using https://www.phpbb.com/support/docs/en/3 ... date_full/.

Versions:
PHP 8.3.17
Database server: MySQL(i) 10.11.8-MariaDB-0ubuntu0.24.04.1

Sanity tested all okay.

[ssl]

Updated using advanced update: https://www.phpbb.com/support/docs/en/3 ... _advanced/ from phpBB 3.3.14
PHP 8.3.16

Everything went as planned

[canam800er]

Update my testing board that was running 3.3.14 with Full Package
Versions:
PHP 7.4.33
Database server: MySQL(i) 10.5.19-MariaDB-0+deb11u2
The update went without any problems. But on ACP index I get the following error message:

Code: Select all

Fatal error: Uncaught Error: Call to undefined method RuntimeException::get_parameters() in /phpBB3/includes/acp/acp_main.php:490 Stack trace: #0 /phpBB3/includes/functions_module.php(684): acp_main->main('main', 'main') #1 /phpBB3/adm/index.php(81): p_master->load_active() #2 {main} thrown in /phpBB3/includes/acp/acp_main.php on line 490
Fatal error: Uncaught Error: Call to undefined method RuntimeException::get_parameters() in ./includes/acp/acp_main.php:463

The following has been changed:
Open: root/vendor/guzzlehttp/guzzle/src/functions.php
Find:

Code: Select all

    } elseif (!$handler) {

Replace with:

Code: Select all

    } elseif (!$handler && function_exists('curl_exec')) {

The ‘General’ page of the ACP is now accessible again and there is no fatal error in the Extensions Manager when running the re-check all versions.
It affects all extensions that have a version check. In my testboard (free webspace) the functions cURL, sockets, allow_url_fopen are deactivated.

[rxu]

There was the same issue with 3.3.14 viewtopic.php?p=16040440#p16040440
Looks like phpBB bug.

EDIT:
Suggested fix: https://github.com/phpbb/phpbb/pull/6786/files

[canam800er]

There was the same issue with 3.3.14

That's right

Suggested fix

When I undo the previous change and make the change in /includes/acp/acp_main.php, I get this error message:

Code: Select all

Fatal error: Uncaught RuntimeException: GuzzleHttp requires cURL, the allow_url_fopen ini setting, or a custom HTTP handler. in /phpBB3/vendor/guzzlehttp/guzzle/src/functions.php:119 Stack trace: #0 /phpBB3/vendor/guzzlehttp/guzzle/src/HandlerStack.php(42): GuzzleHttp\choose_handler() #1 /phpBB3/vendor/guzzlehttp/guzzle/src/Client.php(65): GuzzleHttp\HandlerStack::create() #2 /phpBB3/phpbb/file_downloader.php(56): GuzzleHttp\Client->__construct(Array) #3 /phpBB3/phpbb/file_downloader.php(79): phpbb\file_downloader->create_client('https://www.php...', 443, 30) #4 /phpBB3/phpbb/version_helper.php(384): phpbb\file_downloader->get('www.phpbb.com', '/customise/db/e...', 'version_check', 443, 30) #5 /phpBB3/phpbb/version_helper.php(354): phpbb\version_helper->get_versions(false, false) #6 /phpBB3/phpbb/version_helper.php(273): phpbb\version_helper->get_versions_matching_stability(false, false) #7 /phpBB3/phpbb/extension/manager.php(557): phpbb\version_helper->get_ext_update_on_branch(false, false) #8 /phpBB3/includes/acp/acp_extensions.php(338): phpbb\extension\manager->version_check(Object(phpbb\extension\metadata_manager), false, false, NULL) #9 /phpBB3/includes/functions_module.php(684): acp_extensions->main('extensions', 'main') #10 /phpBB3/adm/index.php(81): p_master->load_active() #11 {main} thrown in /phpBB3/vendor/guzzlehttp/guzzle/src/functions.php on line 119

Edit:
Additional change in the root/vendor/guzzlehttp/guzzle/src/functions.php
Find:

Code: Select all

        throw new \RuntimeException('GuzzleHttp requires cURL, the '

Replace with:

Code: Select all

        throw new \phpbb\exception\runtime_exception('GuzzleHttp requires cURL, the '

It´s work without error message.

Edit2:
Is not correct, please ignore!

[rxu]

I get this error message

Updated the fix.

[canam800er]

I did the Updated fix, but the same error message.

[rxu]

same error message

Another fix: https://github.com/phpbb/phpbb/pull/6788/files

[Stoker 4.0]

Updated a test board from 3.3.14 without any problems

[canam800er]

I had only made this fix: https://github.com/phpbb/phpbb/pull/6788/files
In the ACP index no error but this:

acp_index.jpg

Failed to obtain latest version information.
GuzzleHttp requires cURL, the allow_url_fopen ini setting, or a custom HTTP handler.
Re-Check version · More information »

Its in root/vendor/guzzlehttp/guzzle/src/functions.php on line 119
Even if I do this fix additionally: https://github.com/phpbb/phpbb/pull/6786/files

[rxu]

In the ACP index no error but this

Well, this is how it should work eventually. Thanks for verifying the fix.

[canam800er]

The correct message is still missing
Currently:

Failed to obtain latest version information.
GuzzleHttp requires cURL, the allow_url_fopen ini setting, or a custom HTTP handler.

This should be the message:

Failed to obtain latest version information.
The operation could not be completed because the fsockopen function has been disabled or the server being queried could not be found.

[rxu]

You didn't mention fsockopen is disabled on your server.
With the fix, phpBB translates the actual message thrown by RuntimeException in GuzzleHTTP, which informs about the real issue and seems to be inline with the code logic.
But yes, the message can be adjusted on phpBB side to not mention Guzzle, f.e. to something like The operation could not be completed because cURL PHP extension and allow_url_fopen PHP ini setting have been disabled and no other HTTP handler could be found.

[canam800er]

You didn't mention fsockopen is disabled on your server.

I have, look here: viewtopic.php?p=16055032#p16055032
The Message is good.