"subscribe topic" to really worked as a checkbox

[D. K]

YES it does look like the Bookmark should also toggle....Will the "powers that be" see this and will they take it under advisement?

[Gumboots]

Oh alright then.

Code: Select all

				<!-- IF U_BOOKMARK_TOPIC -->
					<li>		
						<a href="{{ U_BOOKMARK_TOPIC }}" class="bookmark-link" title="{{ S_BOOKMARK_TOPIC }}" data-ajax="toggle_link" data-toggle-class="icon fa-bookmark{{ !S_BOOKMARKED_TOPIC ? '' : '-o' }} fa-fw" data-toggle-text="{{ S_BOOKMARK_TOGGLE }}" data-toggle-url="{{ U_BOOKMARK_TOPIC_TOGGLE }}" data-update-all=".bookmark-link">
							<i class="icon fa-bookmark{{ S_BOOKMARKED_TOPIC ? '':'-o' }} fa-fw" aria-hidden="true"></i><span>{{ S_BOOKMARK_TOPIC }}</span>
						</a>
					</li>
				<!-- ENDIF -->

I suppose now someone will be wanting me to do a PR.

[Gumboots]

@Gumboots
The issue with the icon not updating was related to the AJAX call, which also needs to be addressed. I've submitted the PR for PHPBB-17492, which now needs to be reviewed by the developers.

Tracker comment
GitHub phpBB #6797

Not sure if you're interested, but since I was dumb enough to mention bookmarks, and the OP asked, I sorted code for that one too (see previous post). Seems to work. Yes, even if I reload the page. You might want to double check it though.