Fix For The Firefox "Remember Passwords" Problem

All new MODs released in our MOD Database will be announced in here. All support for released MODs needs to take place in here. No new MODs will be accepted into the MOD Database for phpBB2
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

On February 1, 2009 this forum will be set to read only as part of retiring of phpBB2.
Post Reply

Rating:

Excellent!
26
65%
Very Good
7
18%
Good
4
10%
Fair
0
No votes
Poor
3
8%
 
Total votes: 40

Extensions Robot
Extensions Robot
Extensions Robot
Posts: 28009
Joined: Sat Aug 16, 2003 7:36 am

Fix For The Firefox "Remember Passwords" Problem

Post by Extensions Robot » Sun Feb 05, 2006 9:00 pm

MOD Name: Fix For The Firefox "Remember Passwords" Problem
Author: T0ny
MOD Description: Fix for firefox's Remember Passwords feature overwriting username and password on the 'User Administration' page

MOD Version: 1.2.2 (Updated 11/15/06)
Tested on phpBB Version: 2.0.21

Download File: fix_firefox_pwd_1.2.2.mod
mods overview page: View
File Size: 5404 Bytes



Support for this MOD needs to be asked within this topic. The phpBB Teams are not responsible or required to give anyone support for this MOD. By installing this MOD, the phpBB Support Team or phpBB MODifications Team may not be able to provide support.

This MOD has only been tested by the phpBB MOD Team with the phpBB version listed in the topic. It may not work in any other versions of phpBB.
Last edited by Extensions Robot on Mon Apr 30, 2007 12:30 am, edited 1 time in total.
(this is a non-active account manager for the phpBB Extension Customisations Team)

User avatar
webmacster87
Former Team Member
Posts: 3758
Joined: Fri Jun 11, 2004 2:30 am
Location: San Mateo, CA
Name: Douglas Bell
Contact:

Post by webmacster87 » Tue Feb 07, 2006 11:41 pm

MOD Validated/Released

Notes:
Some browsers will cause a problem with the User Admin panel in which the username/password of another user will be automatically changed by the web browser's password autocomplete. This MOD seeks to fix that error by changing instances of username to user_name.

User avatar
onigumo
Registered User
Posts: 1755
Joined: Fri Oct 31, 2003 2:32 am
Contact:

Post by onigumo » Tue Feb 07, 2006 11:52 pm

Oh my gods, thank you. :)
I write articles on community building
@ The Infinity Program.

niksa
Registered User
Posts: 612
Joined: Mon Sep 08, 2003 7:20 pm
Location: Future birthplace of James T. Kirk
Contact:

Post by niksa » Wed Feb 08, 2006 3:14 am

Are those in-line find & replaces for the admin_ug_auth.php and admin_users.php file?

Code: Select all

#
#-----[ FIND ]---------------------------------------------------
#

else if ( ( $mode == 'user' && ( isset($HTTP_POST_VARS['username'])

#
#-----[ REPLACE WITH ]---------------------------------------------------
#

else if ( ( $mode == 'user' && ( isset($HTTP_POST_VARS['user_name'])
For example, the line that would be replaced in that function in my version would be:

Code: Select all

else if ( ( $mode == 'user' && ( isset($HTTP_POST_VARS['username']) || $user_id ) ) || ( $mode == 'group' && $group_id ) )
:arrow: My question is... do you want us to replace username with user_name or should we replace the WHOLE line?
Last edited by niksa on Wed Feb 08, 2006 3:18 am, edited 1 time in total.

User avatar
MHobbit
Former Team Member
Posts: 4761
Joined: Thu Mar 18, 2004 5:32 pm
Location: There and Back Again

Post by MHobbit » Wed Feb 08, 2006 3:17 am

FINDs can be partial finds, so in this case, I believe the only thing you'd change is username to user_name. :-)
Former phpBB MOD Team member
No private support is offered.
"There’s too many things to get done, and I’m running out of days..."

niksa
Registered User
Posts: 612
Joined: Mon Sep 08, 2003 7:20 pm
Location: Future birthplace of James T. Kirk
Contact:

Post by niksa » Wed Feb 08, 2006 3:22 am

MennoniteHobbit wrote: FINDs can be partial finds, so in this case, I believe the only thing you'd change is username to user_name. :-)


Ok, that's what I did for both files. I usually do full line unless it says partial find in the comment or unless it is an in-line find & replace.

(This would be good to note for EM users.)

Oh and, the MOD is great. I have already several users wanting me to pass T0ny a big thanks. 8)

wGEric
Former Team Member
Posts: 8805
Joined: Sun Oct 13, 2002 3:01 am
Location: Friday
Name: Eric Faerber
Contact:

Post by wGEric » Wed Feb 08, 2006 4:11 am

When you do a FIND the next actions should be on the full line even if the FIND is only a partial. If this MOD isn't doing that, then we made a mistake.
Eric

niksa
Registered User
Posts: 612
Joined: Mon Sep 08, 2003 7:20 pm
Location: Future birthplace of James T. Kirk
Contact:

Post by niksa » Wed Feb 08, 2006 4:29 am

Well I think it should be an in-line find in this example for sure:

Code: Select all

#
#-----[ FIND ]---------------------------------------------------
#

$s_hidden_fields .= '<input type="hidden" name="username"

#
#-----[ REPLACE WITH ]---------------------------------------------------
#

$s_hidden_fields .= '<input type="hidden" name="user_name"
Because the line it finds is:

Code: Select all

$s_hidden_fields .= '<input type="hidden" name="username" value="' . str_replace("\"", """, $username) . '" />';
So for example, Easymod would replace that whole line with just $s_hidden_fields .= '<input type="hidden" name="user_name" and it could be confusing for manual moders too. EM will definitely hang up on this.

There are a couple find & replaces like that.. Might be worth a quick second glance. 8) Thanks for the replies.. I'm glad I was doing the right thing. :)

User avatar
Sym0n
Registered User
Posts: 33
Joined: Fri Apr 05, 2002 8:45 pm
Location: Bury

Post by Sym0n » Wed Feb 08, 2006 9:47 pm

THANK YOU!!!

I have been dying for something to sort this problem out :D

User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Post by igorw » Thu Feb 09, 2006 1:07 am

First: What about passwords? Does this mod fix them too.
Second: Is it compatible with this mod? If not, could you help me to make it compatible?

Thanks!

User avatar
webmacster87
Former Team Member
Posts: 3758
Joined: Fri Jun 11, 2004 2:30 am
Location: San Mateo, CA
Name: Douglas Bell
Contact:

Post by webmacster87 » Thu Feb 09, 2006 2:20 pm

MOD Updated to version 1.0.2
See first post for Download Link

User avatar
T0ny
Registered User
Posts: 1383
Joined: Sun Jan 29, 2006 8:42 pm
Location: Lancashire
Name: Tony

Post by T0ny » Thu Feb 09, 2006 4:14 pm

Whoops, my bad. Guess that'll teach me to read the docs a bit better next time :oops:

Hopefully 1.0.2 should conform a bit better.
First: What about passwords? Does this mod fix them too.


Yes, it stops Firefox from automatically filling in both the username and the pasword field in the User Administration page.
Second: Is it compatible with this mod? If not, could you help me to make it compatible?


I don't think it will work with that MOD and I don't think there is anything I can change to make it work. The changes would have to be made to the other MOD to make it compatible with this one...I think


Thanks to all for problem reporting & patience with a newbie modder. (Hopfully the thing will work properly this time :) )

T0ny

User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Post by igorw » Thu Feb 09, 2006 4:39 pm

Okay, i'll uninstall that mod then... :)

NightriderXP
Registered User
Posts: 1418
Joined: Sat Oct 09, 2004 8:17 am
Location: Florida, US
Contact:

Post by NightriderXP » Thu Feb 09, 2006 7:52 pm

Are you ever going to fix this problem? After this MOD is installed, the Management option can no longer find ANY members of the community...

Image

Image

User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Post by igorw » Thu Feb 09, 2006 8:13 pm

NightriderXP wrote: Are you ever going to fix this problem? After this MOD is installed, the Management option can no longer find ANY members of the community...


It works for me. That error may be caused by other Admin user/user search mods installed...

Post Reply

Return to “[2.0.x] MOD Database Releases”