[MODDB] Internal Links Open in Same Window (Local Links)

drathbun · Post by **drathbun** » Sat Aug 24, 2002 6:18 pm

The purpose of this MOD is to add a function to bbcode.php that allows users to post links to other posts (or topics) within your forum that reuse the same browser window.

In the standard phpBB code any link - whether it's entered with bbcode URL or simply entered as a web address - will open a new browser window when clicked. This mod adds a function call after all of the other bbcode formatting has been done. At that point the text is just about ready to display. This MOD searches the post text for any URL's that reference your server (as determined by $board_config['server_name']) and changes the target so that internal links reuse your existing browser session.

[Edit]
Added download link
Zip file
txt file

Demo Post with a variety of links to see this MOD in action.

Submitted to the MOD-DB, will update if / when approved.

Approved and in the MOD-DB.
[/Edit]

MOD Release / Support Topic

drathbun · Post by **drathbun** » Sat Aug 24, 2002 6:29 pm

Future Enhancement
It might be nice to make this a user profile setting, something like:

Code: Select all

Internal Links Open in Same Window Yes No

Even if you implement this mod and your users complain that they want the links to open in a new window, there's a very easy fix. At least with IE... simply hold the SHIFT key down while you click and it forces a new browser window to be opened for any link.

Dave

drathbun · Post by **drathbun** » Sat Aug 24, 2002 6:48 pm

Note there's another similar mod that changes all links to open in the same window in this topic:

http://www.phpbb.com/phpBB/viewtopic.php?t=36342

Dave

drathbun · Post by **drathbun** » Sat Aug 24, 2002 6:54 pm

And finally, here's a link to a forum where you can demo this MOD in action. This is a particular topic, and it's locked, but you can check out the behavior of internal vs. external links.

[Edit]Link updated
Demo Post with a variety of links for testing.
[/Edit]

drathbun · Post by **drathbun** » Thu Aug 29, 2002 3:05 am

Just curious... is anyone interested in this mod? Has anyone tried it out to see if it works for you?

I did figure out one thing, I should change the hard coding for "http:" to use the board config item in case anyone is running a secure server (https). I should also include the port, in case someone is using a non-standard port.

How about it... has anyone else tried it? Did it work? have problems?

I can't believe I'm the only one that would rather have internal links stay in the same browser window instead of spawning a million new sessions... but maybe that's just me. 8)

Dave

netclectic · Post by **netclectic** » Thu Aug 29, 2002 7:49 am

Note, there is also another mod which does this same thing slightly differently here - http://www.phpbb.com/phpBB/viewtopic.php?t=25354

good idea though, i didn't think to use the board name in the config

Mav · Post by **Mav** » Thu Aug 29, 2002 8:23 am

i've tried it and it seems to be working fine

must have missed your version when it came out netclectic

netclectic · Post by **netclectic** » Thu Aug 29, 2002 8:57 am

[Edit]
Oops!

I take it back, i really shold read through and try the example before opening my mouth

netclectic wrote: It was a while ago, and there wasn't much of a fanfare

One thing, i dont think this version will work for auto created links, eg www.phpbb.com - without the [ url ] tags. You might want to look at the make_clickable function in bbcode.php

[/Edit]

Mav · Post by **Mav** » Thu Aug 29, 2002 9:08 am

just tested it that way and it worked fine 8)

R. U. Serious · Post by **R. U. Serious** » Thu Aug 29, 2002 9:30 am

What would be nice is, if you follow an internal link it also appends the users session_id (for those not using cookies).

I haven't tried the mod yet, but I certainly will. Good work.

drathbun · Post by **drathbun** » Thu Aug 29, 2002 1:49 pm

R. U. Serious wrote: What would be nice is, if you follow an internal link it also appends the users session_id (for those not using cookies).

Oh yeah, supposed to use the append_sid() function for that. Forgot. I'll put it in and test it and update the code. Thanks for the feedback.

Dave

drathbun · Post by **drathbun** » Thu Aug 29, 2002 1:56 pm

netclectic wrote: Note, there is also another mod which does this same thing slightly differently here - http://www.phpbb.com/phpBB/viewtopic.php?t=25354

good idea though, i didn't think to use the board name in the config

Well, I did search first, apparently not well enough.

Also I saw a post from AbelaJohnB that implied that this had not been done before. Or at least that was the way I read it. Was still fun to figure out, and I thought I would share my efforts with my first mod.

Thanks for adding the link; that way folks have options! Always a good thing...

Dave

Percu.org · Post by **Percu.org** » Tue Nov 12, 2002 9:06 pm

this mod works exactly the way i need !

thanks to the Author

IDB · Post by **IDB** » Wed Nov 13, 2002 5:18 am

drathbun wrote:
R. U. Serious wrote:What would be nice is, if you follow an internal link it also appends the users session_id (for those not using cookies).

Oh yeah, supposed to use the append_sid() function for that. Forgot. I'll put it in and test it and update the code. Thanks for the feedback.

Dave

Did you make this change yet?

drathbun · Post by **drathbun** » Thu Feb 13, 2003 3:32 am

IDB wrote: Did you make this change yet?

No, actually, and somehow I didn't get notified of your post. I have this topic set to "watch", but I had assumed that nobody was following it / requesting it since I wasn't getting notified.

I've got some "phpbb-modding" time scheduled soon, primarily for my own board, but I'll try to get the code fixed to use the append_sid() function too.

Thanks for your interest.

Dave