[RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.6)

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Scam Warning
User avatar
IBBoard
Registered User
Posts: 543
Joined: Wed May 25, 2005 9:02 pm
Location: Worcestershire, UK

Re: [Beta] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.1)

Post by IBBoard »

A short tutorial on what?

In terms of other templates, I've supplied code for Prosilver and subsilver2. Most themes are based on or are similar to one or the other of those themes. I can't guarantee to help with other themes (since I could get swamped with requests for a huge variety of themes) but they should provide a starting point for any changes you need to make to your template.
farazhamzaa
Registered User
Posts: 128
Joined: Tue Mar 24, 2009 7:37 pm

Re: [Beta] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.1)

Post by farazhamzaa »

Respected IBBoard

i have installed this mod sucefully ... i can creat rank from ACP. But its now Working as multiple rank in View topic?

when i view topic then users remain have the same rank which is default setted.. now working othere...

who to make it display multi rank???
User avatar
IBBoard
Registered User
Posts: 543
Joined: Wed May 25, 2005 9:02 pm
Location: Worcestershire, UK

Re: [Beta] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.1)

Post by IBBoard »

Any rank themes you create can be chosen by your forum members. If they don't chose a rank theme then they will use the default rank theme. Users can pick their rank theme in the UCP. Members who have special ranks (e.g. Administrators) cannot chose a rank theme* because the "special rank" is their theme and it can't be changed.

Hopefully that answers your question.


* There is a way to let them chose a rank, but it involves installing my "Special and Normal Rank Images" mod.


Also, the phpBB team recommend that you don't install development MODs on live forums. There is a released version (1.2.2 is the last one that I think got approved) in the MOD DB.
User avatar
IBBoard
Registered User
Posts: 543
Joined: Wed May 25, 2005 9:02 pm
Location: Worcestershire, UK

Re: [Beta] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.1)

Post by IBBoard »

Version 1.3.2 is now available. This is still Beta/RC code (i.e. I think it is almost ready to go out but it needs others to check it) so please post feedback if you install it.

Changes in this version compared to 1.3.1:
  • Added theming to PM viewing page (it wasn't there but no-one had complained yet!)
  • Back-port changes made to v1.2.4 to try to pass validation
  • Alter instructions slightly to try to ensure the optional "rank theme" parameter always ends up at the end of the method.
User avatar
IBBoard
Registered User
Posts: 543
Joined: Wed May 25, 2005 9:02 pm
Location: Worcestershire, UK

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.2)

Post by IBBoard »

Anyone got any feedback on v1.3.2? It takes an age to get this MOD through the approval system, so the sooner people say things the sooner I can get something out as a final release :)
Anyasha
Registered User
Posts: 704
Joined: Mon Aug 07, 2006 4:02 am
Name: Anyasha

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.2)

Post by Anyasha »

I can't even install this MOD because it says "Language file ./../language/en/mods/MultiRaceRankThemes.php couldn't be opened". The file doesn't even exist in the language/en/mods folder upon download, so I can't copy it to the proper directory because it doesn't even exist.

I did the SQL manually to continue trying this out. When I go to the ranks page in the ACP and click "add new rank them" and fill it out, when I submit I get the error "You must select a valid rank theme. Default and special themes cannot be deleted." There wasn't an option to select a rank theme, I was trying to CREATE one, not delete one.

Also because of the missing language file I just get { ACP_MANAGE_RANK_THEMES } in the header and { ACP_RANK_THEMES } in the box.

Also, that svn folder in every single folder of the download is really annoying.
Kiss me, I'm Polish!
User avatar
IBBoard
Registered User
Posts: 543
Joined: Wed May 25, 2005 9:02 pm
Location: Worcestershire, UK

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.2)

Post by IBBoard »

I guess it is a good job that I hadn't submitted it then!

There shouldn't be a language file called "./../language/en/mods/MultiRaceRankThemes.php" - it isn't meant to be in there, and my forum is running fine without it so I don't know what is saying that it needs the file. There is, however, "permissions_MultiRaceRankThemes.php", which is in the "root" folder for files to be copied.

ACP_MANAGE_RANK_THEMES and ACP_RANK_THEMES are in the changes to "language/en/acp/common.php", so it seems like you either didn't make the changes or phpBB is caching the language.

The message about needing to select a rank theme appears to have been a minor error in the logic. I'll upload a fixed version shortly. Basically, there is a "$rank_id <= 0" condition that should be "$rank_id < 0".

Sorry about the .svn folders - I use Subversion for source control with the Trac install and dot-folders are hidden on Linux, so I don't realise they're there.
Anyasha
Registered User
Posts: 704
Joined: Mon Aug 07, 2006 4:02 am
Name: Anyasha

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.2)

Post by Anyasha »

I'll await your next version and try it again. :)
Kiss me, I'm Polish!
User avatar
IBBoard
Registered User
Posts: 543
Joined: Wed May 25, 2005 9:02 pm
Location: Worcestershire, UK

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.3)

Post by IBBoard »

You won't have to wait long - I've finished it now and the first post has been updated :)

I found out what the missing language was - bad documentation! If you read the documentation on setting up permissions then it gives you a sample install file, but it doesn't tell you that the $user->setup() call shouldn't have a path in if you don't have a language file.

Hopefully this version will work for you.
Anyasha
Registered User
Posts: 704
Joined: Mon Aug 07, 2006 4:02 am
Name: Anyasha

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.2)

Post by Anyasha »

Just a hint, I would pop the subsilver instructions in the contrib folder and change the link-group to contrib/subsilver2 because sometimes AutoMOD will pick up the template instructions over the install.xml file.

I am installing this on a fresh 3.0.6 and the find for prosilver/template/ucp_register.html isn't there. It should be:

Code: Select all

	<dl>
		<dt><label for="tz">{L_TIMEZONE}:</label></dt>
		<dd><select name="tz" id="tz" tabindex="7" class="autowidth">{S_TZ_OPTIONS}</select></dd>
	</dl>
Also the "themes" folders in styles/prosilver (or subsilver2) should be "theme".

A big problem now is that I cannot see the dropdown box in the profile tab. I have the permission set correctly, and even removed the IF S_RANK_THEME_OPTIONS but then a blank box shows. I am able to set the user's rank theme in the ACP (the dropdown box is fine there). When I remove the $user->data['user_rank'] == 0 && from ucp_profile.php it is fine.

And sadly, there seems to be a conflict with the Special and Normal Rank Images MOD. :( For users who have a second (special) rank like admin or mod, their rank theme won't change anywhere on the board no matter what they select. It saves their selected rank theme, yes, but does not display it. It only displays the default.
Kiss me, I'm Polish!
User avatar
IBBoard
Registered User
Posts: 543
Joined: Wed May 25, 2005 9:02 pm
Location: Worcestershire, UK

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.4)

Post by IBBoard »

Just a hint, I would pop the subsilver instructions in the contrib folder and change the link-group to contrib/subsilver2 because sometimes AutoMOD will pick up the template instructions over the install.xml file.
Sounds like a shoddy build of AutoMOD. IIRC the main ModX instructions suggest putting other template instructions in the root folder.

The missing find looks like someone added the "tabindex", which is easy enough. The "themes" folder has been in there since 1.2 and didn't get picked up by the official check, but it looks like you're correct.

As for the Special and Normal Rank Images MOD, have you applied the compatibility patch from the other MOD after installing them? They won't work together as-is, but I've got both MODs working on my site and included additional instructions to get them working together. Also, that might be the cause of your problem in "ucp_profile.php" - the check is there to intentionally stop people picking a theme when it won't show (rank themes but not Special and Normal when the user has a special rank), but the compatibility instructions fix that.




[edit] Okay, v1.3.4 is now out and should be available from the first post. Hopefully that fixes everything :)
Anyasha
Registered User
Posts: 704
Joined: Mon Aug 07, 2006 4:02 am
Name: Anyasha

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.4)

Post by Anyasha »

I'm using the latest version of AutoMOD. *shrug* I've always had that problem, on many servers. Strange!

I seem to be having success with the 2 mods after installing the patch!
Kiss me, I'm Polish!
User avatar
IBBoard
Registered User
Posts: 543
Joined: Wed May 25, 2005 9:02 pm
Location: Worcestershire, UK

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.4)

Post by IBBoard »

So the MOD works and installs okay now, even with AutoMOD, and could be submitted for official approval?

Contrib is apparently for "Miscellaneous and alternate scripts including Text Template and optional auto-install files", but theme-specific instructions go in the root directory. The naming convention is also to use "install...xml" for the main install file name, so it basically sounds like AutoMOD can't follow official conventions if it gets confused between "install.xml" and "subsilver2.xml".
User avatar
IBBoard
Registered User
Posts: 543
Joined: Wed May 25, 2005 9:02 pm
Location: Worcestershire, UK

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.5)

Post by IBBoard »

Anyasha found a warning in the code, caused by a missing edit. 1.3.5 is now out and contains the fix. If it all installs okay after this then I'll submit it for release.
Anyasha
Registered User
Posts: 704
Joined: Mon Aug 07, 2006 4:02 am
Name: Anyasha

Re: [RC] Multi-Race Rank Themes mod AKA Ranking Sets (1.3.5)

Post by Anyasha »

In includes/constants.php you defined DEFAULT_RANK_THEME_ID twice. :)
Kiss me, I'm Polish!

Return to “[3.0.x] MODs in Development”