[MODDB] Prime Trash Bin - Keep deleted topics & posts

[primehalo]

Glad to hear it's finally working. So just to confirm, this code has fixed the permissions problem?

Code: Select all

case 'delete':
	$permission = (($auth->acl_get('f_delete', get_recycle_bin()) && $auth->acl_get('m_delete', get_recycle_bin())) || $auth->acl_get('a_', $forum_id)) ? true : false;
	$permission = $permission && $auth->acl_gets('f_read', 'f_list', get_recycle_bin());
break;

[azzurri]

Yes indeed it has. Thank you. I wish I was as clever as you.

[primehalo]

Yes indeed it has. Thank you. I wish I was as clever as you.

After dealing with all these bug fixes, I sure don't feel very clever.

Hi,

I have installed this mod and everything seems to work fine apart from 2 things.

I cannot delete threads from the moderator control panel, I just get a white page, I'm pretty sure its trying to process an error but my server is configured not to display errors and I cannot change this. Secondly, if im in viewtopic and try to delete the thread using the quick mod drop down menu I get an error sayin quick mod cannot process this but it lets me delete individual posts

Well I completely forgot about the Moderator Control Panel, so I went through and fixed things up there. Unfortunately no matter how hard I tried I couldn't reproduce either of your errors. I could delete topics and posts just fine from the MCP, and the quick mod dropdown always worked. So if you update and still have those problems, I'll need more info, like the type of user, is it the first post in a thread, is it the only post in the thread, those kinds of things.

[azzurri]

Yes indeed it has. Thank you. I wish I was as clever as you.

After dealing with all these bug fixes, I sure don't feel very clever.

But you solved them all didnt you? After all this is a BETA.

Well I completely forgot about the Moderator Control Panel, so I went through and fixed things up there. Unfortunately no matter how hard I tried I couldn't reproduce either of your errors. I could delete topics and posts just fine from the MCP, and the quick mod dropdown always worked. So if you update and still have those problems, I'll need more info, like the type of user, is it the first post in a thread, is it the only post in the thread, those kinds of things.

It is not the mods fault. I dont have these errors. He must have done something wrong in the installation.

[DJ Skitzo]

I'l have another go at applying the code changes to the moderator control panel tonight and then post with an update

EDIT:
I have gone back through this and I still get the following error when trying to delete a thread using quick mod

Code: Select all

not allowed as quickmod

& I still get a blank page when trying to delete from the moderator control panel it is the same for me whether the thread only contains one post or multiple posts.

Would it help if I posted my modded files up for you to download?

[azzurri]

What is quick mod? If you are trying to delete through another mod it is no wonder why it doesnt work with prime recycle bin.

[RedTrinity]

What is quick mod? If you are trying to delete through another mod it is no wonder why it doesnt work with prime recycle bin.

I think he may be referring to the "quick-mod tools" option which PHPBB3 has by default, its a moderation dropdown menu in the bottom right corner of topics/forums to save you from entering the MCP.

[azzurri]

Oh ok sorry. Well this works for me though with the drop down tool.

[primehalo]

I'l have another go at applying the code changes to the moderator control panel tonight and then post with an update

EDIT:
I have gone back through this and I still get the following error when trying to delete a thread using quick mod

Code: Select all

not allowed as quickmod

& I still get a blank page when trying to delete from the moderator control panel it is the same for me whether the thread only contains one post or multiple posts.

Would it help if I posted my modded files up for you to download?

Yeah, it might. Also, do you have access to your error log files? Are you using the prosilver style? Do you get the error messages when you are an admin, a global moderator, or both?

[Kleopatras_Sister]

have you some pictures ?

i dont understand all english and dont know if i need this one really

i only understand that if i press delete (only Topic will work) the topic moves in Trash
but in your info, there is more things..

Some Picture would be nice

[primehalo]

Here are some screenshots.

Deleted Post (Guest View)



Deleted Post (Admin View)



Delete Post Confirmation



Delete Topic Confirmation

[DJ Skitzo]

Yeah, it might. Also, do you have access to your error log files? Are you using the prosilver style? Do you get the error messages when you are an admin, a global moderator, or both?

Yeah, I found my error log file in my control panel and this is the error generated when trying to delete a thread from the moderator control panel

[Mon Aug 20 23:31:07 2007] [error] [client 81.154.47.229] PHP Fatal error: Call to undefined function is_recycle_bin() in /home/default/northern/user/htdocs/includes/mcp/mcp_main.php on line 792, referer: mcp.php?&f=47&i=main&forum_action=&mode=forum_view&start=0

And I get this one when trying to delete from the quick mod drop down option in view topic

[Mon Aug 20 23:38:18 2007] [error] [client 81.154.47.229] PHP Fatal error: Call to undefined function is_recycle_bin() in /home/default/northern/user/htdocs/includes/mcp/mcp_main.php on line 792, referer: mcp.php?f=47&t=1750&quickmod=1&redirect=.%2Fviewtopic.php%3Ff%3D47%26t%3D1750%26start%3D0%26st%3D0%26sk%3Dt%26sd%3Da&sid=bc5b8e731f95c60432136ce008ec7975

Also I am using AcidTech as my template but it is based on subSilver2 and therefor I could use your template files without needing to edit them

I get the same errors for both admins and mods

You can find my copy of mcp_main.php at http://www.swickeddesign.co.uk/mcp_main.zip

Hope this helps

[primehalo]

I found the problem, I had a mistake in the installation instructions. The second FIND in the following instructions isn't supposed to be there. It was probably a copy/paste mistake where I intended to overwrite the second FIND with the first FIND. The include is supposed to go above the "Move Topic" comment, which is outside of the function.

Find:

Code: Select all

/**
* Move Topic
*/

Find

Code: Select all

	$s_hidden_fields = build_hidden_fields(array(

Add before

Code: Select all

//-- mod: Prime Recycle Bin -------------------------------------------------//
include($phpbb_root_path . 'includes/prime_recycle_bin.' . $phpEx);
//-- end: Prime Recycle Bin -------------------------------------------------//

[DJ Skitzo]

Ok thanks i'l change that now and then keep you updated

[DJ Skitzo]

Right, I done that change and everything works fine apart from I do not get the option to enter a reason for deleting when deleting an actual thread, although I can still enter a reason when only deleting a single post.

And is it possible to make it so that guests and registered users cannot see the message saying this post has been deleted and could I possibly change something so that moderators cannot permanantly delete posts?