[MODDB] Prime Trash Bin - Keep deleted topics & posts

[primehalo]

Right, I done that change and everything works fine apart from I do not get the option to enter a reason for deleting when deleting an actual thread, although I can still enter a reason when only deleting a single post.

And is it possible to make it so that guests and registered users cannot see the message saying this post has been deleted and could I possibly change something so that moderators cannot permanantly delete posts?

To get the field for entering reason for deleting a thread, you need the Prime Topic Moved Info MOD.

Moderators are not supposed to be able to permanently delete posts unless they have the ability to permanently delete threads from the recycle bin forum. Is that still not working right?

The function that makes the display message for deleted posts is set_recycled_post_msg() and is found in "includes/prime_recycle_bin.php". So if you want to hide the message for certain users then you'll have to do some editing there. I'd say go to the bottom of the function and add something like this:

Code: Select all

if (!$auth->acl_get('m_') && !$auth->acl_get('a_'))
{
		$recycled_msg = '';
}

That says if the user isn't a moderator and isn't an administrator then blank out the deleted message.

[DJ Skitzo]

Moderators are not supposed to be able to permanently delete posts unless they have the ability to permanently delete threads from the recycle bin forum. Is that still not working right?

I have tried going into forum permissions then editting the groups permissions but cannot see anything about allow users to delete posts in their. I was wondering could the setting I need be located elsewhere?

And I had your other mod saved already just hadn't got round to installing it yet but I will do that now

I will also try adding that code you gave me to the forum aswell and keep you updated

[DJ Skitzo]

I added your code to the bottom of prime_recycle_bin.php so that it now looks like this in the bottom of the file

Code: Select all

if (!$auth->acl_get('m_') && !$auth->acl_get('a_'))
{
      $recycled_msg = '';
}
?>

But when I log in as a normal guest I can still see the deleted post message

[primehalo]

I added your code to the bottom of prime_recycle_bin.php so that it now looks like this in the bottom of the file

Code: Select all

if (!$auth->acl_get('m_') && !$auth->acl_get('a_'))
{
      $recycled_msg = '';
}
?>

But when I log in as a normal guest I can still see the deleted post message

I agree with you these permissions are more than just a bit confusing. I have my recycle bin forum set to read only for global moderators, by my global moderator account can't see it. I can't get anyone to see it except for my founder account. Not even the secondary admin account I created can see it. And I have the category containing the forum set so everyone has access, but that didn't seem to help. I've read over the page explaining permissions a couple times, but it looks like it's gonna take a few more before I understand it.

I thought that said code said if the user is not a moderator and not an administrator, but since its not clearing the message then maybe I'm wrong. Try using this:

Code: Select all

if ($user->data['user_id'] != ANONYMOUS)

That should check to at least see if the user is registered. See if that will clear the message for guests.

[DJ Skitzo]

It's ok I will just leave it how it is as I seem to have everything working fine at the moment.

I have also just installed that your other mod (prime moved topic) and it seems to be working great.

Theres just one little thing which you might be interested in adding for a future release. On vBulletin when a thread is deleted it leaves a sort of shadow thread and you can set permissions as to which groups are allowed to see it the title of the thread and the reason it has been deleted.

If needed I could supply you with a screenshot from a forum I have permission to view this on so that you could see how it has been layed out etc

As for the permissions part I may be able to help you a bit there as I have succesfully managed to add category and several forums which are only visible to global moderators and administrators, in that category I have placed the recycle bin & the forum in which the contact messages from evil<3's contact form are displayed

If you are interested in how I have done this please just let me know and I'l be more than happy to help

Now I just need to start installing your prime birthday require mod, I think I tried this one the other day and failed but I will give it another go and then post in the appropriate thread

[RedTrinity]

Theres just one little thing which you might be interested in adding for a future release. On vBulletin when a thread is deleted it leaves a sort of shadow thread and you can set permissions as to which groups are allowed to see it the title of the thread and the reason it has been deleted.

If needed I could supply you with a screenshot from a forum I have permission to view this on so that you could see how it has been layed out etc

You mean like this? http://www.phpbb.com/community/viewtopi ... 5#p3164145

I am also waiting and hoping this similar feature can be implemented into this MOD.

[DJ Skitzo]

You mean like this? http://www.phpbb.com/community/viewtopi ... 5#p3164145

I am also waiting and hoping this similar feature can be implemented into this MOD.

Yeah that exactly what I mean, I would like it to do the same for both moved and deleted threads

[primehalo]

This feature has been added to Prime Topic Moved Info MOD, and I just updated the Prime Recycle Bin MOD so that you can leave shadow links behind when deleting.

The moved/deleted info is placed under the shadow link if a shadow link exists, but only if you enable this option in the ACP.

I didn't mess with the permissions for viewing the shadow links. As is default, users will see the shadow topic if they are allowed to see the forum that the topic was moved to, otherwise they will not. So if you only want to make the deleted info available to certain users then you have to make the Recycle Bin forum visible to only those users.

[playerfr]

As I see a lot of work has been done on this mod so finaly I am going to install it

Why this one dont have RC status ? are you still planning to add more features to it ?

Thanks

[playerfr]

I cant find this code : even in phpbb original files, is there any mistake ?

Code: Select all

Open: includes/mcp/mcp_topic.php
Find
Tip: This may be a partial find and not the whole line.

Code: Select All
				// Now it's time to do our replacements.
Add before
Tip: Add these lines on a new blank line before the preceding line(s) to find.

Code: Select All
//-- mod: Prime Recycle Bin -------------------------------------------------//
// This is where we set up what we're going to display for the deleted message.
// We check to see if the post has been marked as deleted, and if it has we 
// do all our replacements. 
		if (is_post_recycled($row))
		{
			$recycled_info = get_recycled_info($row);
			$row = array_merge($row, $recycled_info);
			if (isset($recycled_info['post_deleted_time']) && isset($recycled_info['post_deleted_user']))	
			{
				$deleted_msg = set_recycled_post_msg($row, $forum_id, $message);
				$user->add_lang('mods/prime_recycle_bin');
				$template->alter_block_array('postrow', array(
					'S_DELETED'      => true,
					'POST_SUBJECT'   => $post_subject . ' - ' . $user->lang['PRIME_DELETED_POST'],
					'MESSAGE'        => $deleted_msg,
				), true, 'change');
			}
		}
//-- end: Prime Recycle Bin -------------------------------------------------//

[primehalo]

Yes, that's a mistake. The FIND should be:

Code: Select all

		// Display not already displayed Attachments for this post, we already parsed them. ;)

I was thinking about adding the ACP options that the Prime Topic Moved Info MOD has, but specific to only the recycle bin forum. That way if you only want to see the reason for deleting a message and not for moving it, you'd have that choice. Though I'm not sure which MOD will actually be updated to do that.

[playerfr]

Thanks

Now I am getting this error when I click on board setting in ACP. I checked and the file is in /en/

General Error
Language file prime_recycle_bin.php couldn't be opened.

Thanks

[primehalo]

Thanks

Now I am getting this error when I click on board setting in ACP. I checked and the file is in /en/

General Error
Language file prime_recycle_bin.php couldn't be opened.

Thanks

Are you sure you copied it to "/language/en/mods/prime_recycle_bin.php"?

[playerfr]

oh it should be in mods then your root fodler have a mistake as i see it in /en/

Thanks it work liek this now time to test it a little

[primehalo]

oh it should be in mods then your root fodler have a mistake as i see it in /en/

Thanks it work liek this now time to test it a little

Yeah, I noticed the file wasn't in the mods directory in the package, but the instructions still said it needed to be copied into the "mods" directory. I fixed the packaging, so hopefully there will be no other mistakes in there.