[RC] Prime Topic Move - add a reason & link to move it back

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Scam Warning
Lord Phobos
Registered User
Posts: 935
Joined: Tue May 18, 2004 11:41 pm

Re: [RC] Prime Topic Move - add a reason & link to move it back

Post by Lord Phobos »

On a fresh install I find all the lines and it works just fine.

I really can't find what's wrong and in which file.
If I pass you a .zip with my modified files for this MOD, can you have a look?
User avatar
primehalo
Former Team Member
Posts: 2991
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC] Prime Topic Move - add a reason & link to move it back

Post by primehalo »

Unfortunately I just don't have the free time right now to be able to help debug this for you.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
User avatar
Lisbon
Registered User
Posts: 831
Joined: Wed Jan 30, 2008 12:28 pm
Location: Zermatt

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by Lisbon »

solved!
User avatar
Neuropass
Registered User
Posts: 1163
Joined: Fri Apr 17, 2009 2:02 pm
Location: SciTE4AutoIt3

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by Neuropass »

does it work for phpbb 3.07pl?
User avatar
primehalo
Former Team Member
Posts: 2991
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by primehalo »

Yes, as far as I know.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
Shorty1968
Registered User
Posts: 253
Joined: Sat Sep 10, 2011 10:19 am

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by Shorty1968 »

Now he goes I only have a problem if the text is displayed, except for the variable of these {TOPIC_MOVED_TO} what it could be because only this text is not displayed?

greeting
Sorry for my bad english,i am a German Bub and Google Translate help me. :D
User avatar
primehalo
Former Team Member
Posts: 2991
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by primehalo »

That is a very confusing sentence. Did you use translation software?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
User avatar
Nashra
Registered User
Posts: 21
Joined: Wed Oct 27, 2010 10:21 am
Location: Wankum - Germany/NRW
Name: Ralf

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by Nashra »

hello primehalo, thanks for the MOD

i hope you can help me ;)
the variable {TOPIC_MOVED_TO} is not supported in <!-- IF TOPIC_MOVED_MODE eq 'topic' -->
my code

Code: Select all

<!-- IF TOPIC_MOVED_MODE eq 'topic' -->
	<font style="font-size:11px;font-style:italic;">{TOPIC_MOVED_MESSAGE} {TOPIC_MOVED_FROM} {TOPIC_MOVED_TO} {TOPIC_MOVED_ON} {TOPIC_MOVED_BY}.
what I must do so TOPIC_MOVED_TO is also displayed
This topic was moved from [b]XYZ[/b] to [b]ABC[/b] on 4. Nov 2011, 12:18 by [b]nashra[/b]

Thanks
(sorry for my english) :roll:
User avatar
primehalo
Former Team Member
Posts: 2991
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by primehalo »

That is correct. The variable {TOPIC_MOVED_TO} is not supported in <!-- IF TOPIC_MOVED_MODE eq 'topic' -->.

See these lines in includes/prime_topic_move.php:

Code: Select all

            $to_or_from    = ($mode == 'forum') ? 'TOPIC_MOVED_TO' : 'TOPIC_MOVED_FROM';
 

Code: Select all

            $msg['forum']    = empty($msg['forum']) ? '' : sprintf($user->lang['PRIME_' . $to_or_from], $msg['forum']);
 

Code: Select all

                $to_or_from                => $msg['forum'],
 
You should ever only need one of those. Either "From" or "To". If you are outside the place where it was moved, then you need "To". If you are inside the place where it was moved, then you need "From".
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
Shorty1968
Registered User
Posts: 253
Joined: Sat Sep 10, 2011 10:19 am

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by Shorty1968 »

primehalo wrote:That is a very confusing sentence. Did you use translation software?
Yes sorry, I translate with Google Translate
Sorry for my bad english,i am a German Bub and Google Translate help me. :D
User avatar
WileCoyote
Registered User
Posts: 432
Joined: Sun Jan 15, 2006 7:37 am
Location: Austria
Name: Wolfgang

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by WileCoyote »

I think what shorty1968 and Nashra want to know is if it is possible to change the includes/prime_topic_move.php so that {TOPIC_MOVED_TO} could be shown in <!-- IF TOPIC_MOVED_MODE eq 'topic' -->. I know it doesn't make sense but it's the way how the guys at phpbb.de have customized it ;).
Regards
WileCoyote
User avatar
primehalo
Former Team Member
Posts: 2991
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by primehalo »

Yes, it's possible, and I believe it would involve modifying those three lines of code I mentioned above and probably the nearby SQL statement as well (to get both forum names). I will leave that as an exercise for the reader since it's not a feature I desire and I have plenty else to work on at the moment.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
Shorty1968
Registered User
Posts: 253
Joined: Sat Sep 10, 2011 10:19 am

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by Shorty1968 »

Hello I'm the Prime Topic Move MOD installed and have the following code in the built viewtopic_body.html:

Code: Select all

<!-- IF postrow.TOPIC_MOVED_MESSAGE -->
			<div id="information" class="rules" style=text-align:center;"><span class="corners-top"><span></span></span>
				{postrow.TOPIC_MOVED_MESSAGE}
			<span class="corners-bottom"><span></span></span>
		</div>
		<!-- ENDIF -->
		
<!-- IF S_QUICK_REPLY -->
	<!-- INCLUDE quickreply_editor.html -->
<!-- ENDIF -->
<!-- IF QUICK_REPLY_ALLOWED --><!-- INCLUDE prime_quick_reply.html --><!-- ENDIF -->
<!-- IF S_NUM_POSTS > 1 or PREVIOUS_PAGE -->
But now he will not be displayed because why, worann is that?
Sorry for my bad english,i am a German Bub and Google Translate help me. :D
User avatar
primehalo
Former Team Member
Posts: 2991
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by primehalo »

You cannot use postrow.TOPIC_MOVED_MESSAGE outside of this loop:

Code: Select all

<!-- BEGIN postrow -->
<!-- ENd postrow -->
You have to use this:

Code: Select all

<!-- INCLUDE prime_topic_move.html -->
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
User avatar
Geolim4
Former Team Member
Posts: 1965
Joined: Sat Sep 11, 2010 3:28 pm
Location: Nantes, France
Name: Georges

Re: [RC] Prime Topic Move - add a reason & link to move it b

Post by Geolim4 »

http://www.phpbb.com/customise/db/mod/f ... 3-p_243798
I've made an addon for Forum Title Colour by ABDev :mrgreen:
phpBB-fr Former MOD Team Leader / Website Team Member

Return to “[3.0.x] MODs in Development”