[RC] Prime Topic Move - add a reason & link to move it back

[Abera]

I may be speaking out of turn here, but I don't like leaving shadow copies. It seems to be redundant and not serving the purpose of moving the topic. Is there anyway you could just leave an icon where it was and where it was moved to, or am I missing something? I see in the phpbb forum that posts are moved all of the time.
Thanks

[primehalo]

This MOD doesn't create shadow topics. The board creates shadow topics (if you select the option to do so). This MOD adds information about the move and allows the topic to be quickly moved back.

[cisco007]

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/prime_topic_move.php on line 176: Undefined index: topic_moved_from
[phpBB Debug] PHP Notice: in file /includes/prime_topic_move.php on line 176: Undefined index: topic_moved_from

I have this mod installed, and i never notice it before, but when i have config.php debug set that's the error i get on the header when i look at a topic, and i have never deleted or moved a topic!

[primehalo]

Just uploaded the fix.

[cisco007]

excelent work my friend that fixed up i just uploaded and overwrote the other files!

[Stitch625]

Version 0.1.2 now has the ability to display the moved information on the topic list near the shadow link. This only works if a shadow was left behind when the topic was moved. Also, phpbb3 only shows shadow topics if the user viewing the topic list has permission to view the forum that the topic was moved to.

First of all thank you very much for this useful mod. It is going to make my life a lot easier. One thing I am not sure I understand though. Is there supposed to be a reason in the shadow link in viewforum? Because I am not seeing it and I do have Show with shadow link in forum list checked

Thanks

[primehalo]

Yes, it should display the reason for the move underneath the shadow link to the topic in viewforum, assuming a reason was entered when the topic was moved.

[Stitch625]

Thank you for your reply but I am not seeing anything but the "Moved" message:
Here is a screen shot:


What could be wrong. The reason is showing in viewtopic. I have double checked my edits but I will check them a 3rd time.

EDIT:
I just now noticed something. In the install instructions for subsilver2 it says there are supposed to be 2 template files to upload but there is only one with the download package:

Included Files
root/styles/subsilver2/template/prime_topic_moved_msg.html,
root/styles/subsilver2/template/prime_topic_moved_to.html

I only have this:
prime_topic_move.html
What I find strange is the this file isn't even listed above.

[primehalo]

The instructions are incorrect, as prime_topic_move.html is now the only HTML file. Must have just forgotten to update the subsilver2 instructions, but this would have no effect on your issue.

Check the subsilver2 edit instruction for this file: styles/subsilver2/template/viewforum_body.html
The edit for that file is what puts the move info and reason underneath the shadow link.

[Stitch625]

Ahh ok I got it figured out. I should have remembered this from a few mods I have written:

In the viewforum_body.html file you have to do this twice:

Find
Tip: This may be a partial find and not the whole line.

<!-- IF topicrow.PAGINATION -->
<p class="gensmall"> [ {GOTO_PAGE_IMG}{L_GOTO_PAGE}: {topicrow.PAGINATION} ] </p>
<!-- ENDIF -->
Add after
<!-- IF topicrow.TOPIC_MOVED_MESSAGE -->{topicrow.TOPIC_MOVED_MESSAGE}<!-- ENDIF -->

There is one instance near the top of the file and one near the end: Thanks again for a great outstanding mod.

[Lord Phobos]

I have 1.0.1 version installed of your mod and I want to upgrade, but in the contrib folder there is no file to upgrade 1.0.1 to 1.0.2.

Maybe you forgot that?

Thanks.

[wolfman24]

If you look into the install.xml, it says

2008-06-07 - Version1.0.2
Forgot to include two global variables in the get_msg_moved_topic_to() function.

This function is in one of the files, so there is no upgrade instruction as you replace the included files nonetheless.

[Lord Phobos]

Ok, updated the mod to the last version, deleted the db, and made the last db edits.

But... when I click to move a topic, there isn't any field in which to insert a message.
What is wrong?

[primehalo]

No idea, it's working fine for me.

[Lord Phobos]

Err... ok, what should I look at?