[RC1] Prime Links - Classify Locals & Target Externals

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Ideas Centre
User avatar
umarizal
Registered User
Posts: 177
Joined: Mon Mar 17, 2008 2:03 am
Location: São Paulo - SP - Brasil
Name: Leandro dos Santos

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by umarizal »

primehalo wrote:My MOD was designed primarily for links within posts and signatures, it never processed all links everywhere.

If you want a quick and dirty fix, open includes/prime_links.php, find:

Code: Select all

                $external_target = (USE_TARGET_ATTRIBUTE === true) ? (' target="' . EXTERNAL_LINK_TARGET . '"') : (' onclick="this.target=\'' . EXTERNAL_LINK_TARGET . '\';"');
 
And after, add this:

Code: Select all

                $external_target .= EXTERNAL_LINK_REL ? (' rel="' . EXTERNAL_LINK_REL . '"') : ''; 
Thank you my friend Primehalo! You definitely are the best!

The phpBB without your mods isn´t funny!
EN: Do to others what you would want them to do to you.
ES: Haz a los demás todo lo que quieras que te hagan a ti.
PT: Faça aos outros o que você gostaria que fizessem a você.
cangor
Registered User
Posts: 87
Joined: Thu Oct 28, 2010 1:56 pm

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by cangor »

Hello, I just want to say thanks for this great MOD!
User avatar
o0Pascal0o
Registered User
Posts: 80
Joined: Tue Nov 23, 2010 7:12 pm

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by o0Pascal0o »

What the function of this MOD?
Was macht die MOD?
phpbb 3.0.8;STYLES:eTechGray(Subsilver2-base)[activ];MODS:[/u][/color]Portal 1.06;BBCodeBox3_Expanded 1.09;ultimate points 1.0.7;emailonbirthday1.01;Multi_Zodiacs;Ultimate Challenge1.0RC5
femu
Registered User
Posts: 1070
Joined: Tue Sep 27, 2005 10:03 am

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by femu »

Just read the install .... It lets you open external links in another tab/window.
Regards, femu
_____________________________________________
[My development page] - [My normal homepage (German only)]
User avatar
o0Pascal0o
Registered User
Posts: 80
Joined: Tue Nov 23, 2010 7:12 pm

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by o0Pascal0o »

aha, but this is standard, without a mod.
phpbb 3.0.8;STYLES:eTechGray(Subsilver2-base)[activ];MODS:[/u][/color]Portal 1.06;BBCodeBox3_Expanded 1.09;ultimate points 1.0.7;emailonbirthday1.01;Multi_Zodiacs;Ultimate Challenge1.0RC5
User avatar
Ruyan Ve
Registered User
Posts: 41
Joined: Thu Dec 20, 2007 3:15 am
Location: Germany

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by Ruyan Ve »

No it's not.

oh and btw, thats not the only feature of this mod.
Modifies links within posts so that local links are correctly classified as such. It can also apply a target to external links (e.g. to open in a new window) and prepend links (e.g. to apply an anonymizer).
Man is the cruelest animal.
User avatar
primehalo
Former Team Member
Posts: 2993
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by primehalo »

o0Pascal0o wrote:aha, but this is standard, without a mod.
No, it's not. I'm not sure why you think it is.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
User avatar
o0Pascal0o
Registered User
Posts: 80
Joined: Tue Nov 23, 2010 7:12 pm

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by o0Pascal0o »

Hmmm... If i click on a link, f.e.. www.google.de, a new tab in firefox opents with www.google.de, an not: www.google.de opens in the same windows as the link is.
phpbb 3.0.8;STYLES:eTechGray(Subsilver2-base)[activ];MODS:[/u][/color]Portal 1.06;BBCodeBox3_Expanded 1.09;ultimate points 1.0.7;emailonbirthday1.01;Multi_Zodiacs;Ultimate Challenge1.0RC5
User avatar
primehalo
Former Team Member
Posts: 2993
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by primehalo »

Maybe you have your browser set to open all links in a new tab.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
User avatar
o0Pascal0o
Registered User
Posts: 80
Joined: Tue Nov 23, 2010 7:12 pm

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by o0Pascal0o »

No, i testet it with Firefox & IE8. Both can´t make this without adins, and IE8 can´t it in any way, there are no addins.
phpbb 3.0.8;STYLES:eTechGray(Subsilver2-base)[activ];MODS:[/u][/color]Portal 1.06;BBCodeBox3_Expanded 1.09;ultimate points 1.0.7;emailonbirthday1.01;Multi_Zodiacs;Ultimate Challenge1.0RC5
djsteveo
Registered User
Posts: 14
Joined: Sun Jun 06, 2010 6:00 am

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by djsteveo »

This is the most important mod ever - I kind of had it working for a minute - but then I changed settings in phpbb backend to allow bots to see profiles / memberlist etc - and same for "guests" usergroup - then I went back on my other computer and checked the links on profile - and they were no longer "nofollowed" - I also checked the members list - and the links there we not "nofollowed" either -

Is this a known issue? Should I have done something in a different order?
I also tried to change the setting in prime links.php to hide external links for guests - but that did not seem to work.

I just upgraded to 3.08 - so is this an issue?

If we can get this to work I would really really appreciate it!

Steve
User avatar
primehalo
Former Team Member
Posts: 2993
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by primehalo »

I just tested and it seems to be working fine for me. The nofollow is getting added just like it should, and external links are un-linked when I testing viewing as a guest.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
User avatar
Jorup16
Registered User
Posts: 427
Joined: Sun Dec 14, 2008 5:13 am
Location: Guatemala
Name: Jorge

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by Jorup16 »

Hi, I long I have installed this mod and doing quite well, but I just installed the th23 links and something happens when a link is external, leave a sample image.

Image

Any idea how to make the image that represents an external link does not leave many times over the link?
Spanish Translations for Ext phpBB :D - Traducciones al español para Ext phpBB :)
>>>>> https://github.com/Jorup16 <<<<<
User avatar
primehalo
Former Team Member
Posts: 2993
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by primehalo »

It looks like that is caused by the th23 links overriding the CSS from my MOD. In my MOD, this is the line that controls that icon:

Code: Select all

	background:url(window.gif) no-repeat right center;
In the th23 CSS file, he has:

Code: Select all

	background:transparent;
I assume that is overriding the no-repeat part of my CSS file. To fix, I would try changing the th23 line to:

Code: Select all

	background-color:transparent;
If that doesn't work, try removing the entire line. And don't forget to refresh the style and purge the cache after you do so.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
User avatar
Jorup16
Registered User
Posts: 427
Joined: Sun Dec 14, 2008 5:13 am
Location: Guatemala
Name: Jorge

Re: [RC1] Prime Links - Classify Locals & Target Externals

Post by Jorup16 »

Thank you very much for responding quickly.
If I have worked as you said, I changed the line:

Code: Select all

 background:transparent;
I appeared twice that line (in different blocks) and I changed both and everything is fixed, I'll leave a sample image.

Image

Thank you. ;)
Spanish Translations for Ext phpBB :D - Traducciones al español para Ext phpBB :)
>>>>> https://github.com/Jorup16 <<<<<

Return to “[3.0.x] MODs in Development”