[ABD] advanced quoting

[Brizzle]

Ah, that makes sense. That would be great if you could figure out how to fix that.

Thanks!

[Erik Frèrejean]

Ah, that makes sense. That would be great if you could figure out how to fix that.

Thanks!

Shure it is one of the fixes in 1.2, thanks for the report .

[Erik Frèrejean]

I have updated my svn repsority (first post), this contains phpBB3.0 with advanced quoting 1.1 premodded. If you want to test it just install the checkout and have fun (you need to rename __install to install)

At the moment only the features of 1.0 are implemented yet, but the core is a complete rewrite.

The code in the svn repsority is still alfa quality. It is not recomended (and unsupported) to use this in a live enviroment!

[fatmcgav]

Hey mate,

Cheers for the heads up. Installed a copy on my host. Install went fine, quoted one post, and it worked fine. However when i tried to quote a post with a quote in, it threw a wobbly.
Error text is:

Code: Select all

Fatal error: Call to a member function bbcode_second_pass_quote() on a non-object in /var/www/vhosts/fatmcgav.me.uk/httpdocs/phpbb3_aq/includes/bbcode.php(117) : regexp code on line 1

Somet for you to look at already...

Edit: just checked and it does it if i try and quote the first post again...
Up at http://www.fatmcgav.me.uk/phpbb3_aq

Cheers
Gav

I have updated my svn repsority (first post), this contains phpBB3.0 with advanced quoting 1.1 premodded. If you want to test it just install the checkout and have fun (you need to rename __install to install)

At the moment only the features of 1.0 are implemented yet, but the core is a complete rewrite.

The code in the svn repsority is still alfa quality. It is not recomended (and unsupported) to use this in a live enviroment!

[Erik Frèrejean]

Thnx, fixed in svn.

[fatmcgav]

Thnx, fixed in svn.

Thats fixed it mate...

Just a quick note on the svn... mite wanna remove the cache folder from svn, as it's filling with sql files etc...

Cheers
Gavin

[Gorkk]

High,
I don't know if it has been suggested already (although I doubt it), but it would be nice to add to this mod the following feature (it could be added in a separate mod, but then it would be better anyway to have it working with this mod as well):
Add "quote this message" checkboxes next to each post in a topic, and then when clicking the answer button, having the post form already filled with the quotes from all the messages selected.

It could be an independent mod, but then would anyway require a specific version to use this mod enhancements (as an independent mod would only use the "classic" quote codes, not your improved quote codes).

Anyway, this mod is still very interesting as is, mainly for the reference to the original post part (although being able to colour the nickname with the forum colour codes is quite interesting as well, as it tells users directly when a quote is from a moderator or an admin )

[Erik Frèrejean]

High,
I don't know if it has been suggested already (although I doubt it), but it would be nice to add to this mod the following feature (it could be added in a separate mod, but then it would be better anyway to have it working with this mod as well):
Add "quote this message" checkboxes next to each post in a topic, and then when clicking the answer button, having the post form already filled with the quotes from all the messages selected.

It could be an independent mod, but then would anyway require a specific version to use this mod enhancements (as an independent mod would only use the "classic" quote codes, not your improved quote codes).

Anyway, this mod is still very interesting as is, mainly for the reference to the original post part (although being able to colour the nickname with the forum colour codes is quite interesting as well, as it tells users directly when a quote is from a moderator or an admin )

Sorry for the late reply, needed a holyday ,

The feature you request is like multi quote which I'm working on for this mod. At the moment I'm not sure whether I'll include it in the final release but I hope that I can make it work.

[demon327]

mm i found a board with multi quote installed...
http://www.forumkomputer.web.id/phpbb-m ... a-t86.html

[MewDragon]

I'm having a problem with the mod, I edited, successfully I thought, the message_parser file.

I've never edited message_parser before, so I don't know why I'm getting this error.

Fatal error: Call to a member function on a non-object in /home/ceriseis/public_html/volcano/includes/message_parser.php on line 793

[Erik Frèrejean]

Can you post all the codes between lines 783 and 803 for me?

[MewDragon]

/*
* Select the data of the poster
*/
if (is_numeric ($quote_data_parts[0]))
{
$sql_where = 'user_id = ' . (int) $db->sql_escape ($quote_data_parts[0]);
}
else
{
$sql_where = 'username = \'' . $db->sql_escape ($quote_data_parts[0]) . '\'';
}

$sql = "
SELECT user_id
FROM " . USERS_TABLE . "
WHERE {$sql_where}
";
$result = $db->sql_query ($sql);
$row = $db->sql_fetchrow ($result);
if (!$row)

There we go, that should be it. Sorry for the trouble, thanks for the help. xp

[MewDragon]

any recommendations?

[Erik Frèrejean]

sorry for the late response.
It looks like you haven't done all the modifications to includes/message_parser.php, one of the first actions you have to do is something like:

Code: Select all

global $db

Please check that you made all the modifications.

[MewDragon]

Shoot, sorry about that. Shouldn't have missed that.