[ABD] advanced quoting

[fatmcgav]

Hey Mate,

Any joy with getting the Multi-Quote implemented aswell???

Cheers
Gav

Multi-Quote is kind of already a part of phpBB3 by default. Go to the reply screen, and then go down to the topic review frame thing. You'll see quote buttons on the sides.

Yeh, i know that's an option, but it would be equally cool to have multi-quote buttons on the page, so u can just browse down and as ure reading select posts to quote...

Plus it makes it doubly obvious for "normal" users...

Gav

[iyeru42]

Plus it makes it doubly obvious for "normal" users...

You probably were an IPB or vBulletin user before using phpBB, weren't you.

[fatmcgav]

Plus it makes it doubly obvious for "normal" users...

You probably were an IPB or vBulletin user before using phpBB, weren't you.

Nope, only ever used phpBB...
My reasoning is just anything to make it easier for users...

[Erik Frèrejean]

Hey Mate,

Any joy with getting the Multi-Quote implemented aswell???

Cheers
Gav

Multi-Quote is kind of already a part of phpBB3 by default. Go to the reply screen, and then go down to the topic review frame thing. You'll see quote buttons on the sides.

That's true, but I must agree that a muti quote button in the topic it self is a more logical place, so you can mark posts while you're reading the topic.
And I believe that the review frame doesn't show the whole topic, when I gets longer.

But it is kind of tricky, I want to store the data in a cookie but I'm no javascript guru so it takes a lot of trail and error .

[fatmcgav]

Hey Mate,

Any joy with getting the Multi-Quote implemented aswell???

Cheers
Gav

Multi-Quote is kind of already a part of phpBB3 by default. Go to the reply screen, and then go down to the topic review frame thing. You'll see quote buttons on the sides.

That's true, but I must agree that a muti quote button in the topic it self is a more logical place, so you can mark posts while you're reading the topic.
And I believe that the review frame doesn't show the whole topic, when I gets longer.

But it is kind of tricky, I want to store the data in a cookie but I'm no javascript guru so it takes a lot of trail and error .

Hi Erik,

Cheers for the update. Let me know if u need a test subject...

Cheers
Gav

[Erik Frèrejean]

I'll do.

[Erik Frèrejean]

Latest version added to the start post!
This is the version that I submitted to the mod queue some time ago.

I'll start now developing version 1.2, which will get the following new functions:

• Multi quote (Select the posts you want to quote while you're reading the topic)
• Single quote (When there are nested quotes, only the top quote is shown)
• Missing something? Please post it here, and I'll have a look whether I'll add it.

[fatmcgav]

Latest version added to the start post!
This is the version that I submitted to the mod queue some time ago.

I'll start now developing version 1.2, which will get the following new functions:

• Multi quote (Select the posts you want to quote while you're reading the topic)
• Single quote (When there are nested quotes, only the top quote is shown)
• Missing something? Please post it here, and I'll have a look whether I'll add it.

U could've posted this this morn when i was installing ure mod...

Shall download and test now...

Cheers
Gavin

[Erik Frèrejean]

This morning I didn't had the sourceforge.net project yet .

[fatmcgav]

This morning I didn't had the sourceforge.net project yet .

Ah, fair nuf... Dw mate, was only pulling ure leg... only takes 5mins to change...
Just about to test now...

Edit: Just tested, and works fine... Cheers again...

Cheers
Gav

[iyeru42]

Nope, only ever used phpBB...
My reasoning is just anything to make it easier for users...

Multi-quote appeared first with IPB and vBulletin (around the same time actually.) No other message board has it in an actual release.

[fatmcgav]

Hey mate,

Quick one for you... strange little one...

I was looking through my error logs this morning that my forums have generated, and this error kept popping up on every page visit...

[20-Dec-2007 10:47:11 0] [phpBB Debug] [client 83.100.145.66] [File viewtopic.php?f=2&t=5&p=27&_f_=2x] PHP Notice: in file /home/fatmcgav/public_html/nspl-bb3/includes/bbcode.php on line 691 : Undefined index: user_colour

Any ideas???

Edit: Ok, i did a little bit of digging because i was curious, and the code it doesnt like is:

Code: Select all

		elseif ($config['aq_user_link'] === "0" AND $config['aq_user_color'] === "1")
		{
			$username = "<span style=\"color: #".$param['user_colour']."; font-weight: bold;\">" . $param['username'] . "</span>";
		}
		else
		{
			$username = $param['username'];
		}

Cheers
Gavin

[Erik Frèrejean]

Oke, I know what the problem causes. And shall make a fix for it in version 1.2.
A quick way around is:
Open /includes/bbcode.php, Find:

Code: Select all

$data['user_id'] = 1; 

After-add:

Code: Select all

            $data['user_colour'] = "000000"; 

If you don't use black as the default user colour, then change 000000 in the hex value of the colour that you use.

[fatmcgav]

Oke, I know what the problem causes. And shall make a fix for it in version 1.2.
A quick way around is:
Open /includes/bbcode.php, Find:

Code: Select all

$data['user_id'] = 1;  

After-add:

Code: Select all

            $data['user_colour'] = "000000";  

If you don't use black as the default user colour, then change 000000 in the hex value of the colour that you use.

Yep, that did the job...

Though i'll prob just leave the config to not show the username color, as it seems to be showing admin and global mod color's fine anyways...

Cheers
Gav

[Erik Frèrejean]

Though i'll prob just leave the config to not show the username color, as it seems to be showing admin and global mod color's fine anyways...

Even when you turn off that config? .

*runs to test board*

On my board it shows just black with that turned off.