Auto Groups

[pavobe]

I have one special group for user with warnings.

I've got a small problem. Everything is set as 0, only "Min Warning Points" field is 3. I don't know why for example am I added to this group? I don't have any user, that should be in this group, but there have been 5 users so far. What do i do wrong?

[A_Jelly_Doughnut]

pavobe: You might try this fix from a user on the last page: http://www.phpbb.com/community/viewtopi ... 5#p4663105

[pavobe]

Thanks, I will try it.

Sorry, I know I could read last page, but reading so many pages in foreign language is hard for me.

[moozer]

hi jelly

I have created a group with the following settings:
Minimum days of membership: 1
Maximum days of membership: 7

now it seems not all people who created a account last week get forced into this group,
also, and most important to me, random people wich are member for several months get forced into this group. i could be mistaken, but it seems everybody who logges into the website gets forced into this group.

can u please explain this?

[A_Jelly_Doughnut]

moozer: I can't really explain that ... but does it work if you set the minimum days to 0 and the maximum days to 7?

[rashy]

Hi A_Jelly_Doughnut

Asking my question again

Can you please explain with screenshots of phpBB v3.0 how to create a new group say "new". Every newly registered member should go in this group, they have achieved the post count of 20 posts only then they could enter certain topics and upgraded to normal registered group
Soory for asking this much cause i got it installed without any problem but am facing problems in using it

[moozer]

moozer: I can't really explain that ... but does it work if you set the minimum days to 0 and the maximum days to 7?

I tried all the configurations i could think of, buet everytime the mod addad more people to the group than it should.
then i found this code (either in this topic, or the closed one in the "mods in progress" forum):

Code: Select all

                if ($user_id == ANONYMOUS)
                  {
                      continue;
                  }
  
                  // If there is no limit, skip it.
                  if ((int) $data['group_min_' . $column] == 0 && (int) $data['group_max_' . $column] == 0)
                  {
                      continue;
                  }
  
                  // If they are outside the thresholds ...
                  if (($data['group_min_' . $column] != 0 && $value < $data['group_min_' . $column]) ||
                      ($data['group_max_' . $column] != 0 && $value > $data['group_max_' . $column]))
                  {
                      $remove_groups[$group_id][] = $user_id;
                  }
                  else if ((($data['group_min_' . $column] != 0 && $value >= $data['group_min_' . $column]) ||
                            ($data['group_max_' . $column] != 0 && $value <= $data['group_max_' . $column])) &&
                           (!isset($remove_groups[$group_id]) || !in_array($user_id, $remove_groups[$group_id])))
                  {
                      $add_groups[$group_id][] = $user_id;
                  }

after replacing a part of the original code with this code, it works properly. everyday im checking if all the users are in the right group, cause after a few mistakes im not fully trusting it if u know what i mean but for the last 2 days it now works like it should.

something else,
would it work if i add a similair code in it for the user_lastvisit row?
im not really good at writing code, but i can manage my way around and so i would like to try making a group for people who not visited the website for a perticular time...i think it could be very helpfull for many phpbb users aswell.
soooo, it would help me alot if u could let me know if im on the right track if i use similar codes used for the user_regdate part

[moozer]

oke, it seems the "lastactive" group is doing its thing now..
people get forced into and out groups when they visit again right? so they will only get moved to the "not active group" when they visit again. is there a way to move them as soon as they hit the setted "lastactive" amount of days? even when they are not visiting the website?

edit.
i am confucing myself ofcourse people will not get moved to the "not active" group when they visit again, cause when they visit again, they are active again and the column get changed.. hehe, i really could use some help with this, so if anyone is in the mood for this ...

[soumik]

Thank you, A_Jelly_Doughnut, for this wonderful mod.

[Dogginator]

just forget it naturally blonde ... thanx ...

Moni

[mejane]

Thanks for the great MOD Jelly. Works fine once I realised I should clear cache following install

[CorporateGoth]

Another bug I found which cropped up while trying to delete a topic:

Here is the existing code:

Code: Select all

          // because phpBB doesn't check if users are actually members of the group
          // before removing them, we check it before calling group_user_del()
          foreach ($remove_groups as $group_id => $user_id_ary)
          {     
              $remove_groups[$group_id] = implode(', ', $user_id_ary);
          }
            
          $sql = 'SELECT user_id, group_id FROM ' . USER_GROUP_TABLE . '
              WHERE ' . $db->sql_in_set('group_id', array_keys($remove_groups)) . '
              AND ' . $db->sql_in_set('user_id', array_values($remove_groups));
          $result = $db->sql_query($sql);

The problem is it creates code like "WHERE group_id = 236 AND user_id = 123, 456, 789"

Here is the corrected code:

Code: Select all

          // because phpBB doesn't check if users are actually members of the group
          // before removing them, we check it before calling group_user_del()
          $user_ids = array();
          foreach ($remove_groups as $group_id => $user_id_ary)
          {     
              $user_ids = array_merge($user_ids, $user_id_ary);
          }
            
          $sql = 'SELECT user_id, group_id FROM ' . USER_GROUP_TABLE . '
              WHERE ' . $db->sql_in_set('group_id', array_keys($remove_groups)) . '
              AND ' . $db->sql_in_set('user_id', $user_ids);
          $result = $db->sql_query($sql);

This properly puts all user ID's into an array so that the 'AND' condition is accurate.

[ddeg10]

Even with the fix discussed a few posts ago, I am still having issues.

My settings consist of the following:

Minimum days of membership: 730 (2 years)
Maximum days of membership: 0
Minimum post count: 100
Maximum post count: 0
Minimum warnings points: 0
Maximum warning points: 3

So basically I am making a "Senior Members" area where users who have been registered on the forum for 2 years, have at least 100 posts, and less than 3 warnings, will be granted access to this area. However, every time I set this criteria, after I check the group a few minutes later, there are users in this group who haven't even been members for 1 year yet. Is there a fix for this?

[david63]

Should you not be setting Minimum post count = 100 and Maximum post count = 0?????

[ddeg10]

Should you not be setting Minimum post count = 100 and Maximum post count = 0?????

Sorry, that was a typo - yes it is set to 100. I have edited the post.