[Alpha] Troll MOD (Alpha 2)

A place for MOD Authors to post and receive feedback on MODs still in development. No MODs within this forum should be used within a live environment!
Ideas Centre
User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Re: [Dev] Troll MOD

Post by igorw »

Thanks, fixed that :)
Igor Wiedler | area51 | GitHub | trashbin | Formerly known as evil less than three
jmjm003
Registered User
Posts: 275
Joined: Sat Dec 22, 2007 7:05 pm

Re: [Dev] Troll MOD

Post by jmjm003 »

I had to increase max_execution_time = with my custom php.ini to avoid timeouts over 30 seconds.
Might give away the fact they are be messed with when they see a timeout and it points to troll_sleep.php .

I thought of changing the sleep time within the sleep file. Decided the longer the better.
User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Re: [Dev] Troll MOD

Post by igorw »

I've made a "logo" for the MOD :D

Image
jmjm003 wrote:I had to increase max_execution_time = with my custom php.ini to avoid timeouts over 30 seconds.
Might give away the fact they are be messed with when they see a timeout and it points to troll_sleep.php .

I thought of changing the sleep time within the sleep file. Decided the longer the better.
That's one very important point. I will add error suppression to the sleep() calls and a set_time_limit call if the user is a troll.

Thanks for all the testing! It's very helpful :)
Igor Wiedler | area51 | GitHub | trashbin | Formerly known as evil less than three
User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Re: [Dev] Troll MOD

Post by igorw »

Thanks for the reports/suggestions, i've just committed following:
  • Case insensitive usernames in troll acp
  • add error suppression to the sleep() calls and a set_time_limit call if the user is a troll
I have more on my todo list, this doesn't mean you're not allowed to extend it :lol:
Igor Wiedler | area51 | GitHub | trashbin | Formerly known as evil less than three
mtrs
Registered User
Posts: 2049
Joined: Sat Sep 22, 2007 2:39 pm

Re: [Dev] Troll MOD

Post by mtrs »

Is it also possible to treat some IP addresses/ranges like a troll user? Similar to banning to IPs or IP ranges..
I abandoned all of my mods.
jmjm003
Registered User
Posts: 275
Joined: Sat Dec 22, 2007 7:05 pm

Re: [Dev] Troll MOD

Post by jmjm003 »

Bug?
With my test account set as a troll. I then set the account as a founder. Troll mod did not release this account.
Under normal circumstances you would never set a troll as a founder like I did. Thought I would throw it your way and let you do what you do when you do it. :?

EDIT: Under normal conditions a founder cannot be added to the troll list. So the above is not really a bug.
RedTrinity
Registered User
Posts: 1327
Joined: Sat May 06, 2006 3:32 am

Re: [Dev] Troll MOD

Post by RedTrinity »

Hi Evil,

Got a new error to report via a Co-Admin who tested out the MOD this morning (victim lol) - this was after updating to the new base.php:

Code: Select all

Fatal error: Cannot redeclare class troll_action in /home/redtrin/public_html/forum/includes/troll/base.php on line 23
It apparently occurred whilst navigating to the index page :)
metathesiophobia
Registered User
Posts: 10
Joined: Tue Feb 19, 2008 1:02 pm
Location: Germany

Re: [Dev] Troll MOD

Post by metathesiophobia »

I'll test this MOD within the next few days, too. I'd like to support to the developer wherever I can - because I just love it (though it's not released officially yet)! ;)

If no one has already done this so far: I'd like to "produce" a german translation for this MOD (if that´s okay).

Keep it on, evil!

Greets
User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Re: [Dev] Troll MOD

Post by igorw »

jmjm003 wrote:EDIT: Under normal conditions a founder cannot be added to the troll list. So the above is not really a bug.
Yep, it's already taken care of. If the troll founder logs in, he is no longer treated a troll. Well i just made a change to improve that. :)
RedTrinity wrote:Hi Evil,

Got a new error to report via a Co-Admin who tested out the MOD this morning (victim lol) - this was after updating to the new base.php:
Try a fresh functions_troll.php, something might have gone wrong with updating, it should only be included once.
metathesiophobia wrote:I'll test this MOD within the next few days, too. I'd like to support to the developer wherever I can - because I just love it (though it's not released officially yet)! ;)

If no one has already done this so far: I'd like to "produce" a german translation for this MOD (if that´s okay).

Keep it on, evil!
Thanks for your support! I will look into translations a bit later. I can actually do a german translation myself :P But i don't want it at this stage yet. Trotzdem danke ;)
Igor Wiedler | area51 | GitHub | trashbin | Formerly known as evil less than three
jmjm003
Registered User
Posts: 275
Joined: Sat Dec 22, 2007 7:05 pm

Re: [Dev] Troll MOD

Post by jmjm003 »

Seem to have run into an issue.
Started today after I moved the module in the ACP. I seem to have an issue when it comes to untrolling a member. So I started over in case I messed something up.
I've downloaded and installed the latest revision (28). Added the module in the ACP. Placed it under Users and Groups>Users>Troll . Set my test account as a troll. That worked fine. Now, when I try to untroll my test account it doesn't release the account. Delete all board cookies doesn't remove it. I have to delete the cookie manually to free the account of it.

I've been running this on a home server. It was working fine yesterday with the older files. I've tested the account on two computers to make sure one of them wasn't keeping the cookie locked some how.

Thoughts?

EDIT: Would like to note. If I set the member as a founder, it frees them of the troll mod (without logging out and back in.). I then remove the founder setting and they remain free of it.
Don't know how much that will help you, if any. Thought I would point it out.

Thanks for your work Evil.
RedTrinity
Registered User
Posts: 1327
Joined: Sat May 06, 2006 3:32 am

Re: [Dev] Troll MOD

Post by RedTrinity »

jmjm003 wrote: Now, when I try to untroll my test account it doesn't release the account. Delete all board cookies doesn't remove it. I have to delete the cookie manually to free the account of it.
I would like to confirm this problem as well :D Last night one of my moderators (whom I had tested this MOD on previously) was complaining that she kept getting a random error message whilst navigating the forum. Turns out she had to clean out her cookies in order to get everything to go back to normal - she was still experiencing Troll MOD symptoms even after I had removed her username via the ACP.

Thanks btw Evil in regards to the tip earlier, I replaced the includes file and sure enough it didn't appear to be the most recent one. So will test that again today to make sure all is well now :)
User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Re: [Dev] Troll MOD

Post by igorw »

jmjm003 wrote:Delete all board cookies doesn't remove it.
Of course not :P That's excactly what the edit to ucp.php does ;)

I've taken a look at your description. Currently a user will be trolled as soon as he has the troll cookie, unless he is a founder. So as you said, the trolls remain trolled after being untrolled ( :lol: ). I'm going to make some changes to that.

1. check if founder, founders are not treated as trolls
2. check if user has no troll cookie and no troll entry, let him pass
3. check if user is logged in and not a troll but has the troll cookie - delete the cookie and don't treat as troll
4. user is a troll, torture

RedTrinity, glad that fixed it. :)

Thanks guys, i'll implement that when i get home. :D
Igor Wiedler | area51 | GitHub | trashbin | Formerly known as evil less than three
RedTrinity
Registered User
Posts: 1327
Joined: Sat May 06, 2006 3:32 am

Re: [Dev] Troll MOD

Post by RedTrinity »

Sounds good :D That is what made the other Troll MOD so effective I think, having the cookie component. That way the board will still recognise them, even if they are logged out or using another account etc.

Speaking of which, perhaps its worth considering the option to prevent a troll from re-registering (in the event of a persistent troll lol)? Maybe have an error message, a timeout or something else happen if they try to do so.

Just a suggestion :D
User avatar
igorw
Former Team Member
Posts: 8024
Joined: Fri Dec 16, 2005 12:23 pm
Location: {postrow.POSTER_FROM}
Name: Igor Wiedler

Re: [Dev] Troll MOD

Post by igorw »

Well, i'm now making it that if a user with troll cookie logs in, his troll cookie will be removed. I plan on adding a configuration option to alternativeley allow that account to get trolled as well. I think i'll call it "Troll virus". :D
Igor Wiedler | area51 | GitHub | trashbin | Formerly known as evil less than three
User avatar
Blue_Star
Registered User
Posts: 50
Joined: Wed Jun 27, 2007 10:25 pm

Re: [Dev] Troll MOD

Post by Blue_Star »

This just keeps getting better and better! lmao

Return to “[3.0.x] MODs in Development”