24 Hour Activity Stats

Hidden users are displayed for simple users - 24 Hour Activity Stats

Hidden users are displayed for simple users

by Galixte de EzCom » Sun Jun 24, 2018 10:40 pm

Hi,

this issue isn’t fixed: https://github.com/rmcgirr83/phpBB-3.1- ... -333785575.

In awaiting the fix by rmcgirr83, there is a workaround here: http://forums.phpbb-fr.com/extensions-s ... l#p1658019.

Regards.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: Hidden users are displayed for simple users

by RMcGirr83 » Mon Jun 25, 2018 12:51 am

What is a "simple" user?
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Hidden users are displayed for simple users

by Galixte de EzCom » Mon Jun 25, 2018 1:30 am

In this case a user without any permission to see hidden users, like by default after a fresh installation of phpBB 3.2.x.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: Hidden users are displayed for simple users

by Tastenplayer » Thu Jun 28, 2018 6:51 am

True, I noticed that before, too! A member can also see the invisible members in this extension. This although in acp the authorization is set to no.
24hours mitglieder.jpg
My phpBB Style Board & MoreFlowerPower 3.2.8 Screenshots & Download
Be the best version of yourself rather than a bad copy of someone else!
Excuse me for my English, but I learned the language by speaking to people and not at school.
User avatar
Tastenplayer
Registered User
Posts: 380
Joined: Thu Jul 03, 2014 9:20 pm
Location: Switzerland
Name: Jutta Koliofotis
Contact:

Re: Hidden users are displayed for simple users

by LukeWCS » Mon Jul 16, 2018 11:17 am

Thanks for the hint about this workaround!

But this workaround produces two new bugs:
  1. The visible user count is completely wrong and of course also the total user count.
  2. The user names have now links to their profiles also clickable to guests.
I don't know what the intention was from the author of this workaround, but not only to fix this invisible-user-bug.

Ergo, not usable.
May the backup be with you. Always.

My extensions: Monospace font for Posting Editor (phpbb.de)
My extension forks: LF who was here (phpbb.de / phpbb.com), ModBreak eXtended (phpbb.com)
User avatar
LukeWCS
Registered User
Posts: 148
Joined: Mon Dec 08, 2014 12:32 pm
Location: Germany
Contact:

Re: Hidden users are displayed for simple users

by RMcGirr83 » Mon Jul 16, 2018 11:53 am

LukeWCS wrote:Ergo, not usable.
Then don't use it.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Hidden users are displayed for simple users

by LukeWCS » Mon Jul 16, 2018 12:08 pm

I meant the workaround, not your ext.

I don't use the workaround of course, currently I test my own fix.
May the backup be with you. Always.

My extensions: Monospace font for Posting Editor (phpbb.de)
My extension forks: LF who was here (phpbb.de / phpbb.com), ModBreak eXtended (phpbb.com)
User avatar
LukeWCS
Registered User
Posts: 148
Joined: Mon Dec 08, 2014 12:32 pm
Location: Germany
Contact:

Re: Hidden users are displayed for simple users

by Galixte de EzCom » Sat Jul 21, 2018 6:34 pm

Hi,

stone23 updated his fix, here: http://forums.phpbb-fr.com/extensions-s ... l#p1658019.
Last edited by Galixte de EzCom on Sun Jul 22, 2018 10:59 am
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: Hidden users are displayed for simple users

by RMcGirr83 » Sat Jul 21, 2018 9:33 pm

Which you already posted here: https://www.phpbb.com/customise/db/exte ... 26#p639526 and which was stated to not work a few posts up.

PS clicking on the "TOUT SÉLECTIONNER" within the code box doesn't work the way it should on your forum so you may want to fix that while you're fixing things.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Hidden users are displayed for simple users

by Galixte de EzCom » Sun Jul 22, 2018 11:03 am

Sorry I would to say “stone23 updated his fix”.

We already have noticed to the phpBB-fr Team about code box issue but they didin’t fix this. :/
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: Hidden users are displayed for simple users

by RMcGirr83 » Sun Jul 22, 2018 3:48 pm

Galixte de EzCom wrote:Sorry I would to say “stone23 updated his fix”.
Probably because they don't know how to as they are using some SEO garbage thing. Best way for stone23 to get his fix into this extension is for him to do a PR against the github repo.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Hidden users are displayed for simple users

by Galixte de EzCom » Mon Jul 23, 2018 9:24 am

Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: Hidden users are displayed for simple users

by RMcGirr83 » Mon Jul 23, 2018 11:26 am

The PR failed and have these issues been fixed? It doesn't seem so.
LukeWCS wrote:Thanks for the hint about this workaround!

But this workaround produces two new bugs:
  1. The visible user count is completely wrong and of course also the total user count.
  2. The user names have now links to their profiles also clickable to guests.
***SNIP***

Ergo, not usable.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Hidden users are displayed for simple users

by Galixte de EzCom » Mon Jul 23, 2018 12:07 pm

This error?

Code: Select all

Error: Packaging structure doesn't meet the extension DB policies.
Expected: rmcgirr83/activity24hours
Got: 
Warning: "GPL-2.0" is a deprecated SPDX license identifier, use "GPL-2.0-only" instead. in /composer.json
About these feedbacks:
  1. The visible user count is completely wrong and of course also the total user count.
    I agree, the total has a value 1 higher than the true total value.
  2. The user names have now links to their profiles also clickable to guests.
    I agree, i’s indeed the case.
I’ll return these feedbacks to stone23.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: Hidden users are displayed for simple users

by RMcGirr83 » Mon Jul 23, 2018 9:45 pm

Galixte de EzCom wrote:This error?
No these errors

https://travis-ci.org/rmcgirr83/phpBB-3 ... #L655-L661
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact: