Advertisement Management

All Good except Ads aren't Showing - Advertisement Management

All Good except Ads aren't Showing

by Matnum PI » Thu Feb 13, 2020 7:44 pm

I downloaded this extension, uploaded it, can access it via the board, it says my Adsense code is correct, it seems to be AOK, and... The adsense ads don't show up. My Adsense code works fine on my website (which is Wordpress and uses a completely different app, obviously). Just doesn't work on phpBB3. Any ideas?
Caddy Day
Caddies Welcome 1-1:15
User avatar
Matnum PI
Registered User
Posts: 53
Joined: Tue Jan 18, 2005 6:44 pm

Re: All Good except Ads aren't Showing

by DavidIQ » Thu Feb 13, 2020 11:09 pm

A link to the board where this was enabled for an ad location would be a good start.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 17182
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: All Good except Ads aren't Showing

by Matnum PI » Fri Feb 14, 2020 10:05 pm

Sorry. So this is the forum and specific page within the forum: FanLax. I've set-up the extension so the ad should be at the bottom of the page (also tried other locations but currently set to this) and... It's just not showing up. Not sure why. Seems like everything else is correct.
Caddy Day
Caddies Welcome 1-1:15
User avatar
Matnum PI
Registered User
Posts: 53
Joined: Tue Jan 18, 2005 6:44 pm

Re: All Good except Ads aren't Showing

by Matnum PI » Sun Feb 16, 2020 6:23 am

Is there any other information that I can provide to resolve this?
Caddy Day
Caddies Welcome 1-1:15
User avatar
Matnum PI
Registered User
Posts: 53
Joined: Tue Jan 18, 2005 6:44 pm

Re: All Good except Ads aren't Showing

by Matnum PI » Fri Feb 21, 2020 3:11 pm

So I hired a pro to take a look and he's baffled. He said that the ad code is being loaded into the page properly. I've tried reloading the cache, double checked that the code is correct, and... I'm unsure what to do next. Any ideas?
Caddy Day
Caddies Welcome 1-1:15
User avatar
Matnum PI
Registered User
Posts: 53
Joined: Tue Jan 18, 2005 6:44 pm

Re: All Good except Ads aren't Showing

by Matnum PI » Fri Feb 21, 2020 3:38 pm

I think the issue is that I need to upgrade to 3.3. I think...
Caddy Day
Caddies Welcome 1-1:15
User avatar
Matnum PI
Registered User
Posts: 53
Joined: Tue Jan 18, 2005 6:44 pm

Re: All Good except Ads aren't Showing

by VSE » Sat Feb 22, 2020 1:45 am

When I look at your site, it seems like ads are not showing because you don't have any. All I see is something is just a call to some google Adsense Javascript.

Code: Select all

<div style="margin: 10px 0;" data-ad-id="1">
	<script data-ad-client="ca-pub-6166743192973049" async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>
</div>
That code does not look like it was put there by this extension, and it's the only ad code on your site that I can see.
🧩 My Extensions 🧩 ✨ YES...they ALL work with phpBB 3.3!! ✨
Please do not PM me for support.
User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5108
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: All Good except Ads aren't Showing

by Matnum PI » Sun Feb 23, 2020 12:44 am

I needed to insert the ads "By Ad Unit", not "By Site". Resolved. Thanks.
Caddy Day
Caddies Welcome 1-1:15
User avatar
Matnum PI
Registered User
Posts: 53
Joined: Tue Jan 18, 2005 6:44 pm

Re: All Good except Ads aren't Showing

by KYPREO » Tue Mar 03, 2020 3:29 am

For anyone who comes across this, the above Javascript is the code for Adsense Auto Ads. This can actually work, but to implement it you need to stick the Javascript in the head and not the body and then Adsense incorporates the ad code throughout the page dynamically. But it only works if the Auto Ad is enabled for that publisher ID within the Adsense console itself. You then need to configure the Auto Ad to say how many ads you want etc .

I believe this JS can be added through this extension by using the script/hidden location (I'm using an older version so cannot test). Otherwise it needs to be added manually to the overall_header file (with if statements to restrict it to content pages only).
phpBB user since 2002
www.AusRotary.com
KYPREO
Registered User
Posts: 388
Joined: Fri Feb 02, 2018 9:56 am
Contact: