Ban Hammer

Language issues - Ban Hammer

Language issues

by leschek » Mon Mar 30, 2015 10:49 am

Thanks for this extension.

During testing I found a few language issues. All of them are on page, where admin confirms deleting user:

  1. Problem with coding of message in "Internal reason" and "Reason to user" - if I write there non English characters I see question marks instead of them.
  2. Colon after "Ban this user" - it looks like there is missing username
  3. All the option after "This will" should have their own language strings, because in some languages the "Imperative mood" is different from "Future tense"
leschek
Registered User
Posts: 791
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Label text missing

by Webwatcher_eu » Wed May 27, 2015 9:53 am

it looks like tat for CANNOT_BAN_FOUNDER is a language text missing (en)
User avatar
Webwatcher_eu
Registered User
Posts: 102
Joined: Tue Nov 25, 2014 10:59 am
Contact:

Re: Language issues

by Kot Matroskin » Sun Mar 26, 2017 3:57 pm

leschek wrote:
  1. Problem with coding of message in "Internal reason" and "Reason to user" - if I write there non English characters I see question marks instead of them.
The issue is still reproducible.

Database collation is utf8_bin, and I see that reasons from Ban Hammer represent question marks (instead from other reasons).
User avatar
Kot Matroskin
Registered User
Posts: 126
Joined: Sat May 29, 2010 9:44 am
Location: Minsk, Belarus
Name: Vitaly Filatenko
Contact:

Re: Language issues

by RMcGirr83 » Sun Mar 26, 2017 4:59 pm

There hasn't been a new version submitted so yeah the problem is still there.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Language issues

by RMcGirr83 » Mon Mar 27, 2017 4:46 pm

All issues have been taken care of with the latest version that is waiting in the queue to be validated.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Language issues

by Kot Matroskin » Mon Mar 27, 2017 5:47 pm

Where is "thanks" button on this forum? ;)
User avatar
Kot Matroskin
Registered User
Posts: 126
Joined: Sat May 29, 2010 9:44 am
Location: Minsk, Belarus
Name: Vitaly Filatenko
Contact:

Re: Language issues

by hd321kbps » Wed May 10, 2017 8:32 am

In version 1.0.1, the bug has not been fixed.
User avatar
hd321kbps
Registered User
Posts: 189
Joined: Tue Oct 16, 2012 10:16 am
Location: Russian
Name: Igor Marchuk
Contact:

Re: Language issues

by RMcGirr83 » Wed May 10, 2017 9:28 am

hd321kbps wrote:In version 1.0.1, the bug has not been fixed.
Which bug?
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Language issues

by Kot Matroskin » Wed May 10, 2017 12:05 pm

User avatar
Kot Matroskin
Registered User
Posts: 126
Joined: Sat May 29, 2010 9:44 am
Location: Minsk, Belarus
Name: Vitaly Filatenko
Contact:

Re: Language issues

by RMcGirr83 » Wed May 10, 2017 1:02 pm

Damn it, missed one.

Open the listener file and find these lines

Code: Select all

// Any reason for this ban?
$bh_reason		= $this->request->variable('bh_reason', '');
$bh_reason_user	= $this->request->variable('bh_reason_user', '');
change to this

Code: Select all

// Any reason for this ban?
$bh_reason		= $this->request->variable('bh_reason', '', true);
$bh_reason_user	= $this->request->variable('bh_reason_user', '', true);
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Language issues

by RMcGirr83 » Tue Jun 06, 2017 1:37 pm

Fixed in latest version
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact: